[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-11 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201316#comment-16201316
 ] 

Hudson commented on HBASE-18874:


FAILURE: Integrated in Jenkins build HBase-1.4 #950 (See 
[https://builds.apache.org/job/HBase-1.4/950/])
HBASE-18959 Backport HBASE-18874 (HMaster abort message will be skipped (tedyu: 
rev 22e2539d0cc4c987e6871a7cd4945f3f25d48774)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-11 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201135#comment-16201135
 ] 

Hudson commented on HBASE-18874:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #320 (See 
[https://builds.apache.org/job/HBase-1.3-JDK8/320/])
HBASE-18959 Backport HBASE-18874 (HMaster abort message will be skipped (tedyu: 
rev cdbda777f64a652139339b2024e0b7b1397f5f37)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-11 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201133#comment-16201133
 ] 

Hudson commented on HBASE-18874:


FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #306 (See 
[https://builds.apache.org/job/HBase-1.3-JDK7/306/])
HBASE-18959 Backport HBASE-18874 (HMaster abort message will be skipped (tedyu: 
rev cdbda777f64a652139339b2024e0b7b1397f5f37)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199150#comment-16199150
 ] 

Hudson commented on HBASE-18874:


SUCCESS: Integrated in Jenkins build HBase-1.5 #91 (See 
[https://builds.apache.org/job/HBase-1.5/91/])
HBASE-18959 Backport HBASE-18874 (HMaster abort message will be skipped (tedyu: 
rev 2828427219015348c380a4380d1670e2c3d163e0)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195090#comment-16195090
 ] 

Hudson commented on HBASE-18874:


Results for branch HBASE-18467, done in 4 hr 24 min and counting
[build #136 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136/]: 
FAILURE

details (if available):

(x) *{color:red}-1 overall{color}*
Committer, please check your recent inclusion of a patch for this issue.

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136//General_Nightly_Build_Report/]










(/) {color:green}+1 jdk8 checks{color}
-- For more information [see jdk8 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18467/136//JDK8_Nightly_Build_Report/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.



> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-04 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192488#comment-16192488
 ] 

Pankaj Kumar commented on HBASE-18874:
--

Yeah, this make sense. Will backport to branch-1 using new JIRA. 
Thanks for the guidance. 

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191764#comment-16191764
 ] 

Hadoop QA commented on HBASE-18874:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
25s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
25s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
56s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
42s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
55s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
24s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 16m 
56s{color} | {color:red} The patch causes 178 errors with Hadoop v3.0.0-alpha4. 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}398m 58s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  4m 
36s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}438m 21s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.util.TestHBaseFsck |
|   | hadoop.hbase.client.TestClientOperationInterrupt |
|   | hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort |
|   | hadoop.hbase.client.TestReplicasClient |
|   

[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-10-04 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191121#comment-16191121
 ] 

Pankaj Kumar commented on HBASE-18874:
--

HBASE-18874-branch-1.patch can be applied to branch-1.4/1.3/1.2 also.

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18874-branch-1.patch, HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182477#comment-16182477
 ] 

Ted Yu commented on HBASE-18874:


You can log backport JIRA and work on it. 
Once it is merged you can attach branch-1 patch here. 

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-27 Thread Pankaj Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182463#comment-16182463
 ] 

Pankaj Kumar commented on HBASE-18874:
--

Sorry for late reply [~tedyu], currently this issue is applicable only for 
branch-2 and master.  

In other branches we are invoking HRegionServer's stop(String) which will log 
the message, 
{code}
  public void abort(final String msg, final Throwable t) {
if (isAborted() || isStopped()) {
  return;
}
if (cpHost != null) {
  // HBASE-4014: dump a list of loaded coprocessors.
  LOG.fatal("Master server abort: loaded coprocessors are: " +
  getLoadedCoprocessors());
}
if (t != null) LOG.fatal(msg, t);
stop(msg);
  }
{code}


Actually this issue was introduced by HBASE-14499 in master branch and we 
missed to fix HBASE-14499 in branch-1 and other branches as well. Shall I 
backport first HBASE-14499 to other branches?

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181620#comment-16181620
 ] 

Ted Yu commented on HBASE-18874:


I am waiting for branch-1 patch.

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-26 Thread Mike Drob (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181590#comment-16181590
 ] 

Mike Drob commented on HBASE-18874:
---

[~tedyu] - This is done? Can you add fix versions and resolve the JIRA if that 
is the case?

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-26 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181552#comment-16181552
 ] 

Hudson commented on HBASE-18874:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3784 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3784/])
HBASE-18874, HMaster abort message will be skipped if Throwable is (tedyu: rev 
9e7b16b88ed6e9c2c3f53743bfe5c74098f2b8a4)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-26 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181481#comment-16181481
 ] 

Hudson commented on HBASE-18874:


FAILURE: Integrated in Jenkins build HBase-2.0 #583 (See 
[https://builds.apache.org/job/HBase-2.0/583/])
HBASE-18874, HMaster abort message will be skipped if Throwable is (tedyu: rev 
6d0eb0eef019a524e5226df6f8a4bee69908ea3c)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181136#comment-16181136
 ] 

Ted Yu commented on HBASE-18874:


If you want this to go to branch-1, please attach patch for branch-1.

> HMaster abort message will be skipped if Throwable is passed null
> -
>
> Key: HBASE-18874
> URL: https://issues.apache.org/jira/browse/HBASE-18874
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Attachments: HBASE-18874.patch
>
>
> In HMaster class, we are logging abort message only in case when Throwable is 
> not null,
> {noformat}
> if (t != null) LOG.fatal(msg, t);
> {noformat}
> We will miss the abort message in this case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (HBASE-18874) HMaster abort message will be skipped if Throwable is passed null

2017-09-26 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-18874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180863#comment-16180863
 ] 

Hadoop QA commented on HBASE-18874:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
55s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 
17s{color} | {color:red} hbase-server in master has 1 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
54s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
36m  9s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 93m  
8s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
19s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}147m 11s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18874 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12889059/HBASE-18874.patch |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 666a08ad9e8d 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 410368b |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8794/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8794/testReport/ |
| modules | C: hbase-server U: