[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195959#comment-16195959
 ] 

Hudson commented on HBASE-18899:


FAILURE: Integrated in Jenkins build HBase-2.0 #645 (See 
[https://builds.apache.org/job/HBase-2.0/645/])
HBASE-18899 Make Fileinfo more readable in HFilePrettyPrinter (chia7712: rev 
9ae2750588594a8d02e63d8e1f61967314b0)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java


> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195953#comment-16195953
 ] 

Hudson commented on HBASE-18899:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3846 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/3846/])
HBASE-18899 Make Fileinfo more readable in HFilePrettyPrinter (chia7712: rev 
bb28a3b4660a64bb513ffe4399e72679fc2dcec5)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java


> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-07 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195827#comment-16195827
 ] 

Chia-Ping Tsai commented on HBASE-18899:


Will commit it later.

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-10-02 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188319#comment-16188319
 ] 

Chia-Ping Tsai commented on HBASE-18899:


It seems we must refactor our I/O components. There are some abandoned and 
stale code which may make us confused, but this problem doesn't intensify even 
if we commit this patch.
+1

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Guangxu Cheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185321#comment-16185321
 ] 

Guangxu Cheng commented on HBASE-18899:
---

h, HFilePrettyPrinter is just a tool to print the information of a HFile.
Althouth the HFile doesn't know nothing about its content.But 
HFilePrettyPrinter is different from HFile.
I think that it is reasonable to print readable metadata by judging the field 
name.
WDYT?[~ndimiduk] [~yuzhih...@gmail.com]  [~clin]

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184807#comment-16184807
 ] 

Hadoop QA commented on HBASE-18899:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
44s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
23s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
 2s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
40m 43s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}104m  
2s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}168m 43s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18899 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12889534/HBASE-18899.master.v2.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 084beae33561 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / 74d0adc |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8852/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8852/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Nick Dimiduk (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184741#comment-16184741
 ] 

Nick Dimiduk commented on HBASE-18899:
--

It's no problem [~andrewcheng]. I just recognized the topic and thought you 
might be interested in the hurdles the blocked a previous attempt. As I recall, 
we have trouble splitting responsibility for such a tool. IIRC, a 
{{StoreFilePrettyPrinter}} would provide better scoping and guidance for 
interfaces vs. implementation of storefiles.

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184682#comment-16184682
 ] 

Hadoop QA commented on HBASE-18899:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
55s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
36m 32s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 89m 15s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}145m 55s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18899 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12889501/HBASE-18899.master.v1.patch
 |
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux aa5dd90553c7 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / a11a35a |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/8851/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results |

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Guangxu Cheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184504#comment-16184504
 ] 

Guangxu Cheng commented on HBASE-18899:
---

bq.Maybe take a peek at the long forgotten HBASE-7690 ?
[~ndimiduk] Sorry, I just did not find this issue.:(

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, 
> HBASE-18899.master.v2.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Nick Dimiduk (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184448#comment-16184448
 ] 

Nick Dimiduk commented on HBASE-18899:
--

Maybe take a peek at the long forgotten HBASE-7690 ?

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile
>Affects Versions: 3.0.0, 1.5.0, 2.0.0-alpha-4
>Reporter: Guangxu Cheng
>Assignee: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184298#comment-16184298
 ] 

Ted Yu commented on HBASE-18899:


lgtm

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
> Attachments: HBASE-18899.master.v1.patch, HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Chia-Ping Tsai (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184185#comment-16184185
 ] 

Chia-Ping Tsai commented on HBASE-18899:


The output results look good to me. What about using {{Bytes.Equals(byte[], 
byte[])}}? That will be faster and more readable.

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
> Attachments: HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-18899) Make Fileinfo more readable in HFilePrettyPrinter

2017-09-28 Thread Guangxu Cheng (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-18899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184170#comment-16184170
 ] 

Guangxu Cheng commented on HBASE-18899:
---

{code}
Fileinfo:
BLOOM_FILTER_TYPE = ROW
DELETE_FAMILY_COUNT = 0
EARLIEST_PUT_TS = 1504613633743
KEY_VALUE_VERSION = 1
LAST_BLOOM_KEY = f
MAJOR_COMPACTION_KEY = true
MAX_MEMSTORE_TS_KEY = 24
MAX_SEQ_ID_KEY = 27
TIMERANGE = 15046136337431506570582061
hfile.AVG_KEY_LEN = 14
hfile.AVG_VALUE_LEN = 3
hfile.CREATE_TIME_TS = 1506572258041
hfile.LASTKEY = f/i:/1506570582061/Put/vlen=0/mvcc=0
{code}
After this patch, output results as above.

> Make Fileinfo more readable in HFilePrettyPrinter
> -
>
> Key: HBASE-18899
> URL: https://issues.apache.org/jira/browse/HBASE-18899
> Project: HBase
>  Issue Type: Bug
>Reporter: Guangxu Cheng
> Attachments: HBASE-18899.patch
>
>
> Fileinfo as follows. some fields can print  readable values.
> {code}
> Fileinfo:
> BLOOM_FILTER_TYPE = ROW
> DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
> EARLIEST_PUT_TS = \x00\x00\x01^Q\xF6\x0E\xCF
> KEY_VALUE_VERSION = \x00\x00\x00\x01
> LAST_BLOOM_KEY = f
> MAJOR_COMPACTION_KEY = \xFF
> MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x18
> MAX_SEQ_ID_KEY = 27
> TIMERANGE = 15046136337431506570582061
> hfile.AVG_KEY_LEN = 14
> hfile.AVG_VALUE_LEN = 3
> hfile.CREATE_TIME_TS = \x00\x00\x01^\xC6\xB4J\xF9
> hfile.LASTKEY = \x00\x01f\x01i\x00\x00\x01^\xC6\x9A\xB8-\x04
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)