[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195958#comment-16195958 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-2.0 #645 (See [https://builds.apache.org/job/HBase-2.0/645/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 9cd7619b5c858130e92806c40747148a89a02940) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195952#comment-16195952 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3846 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3846/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 08274045c9d4688cc175f96a484b8b8fc2e161da) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195912#comment-16195912 ] Hudson commented on HBASE-18921: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #227 (See [https://builds.apache.org/job/HBase-1.2-JDK8/227/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 0205109c0d15daa781d5eb4380a657ad34c5) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195910#comment-16195910 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-1.5 #86 (See [https://builds.apache.org/job/HBase-1.5/86/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 50ef066c89d57f17ba51b04ba248e8c8c9ff3d8d) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195909#comment-16195909 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-1.4 #942 (See [https://builds.apache.org/job/HBase-1.4/942/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev b6f14bd2e58ad302d8413173515ecbe5bdfa6e36) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195860#comment-16195860 ] Hudson commented on HBASE-18921: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #964 (See [https://builds.apache.org/job/HBase-1.2-IT/964/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 0205109c0d15daa781d5eb4380a657ad34c5) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195859#comment-16195859 ] Hudson commented on HBASE-18921: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #224 (See [https://builds.apache.org/job/HBase-1.3-IT/224/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 15288c055896eabc804d8a4b45e869ec1ce70b1f) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195855#comment-16195855 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #309 (See [https://builds.apache.org/job/HBase-1.3-JDK8/309/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 15288c055896eabc804d8a4b45e869ec1ce70b1f) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195854#comment-16195854 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #231 (See [https://builds.apache.org/job/HBase-1.2-JDK7/231/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 0205109c0d15daa781d5eb4380a657ad34c5) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195853#comment-16195853 ] Hudson commented on HBASE-18921: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #296 (See [https://builds.apache.org/job/HBase-1.3-JDK7/296/]) HBASE-18921 Fix Result.current ArrayIndexOutOfBoundsException (chia7712: rev 15288c055896eabc804d8a4b45e869ec1ce70b1f) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestResult.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194954#comment-16194954 ] Chia-Ping Tsai commented on HBASE-18921: Will commit it tomorrow. > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194847#comment-16194847 ] Ted Yu commented on HBASE-18921: lgtm > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, > HBASE-18921.master.002.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194461#comment-16194461
]
Chia-Ping Tsai commented on HBASE-18921:
{{TestResult}} extends the {{TestCase}}, hence the {{Test}} annotation is not
necessary. Pardon. I didn’t notice the inheritance.
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch,
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194278#comment-16194278
]
Hadoop QA commented on HBASE-18921:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
18s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
52s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
31s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 96m
28s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}161m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18921 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890652/HBASE-18921.master.002.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 96be184ab486 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / bafbade |
| Default Java | 1.8.0_144 |
|
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194156#comment-16194156
]
Maytee Chinavanichkit commented on HBASE-18921:
---
[~chia7712] Would you know why other test in this file do not have the
{{@Test}}?
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch,
> HBASE-18921.master.002.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194078#comment-16194078
]
Chia-Ping Tsai commented on HBASE-18921:
{code}
+ public void testCurrentOnEmptyCell() throws IOException {
+Result r = Result.create(new Cell[0]);
+assertFalse(r.advance());
+assertNull(r.current());
+ }
+
+ public void testAdvanceTwiceOnEmptyCell() throws IOException {
+Result r = Result.create(new Cell[0]);
+assertFalse(r.advance());
+try {
+ r.advance();
+ fail("NoSuchElementException should have been thrown!");
+} catch (NoSuchElementException ex) {
+ LOG.debug("As expected: " + ex.getMessage());
+}
+ }
{code}
Please add the {{@Test}} annotation.
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18921.master.001.patch, master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190788#comment-16190788
]
Hadoop QA commented on HBASE-18921:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
1s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
40m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}105m
32s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18921 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890271/HBASE-18921.master.001.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7b486db48f6e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 16d483f |
| Default Java | 1.8.0_144 |
|
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190639#comment-16190639 ] Maytee Chinavanichkit commented on HBASE-18921: --- [~chia7712] Yes you are right! I updated the patch with the correct patch name formatting. [~yuzhih...@gmail.com] I also removed the unneeded else. > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18921.master.001.patch, master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190075#comment-16190075
]
Chia-Ping Tsai commented on HBASE-18921:
{code}
|| cellScannerIndex == cells.length)
{code}
Is it better to use {{>=}}? Otherwise, the ArrayIndexOutOfBoundsException may
happen again.
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189950#comment-16189950
]
Hadoop QA commented on HBASE-18921:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
59s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
38s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m
41s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}156m 2s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18921 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890125/master.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2aa5104e8d43 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 5026539 |
| Default Java | 1.8.0_144 |
| findbugs |
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189891#comment-16189891
]
Ted Yu commented on HBASE-18921:
{code}
900 } else if (cellScannerIndex == this.cells.length) {
901 return false;
{code}
Within each if block, there is return statement. So the 'else' keyword can be
omitted.
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Assignee: Maytee Chinavanichkit
>Priority: Minor
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189755#comment-16189755 ] Chia-Ping Tsai commented on HBASE-18921: HBase project has the [rule|http://hbase.apache.org/book.html#submitting.patches] about how to name the patch. FYI > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Assignee: Maytee Chinavanichkit >Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189750#comment-16189750
]
Chia-Ping Tsai commented on HBASE-18921:
Please click {{Submit Patch}} to trigger the QA. :)
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Priority: Minor
> Attachments: master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[ https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189375#comment-16189375 ] Chia-Ping Tsai commented on HBASE-18921: bq. advance() call should handle the exceptional cases. For example, calling advance() after it has already returned false should throw NoSuchElementException. Nice suggestion. +1. > Result.current() throws ArrayIndexOutOfBoundsException after calling advance() > -- > > Key: HBASE-18921 > URL: https://issues.apache.org/jira/browse/HBASE-18921 > Project: HBase > Issue Type: Bug >Reporter: Maytee Chinavanichkit >Priority: Minor > Attachments: master.patch > > > On a Result object, if current() method is called after advance() returns > false, this throws an ArrayIndexOutOfBoundsException. The expectation here is > that it should return a null value. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189372#comment-16189372
]
Maytee Chinavanichkit commented on HBASE-18921:
---
We can certainly do that. However what struck me as odd was that {{current()}}
method throws an exception. IMHO {{current()}} is like a {{get}} call and
should simply return the value under the cursor or null and should never throw
exceptions. Instead, the {{advance()}} call should handle the exceptional
cases. For example, calling {{advance()}} after it has already returned false
should throw {{NoSuchElementException}}.
WDYT?
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Priority: Minor
> Attachments: master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18921) Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
[
https://issues.apache.org/jira/browse/HBASE-18921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187734#comment-16187734
]
Chia-Ping Tsai commented on HBASE-18921:
We don't have defined what should happen if the {{Result}} has no more
elements. I prefer throwing the {{NoSuchElementException}} rather than {{null}}
or other exceptions. That will be more readable.
> Result.current() throws ArrayIndexOutOfBoundsException after calling advance()
> --
>
> Key: HBASE-18921
> URL: https://issues.apache.org/jira/browse/HBASE-18921
> Project: HBase
> Issue Type: Bug
>Reporter: Maytee Chinavanichkit
>Priority: Minor
> Attachments: master.patch
>
>
> On a Result object, if current() method is called after advance() returns
> false, this throws an ArrayIndexOutOfBoundsException. The expectation here is
> that it should return a null value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
