[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[
https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501795#comment-16501795
]
Hudson commented on HBASE-18948:
Results for branch master
[build #356 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/356/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/356//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/356//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/356//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> HBase tags are server side only.
>
>
> Key: HBASE-18948
> URL: https://issues.apache.org/jira/browse/HBASE-18948
> Project: HBase
> Issue Type: Improvement
> Components: API, documentation
>Reporter: Thiriguna Bharat Rao
>Assignee: Thiriguna Bharat Rao
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18948.patch, HBASE-18948_v1.patch
>
>
> HBase tags are server side only. In the Apache HBase documentation, in
> section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I
> am going to add a sentence to state explicitly that "Tags are not available
> for get/set from client operations including coprocessors".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500349#comment-16500349 ] Thiriguna Bharat Rao commented on HBASE-18948: -- [~elserj]: Many thanks for making the required changes and pushing it. Appreciate it highly. [~chia7712] Thank you. Best, Triguna > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: API, documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch, HBASE-18948_v1.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500331#comment-16500331 ] Chia-Ping Tsai commented on HBASE-18948: +1 > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: API, documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch, HBASE-18948_v1.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500320#comment-16500320 ] Josh Elser commented on HBASE-18948: Nope, all good Triguna. Sorry for the delay, fell off my radar. +1 committing. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: API, documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch, HBASE-18948_v1.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499829#comment-16499829 ] Thiriguna Bharat Rao commented on HBASE-18948: -- Hi, Any feedback or comments on this patch? Please advise. Best, Triguna > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: API, documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch, HBASE-18948_v1.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[
https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491003#comment-16491003
]
Hadoop QA commented on HBASE-18948:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
6s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 3m
59s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 54s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-18948 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12925168/HBASE-18948_v1.patch |
| Optional Tests | asflicense refguide |
| uname | Linux e0b53f3d3dd1 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / b1089e8310 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/12964/artifact/patchprocess/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/12964/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 93 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12964/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> HBase tags are server side only.
>
>
> Key: HBASE-18948
> URL: https://issues.apache.org/jira/browse/HBASE-18948
> Project: HBase
> Issue Type: Improvement
> Components: API, documentation
>Reporter: Thiriguna Bharat Rao
>Assignee: Thiriguna Bharat Rao
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18948.patch, HBASE-18948_v1.patch
>
>
> HBase tags are server side only. In the Apache HBase documentation, in
> section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I
> am going to add a sentence to state explicitly that "Tags are not available
> for get/set from client operations including coprocessors".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490978#comment-16490978 ] Thiriguna Bharat Rao commented on HBASE-18948: -- Hi [~elserj] Many thanks for the prompt feedback and review. I made the required changes in the Tag implementation details and added the following note in security.adoc: Coprocessors that run server-side on RegionServers can perform get and set operations on cell Tags. Tags are striped out at the RPC layer before the read response is sent back, so clients do not see these tags. Generated HBASE-18948_v1.patch which erased the changes that were made last year for HBASE-18948.patch, so reviewers will now a single commit with the new change. Appreciate your support and time. Best, Triguna > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: API, documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479398#comment-16479398 ] Josh Elser commented on HBASE-18948: [~trigunab], your patch still needs some work. Please see the above discussion around how tags *are* available for Coprocessors. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: API, documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[
https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477981#comment-16477981
]
Hadoop QA commented on HBASE-18948:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
30s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 3m
59s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-18948 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890536/HBASE-18948.patch |
| Optional Tests | asflicense refguide |
| uname | Linux 9e0f2f2c5cf5 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 6148b4785d |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/12857/artifact/patchprocess/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/12857/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 93 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/12857/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> HBase tags are server side only.
>
>
> Key: HBASE-18948
> URL: https://issues.apache.org/jira/browse/HBASE-18948
> Project: HBase
> Issue Type: Improvement
> Components: API, documentation
>Reporter: Thiriguna Bharat Rao
>Assignee: Thiriguna Bharat Rao
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-18948.patch
>
>
> HBase tags are server side only. In the Apache HBase documentation, in
> section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I
> am going to add a sentence to state explicitly that "Tags are not available
> for get/set from client operations including coprocessors".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194210#comment-16194210 ] Anoop Sam John commented on HBASE-18948: And write side CP hooks can even add Tags to Cells. I believe this is what Timeline Server feature is doing. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194209#comment-16194209 ] Anoop Sam John commented on HBASE-18948: bq.We allow clients to build raw cell serializations, potentially including tags, and submit them. I can't say if they are stripped out or not. It is stripped out now. And ya while sending back read response also, at the RPC layer the tags are getting stripped off ( by Codec) And ya replication uses special Codec so as to pass Tags. And ReplicationEP will be getting this used I believe. And YES. When the read cells are passed through the CP hooks or a CP code is doing a read, the Tags will be visible in the Cells. Only at the RPC layer the stripping happens. I agree that this is a temp solution for not exposing the security related tags to client. But that is not full fledged. Planned to do cleanup and completion of this for 2.0 but seems wont happen as am in to some thing else now. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193852#comment-16193852 ] Josh Elser commented on HBASE-18948: Yes... the patch needs fixing. I assumed that was clear from the discussion. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193837#comment-16193837 ] Vrushali C commented on HBASE-18948: Hmm I did read the discussion. I understood it as security coprocessors will strip out tags set by clients. But the proposed patch says, coprocessor code can not get/set tags, which is incorrect. Coprocessors run on RS as part of the server and are allowed to get/set cell Tags. They are stripped off before sending the cell back to client. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193800#comment-16193800 ] Josh Elser commented on HBASE-18948: bq. But coprocessors can currently access and set cell Tags. So then the proposed patch is not accurate. bq. Edit: I know the security coprocessors defend against the possibility of user submission of faked security cell tag by stripping them out. Or, I remember writing that code. Again the current state of the code should be reviewed. Please see the discussion already on this issue that recommended that the code must be reviewed to ensure that all CP paths are accurate. There is ambiguity around this area. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193764#comment-16193764 ] Josh Elser commented on HBASE-18948: [~vrushalic], no. This is trying to update the documentation to accurately reflect the current state of what is and is not possible WRT tags. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193789#comment-16193789 ] Vrushali C commented on HBASE-18948: But coprocessors can currently access and set cell Tags. So then the proposed patch is not accurate. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193758#comment-16193758 ] Vrushali C commented on HBASE-18948: IIUC coprocessors will not be able to get/set Tags in HBase 3.0, is that what is being said here? > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[
https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193519#comment-16193519
]
Hadoop QA commented on HBASE-18948:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 10m
23s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
0s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}152m
32s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}214m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18948 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12890536/HBASE-18948.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit |
| uname | Linux ddf1895e66fd 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bafbade |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8954/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8954/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> HBase tags are server side only.
>
>
> Key: HBASE-18948
> URL: https://issues.apache.org/jira/browse/HBASE-18948
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Thiriguna Bharat Rao
>Assignee: Thiriguna Bharat Rao
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-18948.patch
>
>
> HBase tags are server side only. In the Apache HBase documentation, in
> section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I
> am going to add a sentence to state explicitly that "Tags are not available
> for get/set from client operations including coprocessors".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193466#comment-16193466 ] Josh Elser commented on HBASE-18948: bq. We should review RPC handling. We allow clients to build raw cell serializations, potentially including tags, and submit them. I can't say if they are stripped out or not. It will take a code review to be certain (hint hint) Point taken ;). Definitely need a server-side audit to understand this aspect better. bq. It is definitely true tags are stripped out when sending RPC responses Ok, this is a good clarification (that I missed). The improvement Triguna was trying to make was specifically around clients not seeing the tags in an RPC response (I believe this stemmed from some user-confusion that we've had to explain a few times). bq. the replication client, which uses a special codec that includes tags, so all cell state including tags makes it to the target cluster Ah, of course. This is a good clarification (all replication endpoints, custom or not, _do_ receive cell tags). > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193368#comment-16193368 ] Andrew Purtell commented on HBASE-18948: I think this requires more than a doc update. We should review RPC handling. We allow clients to build raw cell serializations, potentially including tags, and submit them. I can't say if they are stripped out or not. It will take a code review to be certain (hint hint). It is definitely true tags are stripped out when sending RPC responses, except for the replication client, which uses a special codec that includes tags, so all cell state including tags makes it to the target cluster. So we also need a point of clarification that custom replication endpoints (like Lily's indexer) would receive tags. There is a related JIRA about security enhancements for replication that would be good to take up. > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193153#comment-16193153 ] Thiriguna Bharat Rao commented on HBASE-18948: -- Many thanks [~elserj], for doing the needful. Appreciate it. Best, Triguna > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Assignee: Thiriguna Bharat Rao >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18948) HBase tags are server side only.
[ https://issues.apache.org/jira/browse/HBASE-18948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193085#comment-16193085 ] Josh Elser commented on HBASE-18948: Thanks for the patch, [~trigunab]! I'll add you as a contributor and assign this to you shortly. [~apurtell], given my understanding this looks fine. Any request on edits from you? > HBase tags are server side only. > > > Key: HBASE-18948 > URL: https://issues.apache.org/jira/browse/HBASE-18948 > Project: HBase > Issue Type: Improvement > Components: documentation >Reporter: Thiriguna Bharat Rao >Priority: Minor > Attachments: HBASE-18948.patch > > > HBase tags are server side only. In the Apache HBase documentation, in > section 62.1.1 http://hbase.apache.org/book.html#_implementation_details , I > am going to add a sentence to state explicitly that "Tags are not available > for get/set from client operations including coprocessors". -- This message was sent by Atlassian JIRA (v6.4.14#64029)
