[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199627#comment-16199627
]
Hudson commented on HBASE-18981:
SUCCESS: Integrated in Jenkins build HBase-2.0 #663 (See
[https://builds.apache.org/job/HBase-2.0/663/])
HBASE-18981 Address issues found by error-prone in hbase-client (mdrob: rev
2e368cf46159a7ea0dfaac7784f625c9421aebb6)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
> Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-client: Compilation failure
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
> [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a
> trivial patch to error on the missing case, but want somebody with more
> contextual knowledge to look at it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199606#comment-16199606
]
Hudson commented on HBASE-18981:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3864 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3864/])
HBASE-18981 Address issues found by error-prone in hbase-client (mdrob: rev
690ff38f54d0de588465cda410ac4496cd9a3369)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
> Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
>Priority: Trivial
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-client: Compilation failure
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
> [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a
> trivial patch to error on the missing case, but want somebody with more
> contextual knowledge to look at it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199302#comment-16199302
]
Hadoop QA commented on HBASE-18981:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
40m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
53s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 75m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18981 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12891327/HBASE-18981.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d8c906b9b3e6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 73b6bd0 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9029/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9029/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was
[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199251#comment-16199251
]
Josh Elser commented on HBASE-18981:
LGTM
> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
> Issue Type: Sub-task
>Reporter: Mike Drob
>Assignee: Mike Drob
> Fix For: 3.0.0, 2.0.0-beta-1
>
> Attachments: HBASE-18981.patch
>
>
> I thought this was something that we would already catch in findbugs, but
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-client: Compilation failure
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
> [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a
> trivial patch to error on the missing case, but want somebody with more
> contextual knowledge to look at it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18981) Address issues found by error-prone in hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199165#comment-16199165
]
Josh Elser commented on HBASE-18981:
Curious how this one slipped by. The GLOBAL_BYPASS case was (still is, to a
lesser degree) treated differently than the other two. My hunch would be that
it's not a bug WRT how users get/set quotas (somewhere, there's a condition
which avoids calling this method if it's just a GlobalBypass), but I think the
trivial fix is sufficient. Your careful eye is appreciated!
> Address issues found by error-prone in hbase-client
> ---
>
> Key: HBASE-18981
> URL: https://issues.apache.org/jira/browse/HBASE-18981
> Project: HBase
> Issue Type: Sub-task
>Reporter: Mike Drob
> Fix For: 2.0.0-beta-1
>
>
> I thought this was something that we would already catch in findbugs, but
> maybe not?
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project hbase-client: Compilation failure
> [ERROR]
> /Users/mdrob/IdeaProjects/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:[2476,5]
> [MissingCasesInEnumSwitch] Non-exhaustive switch; either add a default or
> handle the remaining cases: GLOBAL_BYPASS
> [ERROR] (see http://errorprone.info/bugpattern/MissingCasesInEnumSwitch)
> {noformat}
> cc: [~elserj], this looks like it is part of quota code. I'm happy to add a
> trivial patch to error on the missing case, but want somebody with more
> contextual knowledge to look at it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
