[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275549#comment-16275549
]
Chia-Ping Tsai commented on HBASE-19298:
Thanks [~stack] Let me fulfill my job. :)
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275532#comment-16275532
]
stack commented on HBASE-19298:
---
I can do this one if you'd like [~chia7712]. Just say... Thanks.
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260467#comment-16260467
]
Chia-Ping Tsai commented on HBASE-19298:
bq. On the patch, whats up w/ the ExtendedCellScanner. Why we need it?
The interface used in server side should differ from the interface exposed
publicly. Otherwise, the tragedy, which is like HBASE-19092, will strike again
in the future. It is unrelated to this issue, at any rate. I will submit a
patch which just makes {{CellScanner}} and {{CellScannable}} public. Thanks for
the feedback. [~stack]
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260301#comment-16260301
]
stack commented on HBASE-19298:
---
bq. Is it the consensus in our community? If so, I'm fine to close this issue
as Won't Fix.
[~chia7712] Our Sean is gone till Feb FYI as of today (For the best of reasons
-- smile).
I'd be good w/ CellScanner being public. It is a dumb interface that is
pervasive; e.g. Result implements it.
On the patch, whats up w/ the ExtendedCellScanner. Why we need it?
Thanks.
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258316#comment-16258316
]
Chia-Ping Tsai commented on HBASE-19298:
bq. There are plenty of places where our IA.Public API uses or returns
non-IA.Public members that folks are advised to treat as a black box.
Is it the consensus in our community? If so, I'm fine to close this issue as
{{Won't Fix}}. :)
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258217#comment-16258217
]
Hadoop QA commented on HBASE-19298:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} hbase-common: The patch generated 0 new + 22
unchanged - 2 fixed = 22 total (was 24) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} The patch hbase-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} hbase-server: The patch generated 0 new + 10
unchanged - 1 fixed = 10 total (was 11) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
57m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
14s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
4s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}127m
36s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
52s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}221m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19298 |
| JIRA Patch URL |
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258154#comment-16258154
]
Chia-Ping Tsai commented on HBASE-19298:
bq. what's special about CellScanner that we should make it public?
The {{CellScanner}} is nothing special I think. Our doc inspires me to file
this issue.
{code}
If you are relying on a particular interface that is marked Private, you should
open a jira to propose changing the interface to be Public or LimitedPrivate,
or an interface exposed for this purpose.
{code}
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19298) CellScanner should be declared as IA.Public
[
https://issues.apache.org/jira/browse/HBASE-19298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258141#comment-16258141
]
Sean Busbey commented on HBASE-19298:
-
There are plenty of places where our IA.Public API uses or returns
non-IA.Public members that folks are advised to treat as a black box. what's
special about CellScanner that we should make it public?
> CellScanner should be declared as IA.Public
> ---
>
> Key: HBASE-19298
> URL: https://issues.apache.org/jira/browse/HBASE-19298
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19298.v0.patch
>
>
> User can create the {{CellScanner}} via IA.Public {{CellUtil}}, hence
> {{CellScanner}} should be IA.Public. However, the {{CellScanner}} is used in
> the server code base so making {{CellScanner}} IA.Public may flaw our HBASE
> in the future. In my opinion, we should introduce the {{ExtendedCellScanner}}
> to replace the {{CellScanner}} for server code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
