[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259950#comment-16259950 ] Duo Zhang commented on HBASE-19299: --- Thanks [~stack]. > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259939#comment-16259939 ] Hudson commented on HBASE-19299: FAILURE: Integrated in Jenkins build HBase-2.0 #886 (See [https://builds.apache.org/job/HBase-2.0/886/]) HBASE-19299 Assert only one Connection is constructed when calculating (stack: rev eb17a2f285fab68cc722065336af1e7f65a02eb2) * (add) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMultiTableInputFormatBase.java > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259483#comment-16259483 ] stack commented on HBASE-19299: --- [~Apache9] Done sir. Pushed to branch-2 too. > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258878#comment-16258878 ] Duo Zhang commented on HBASE-19299: --- But no harm to add it to branch-2? :) > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258839#comment-16258839 ] stack commented on HBASE-19299: --- bq. Why master only? Its trivial test addition only. Didn't think anyone else would care. > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258405#comment-16258405 ] Duo Zhang commented on HBASE-19299: --- Why master only? > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[ https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258344#comment-16258344 ] Hudson commented on HBASE-19299: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4079 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4079/]) HBASE-19299 Assert only one Connection is constructed when calculating (stack: rev b4fbf5fe18bc9247106f674580666096fd34d3fa) * (add) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestMultiTableInputFormatBase.java > Assert only one Connection is constructed when calculating splits in a > MultiTableInputFormat > > > Key: HBASE-19299 > URL: https://issues.apache.org/jira/browse/HBASE-19299 > Project: HBase > Issue Type: Test > Components: test >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 3.0.0 > > Attachments: > 0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch > > > Small test that verifies only one Connection made when calculating splits. We > used to put up one per Table until recently and before that, a Connection per > table per split which put a heavy load on hbase;meta. Here is a test to > ensure we don't go back to the bad-old-days. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19299) Assert only one Connection is constructed when calculating splits in a MultiTableInputFormat
[
https://issues.apache.org/jira/browse/HBASE-19299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258286#comment-16258286
]
Hadoop QA commented on HBASE-19299:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
10s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} hbase-mapreduce: The patch generated 9 new + 0
unchanged - 0 fixed = 9 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
50s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 4s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m
47s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19299 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12898368/0002-HBASE-19299-Assert-only-one-Connection-is-constructe.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b63b0989cfc5 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 777b653b45 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/9912/artifact/patchprocess/diff-checkstyle-hbase-mapreduce.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9912/testReport/ |
| modules | C: hbase-mapreduce U: hbase-mapreduce |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9912/console |
| Powered by | Apache Yetus 0.6.0
