[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280114#comment-16280114 ] Hudson commented on HBASE-19410: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4178 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4178/]) HBASE-19410 Move zookeeper related UTs to hbase-zookeeper and mark them (zhangduo: rev 75cdbb57001ac6195b10381c7032ba04d55b4577) * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java * (edit) hbase-spark/pom.xml * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestHQuorumPeer.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKAsyncRegistry.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperACL.java * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMulti.java * (edit) pom.xml * (edit) hbase-annotations/src/test/java/org/apache/hadoop/hbase/testclassification/ZKTests.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/Waiter.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestRecoverableZooKeeper.java * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMainServer.java * (edit) hbase-server/pom.xml * (edit) hbase-zookeeper/pom.xml * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestRecoverableZooKeeper.java * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKNodeTracker.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKNodeTracker.java * (edit) hbase-mapreduce/pom.xml * (edit) hbase-testing-util/pom.xml * (edit) hbase-endpoint/pom.xml * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMulti.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKMainServer.java * (add) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/HBaseZKTestingUtility.java * (edit) hbase-zookeeper/src/test/java/org/apache/hadoop/hbase/zookeeper/TestReadOnlyZKClient.java > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279765#comment-16279765 ] Duo Zhang commented on HBASE-19410: --- Yes. Will commit shortly. Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279662#comment-16279662 ] stack commented on HBASE-19410: --- Open new issue to talk testing revamp or just to dump ideas in (all above are good). Meantime, seems like this is good to go? > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279563#comment-16279563 ] Duo Zhang commented on HBASE-19410: --- One more thing, MiniHBaseCluster is marked as IA.Public but its parent class HBaseCluster is marked as IA.Private... > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279562#comment-16279562 ] Duo Zhang commented on HBASE-19410: --- For us it is testing code but for users it is a library... That's why I say that we should only expose an interface with minimum functions. I think for most CRUD users, maybe they even do not need to start a mini cluster, a mocked client api which holds all data with an in memory map or a local storage is enough... Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279545#comment-16279545 ] Appy commented on HBASE-19410: -- If that's more popular choice, am fine with it. Personally i'd would prefer looser guarantees for test-code since 1) it's test code, and 2) that'll make development easy. :) Also, LimitedPrivate just feels like pita every time i see it (extra hierarchies, gotchas, etc), . :) > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279532#comment-16279532 ] Duo Zhang commented on HBASE-19410: --- I think for most users they just want to start a mini hbase cluster and do read write, so I do not think it is worth to introduce a new compatible matrix? For phoenix and other projects which may reach the internal of HBase, I think we can reuse the IA.LimitedPrivate annotation? Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279524#comment-16279524 ] Appy commented on HBASE-19410: -- What about this suggestion? bq. Maybe we can add another line to compatibility matrix: Testing API compat - major No, minor No, patch Yes. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279499#comment-16279499 ] Duo Zhang commented on HBASE-19410: --- Oh just comment on RB, let me also put the comment here. HTU is not well designed to be an IA.Public, it should be an interface, or at least, we should have an IA.Public base class which only have the stuffs we want to expose to users, and in HBase we will use a sub class of it which have more functions. So let's file a new jira to track this? But to be honest, I do not think we will do it before the final 2.0.0 release... Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279492#comment-16279492 ] stack commented on HBASE-19410: --- Refactor of test util is about due. HBTU was v2 as [~Apache9] says above but it has become a dumping ground. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279484#comment-16279484 ] Appy commented on HBASE-19410: -- (probably better place for discussion because of wider visibility than RB) bq. Appy Replied on RB, changing inheritence to composition can not be done in one circle since HTU is IA.Public, and I do not think it is necessary to spend too many times to polish an existing testing util. Just introduce a new one, as the composition change on HTU will finally make you change lots of code, no difference from a new testing util. New testing tool will be lot of work for which we might not have enough time (beta 1 is in <20 days). Also, creating new one every time we might want to improve our testing framework might be a lot. Also, going over ref guide, which bucket does testing classes falling into? (http://hbase.apache.org/book.html#hbase.versioning.post10) Are they client API or server API? Maybe we can add another line to the matrix: Testing API compat - major No, minor No, patch Yes. Alternate suggestion (less preferred, above one is more general approach): Mark HBTU with IS.Evolving so we can break compat between minor versions. Either way, don't wait your patch on this thing. If other comments in RB are addressed, get it in. This can be done in a separate jira. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279301#comment-16279301 ] Duo Zhang commented on HBASE-19410: --- [~appy] Replied on RB, changing inheritence to composition can not be done in one circle since HTU is IA.Public, and I do not think it is necessary to spend too many times to polish an existing testing util. Just introduce a new one, as the composition change on HTU will finally make you change lots of code, no difference from a new testing util. Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279116#comment-16279116 ] Appy commented on HBASE-19410: -- Great refactor!! Few comments up on RB. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278942#comment-16278942 ] stack commented on HBASE-19410: --- [~Apache9] Our [~mdrob] is otherwise occupied next few days. [~appy] will probably be along soon I skimmed the patch and it looks great. Lovely clean-up. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278350#comment-16278350 ] Duo Zhang commented on HBASE-19410: --- Any concerns? Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[
https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278218#comment-16278218
]
Hadoop QA commented on HBASE-19410:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 20 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 9m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 17m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 11m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch hbase-annotations passed checkstyle
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
22s{color} | {color:red} hbase-common: The patch generated 1 new + 17 unchanged
- 1 fixed = 18 total (was 18) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch hbase-zookeeper passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} hbase-server: The patch generated 0 new + 266
unchanged - 36 fixed = 266 total (was 302) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-testing-util passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-endpoint passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch hbase-spark passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
21s{color} | {color:red} root: The patch generated 1 new + 283 unchanged - 37
fixed = 284 total (was 320) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
9s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
53m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277977#comment-16277977 ] Duo Zhang commented on HBASE-19410: --- Ping [~mdrob], our zk expert. And also [~appy], this is follow-on issue on your zk stuffs separation. Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410-v2.patch, > HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276717#comment-16276717 ] Peter Somogyi commented on HBASE-19410: --- I like the change [~Apache9]! I put some comments on ReviewBoard. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[
https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276276#comment-16276276
]
Chia-Ping Tsai commented on HBASE-19410:
bq. ZKTests should be used for tests which test the general logic on zk. For
example, ZKWatcher, and RecoverableZooKeeper.
Thanks for the explanation. Would you please add the explanation to the
{{ZKTests}} in order to easy later to read and understand the {{ZKTests}}?
> Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
> --
>
> Key: HBASE-19410
> URL: https://issues.apache.org/jira/browse/HBASE-19410
> Project: HBase
> Issue Type: Task
> Components: test, Zookeeper
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19410-v1.patch, HBASE-19410.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276275#comment-16276275 ] Duo Zhang commented on HBASE-19410: --- IMO, ZKTests should be used for tests which test the general logic on zk. For example, ZKWatcher, and RecoverableZooKeeper. The tests listed here are mainly used to test a specific logic wihch is implemented on top of zk, so I do not think they should be declared as ZKTests. And also, maybe we should not declare TestZKAsyncRegistry as ZKTests either. Thanks. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276269#comment-16276269 ] Duo Zhang commented on HBASE-19410: --- Let me check these tests. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410-v1.patch, HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[
https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276226#comment-16276226
]
Chia-Ping Tsai commented on HBASE-19410:
beautiful refactor!
What kind of test should be denoted with {{ZKTests}}? It seems that tests which
need only the mini zookeeper should be in {{ZKTests}}? If so, we can add the
{{ZKTests}} annotation to the following tests.
# TestZKProcedureControllers
# TestTableCFsUpdater
# TestReplicationStateZKImpl
# TestSplitLogWorker
# TestMetaTableAccessorNoCluster
# TestMetaTableLocator
# TestMasterNoClusterTestActiveMasterManager
# TestZKProcedure
# TestZKProcedureControllers
# TestMasterAddressTracker
# TestSplitLogWorker
# TestReplicationStateZKImpl
# TestReplicationTableBase
# TestZKSecretWatcher
# TestZKSecretWatcherRefreshKeys
> Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
> --
>
> Key: HBASE-19410
> URL: https://issues.apache.org/jira/browse/HBASE-19410
> Project: HBase
> Issue Type: Task
> Components: test, Zookeeper
>Reporter: Duo Zhang
>Assignee: Duo Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19410-v1.patch, HBASE-19410.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[
https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276015#comment-16276015
]
Hadoop QA commented on HBASE-19410:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 16 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hbase-zookeeper passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} hbase-server: The patch generated 0 new + 266
unchanged - 36 fixed = 266 total (was 302) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-testing-util passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch hbase-endpoint passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch hbase-spark passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
24s{color} | {color:green} root: The patch generated 0 new + 266 unchanged - 36
fixed = 266 total (was 302) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
29s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}150m
0s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color}
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275914#comment-16275914 ] Duo Zhang commented on HBASE-19410: --- Only checkstyle issues. Great. Let me fix them and upload to RB. > Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests > -- > > Key: HBASE-19410 > URL: https://issues.apache.org/jira/browse/HBASE-19410 > Project: HBase > Issue Type: Task > Components: test, Zookeeper >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19410.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests
[
https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275884#comment-16275884
]
Hadoop QA commented on HBASE-19410:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 16 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} hbase-zookeeper: The patch generated 13 new + 0
unchanged - 0 fixed = 13 total (was 0) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} hbase-server: The patch generated 0 new + 269
unchanged - 33 fixed = 269 total (was 302) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} The patch hbase-mapreduce passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
8s{color} | {color:green} The patch hbase-testing-util passed checkstyle
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} The patch hbase-endpoint passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} The patch hbase-spark passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
20s{color} | {color:red} root: The patch generated 11 new + 271 unchanged - 31
fixed = 282 total (was 302) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}148m
38s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color
