[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281841#comment-16281841 ] Hudson commented on HBASE-19430: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4184 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4184/]) HBASE-19430 Remove the SettableTimestamp and SettableSequenceId (chia7712: rev d2b1578b735c1d3c42a9cfe9b9be36d9d6fbd7a5) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestIndividualBytesFieldCell.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/SettableSequenceId.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/SettableTimestamp.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ExtendedCell.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/IndividualBytesFieldCell.java > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch, > HBASE-19430.v1.patch, HBASE-19430.v1.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281217#comment-16281217 ] Chia-Ping Tsai commented on HBASE-19430: working at resolving the conflict for branch-2 > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch, > HBASE-19430.v1.patch, HBASE-19430.v1.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281184#comment-16281184 ] Chia-Ping Tsai commented on HBASE-19430: Will commit the patch with checkstyle fix > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch, > HBASE-19430.v1.patch, HBASE-19430.v1.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280533#comment-16280533
]
Hadoop QA commented on HBASE-19430:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
32s{color} | {color:red} hbase-common: The patch generated 2 new + 278
unchanged - 9 fixed = 280 total (was 287) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
58m 27s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
10s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 93m
11s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
2s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
54s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19430 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900869/HBASE-19430.v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8975cf0d0bd2 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / ebd8841e0e |
|
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280162#comment-16280162 ] Chia-Ping Tsai commented on HBASE-19430: All failed tests are related to HBASE-18112. Will come back after resolving the HBASE-18112 > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch, > HBASE-19430.v1.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280093#comment-16280093
]
Hadoop QA commented on HBASE-19430:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
37s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
27s{color} | {color:red} hbase-common: The patch generated 2 new + 278
unchanged - 9 fixed = 280 total (was 287) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 23s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
10s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}112m 59s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 22m
28s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}212m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.tool.TestLoadIncrementalHFiles |
| | hadoop.hbase.filter.TestFilterListOnMini |
| | hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19430 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900827/HBASE-19430.v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5eea5d927030
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280035#comment-16280035 ] Anoop Sam John commented on HBASE-19430: +1. Nice work. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch, > HBASE-19430.v1.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279778#comment-16279778
]
Chia-Ping Tsai commented on HBASE-19430:
{code:title=CellUtil.java}
@Deprecated
public static void setTimestamp(Cell cell, byte[] ts, int tsOffset) throws
IOException {
PrivateCellUtil.setTimestamp(cell, ts, tsOffset);
}
{code}
I didn't remove it as it is used in CellUtil. But it seems we can convert the
byte to long and then call the setTimestamp(long) instead. Will remove it in
next patch.
> Remove the SettableTimestamp and SettableSequenceId
> ---
>
> Key: HBASE-19430
> URL: https://issues.apache.org/jira/browse/HBASE-19430
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch
>
>
> They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP
> and denoted with deprecated. To my way of thinking, we should remove them
> before 2.0 release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279768#comment-16279768 ] ramkrishna.s.vasudevan commented on HBASE-19430: bq.void setTimestamp(byte[] ts, int tsOffset) throws IOException; Did a grep of this. I think every where we use we use it with offset = 0. So do we really need this version of the API? Rest LGTM. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279766#comment-16279766
]
Hadoop QA commented on HBASE-19430:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
25s{color} | {color:red} hbase-common: The patch generated 2 new + 160
unchanged - 8 fixed = 162 total (was 168) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
54m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
13s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}111m 45s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.tool.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.tool.TestLoadIncrementalHFiles |
| | hadoop.hbase.namespace.TestNamespaceAuditor |
| | hadoop.hbase.filter.TestFilterListOnMini |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19430 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900796/HBASE-19430.v0.test.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c120e87de4a8 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279674#comment-16279674 ] stack commented on HBASE-19430: --- Pardon me. Misread. Saw the deprecations. Thought they were yours. +1 from me but get [~anoop.hbase]/[~ram_krish] blessing. Go easy. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279652#comment-16279652
]
Chia-Ping Tsai commented on HBASE-19430:
bq. why remove the methods in CellUtil, the ones that do is isDelete*, etc.?
Pardon me. I don't catch you pointer. All changes in {{CellUtil}} is about
checkstyle warings (tab and whitespace). No methods are removed from
{{CellUtil}}.
> Remove the SettableTimestamp and SettableSequenceId
> ---
>
> Key: HBASE-19430
> URL: https://issues.apache.org/jira/browse/HBASE-19430
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch
>
>
> They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP
> and denoted with deprecated. To my way of thinking, we should remove them
> before 2.0 release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279645#comment-16279645 ] stack commented on HBASE-19430: --- Skimmed. Looks great (why remove the methods in CellUtil, the ones that do is isDelete*, etc.?). Get +1 from [~anoop.hbase] or [~ram_krish] > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19430.v0.patch, HBASE-19430.v0.test.patch > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279520#comment-16279520
]
Hadoop QA commented on HBASE-19430:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
19s{color} | {color:red} hbase-common: The patch generated 2 new + 160
unchanged - 8 fixed = 162 total (was 168) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
18s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
46m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
10s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 10s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19430 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12900777/HBASE-19430.v0.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 12545cfcda48 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ed60e4518d |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/10244/artifact/patchprocess/diff-checkstyle-hbase-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10244/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10244/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278046#comment-16278046 ] Chia-Ping Tsai commented on HBASE-19430: Thanks for all comment. Let me do the cleanup. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-beta-2 > > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[
https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278038#comment-16278038
]
ramkrishna.s.vasudevan commented on HBASE-19430:
The SettableTimestamp API
{code}
setTimestamp(byte[] ts, int tsOffset)
{code}
is probably not needed. And just add setSequncedId(long seqId) and
setTimeStamp(ts) to Extendedcell. And no longer these methods will be exposed
to CP since ExtendedCell is private. If at all CP needs to create a cell with
TS it has to go with the cell builder way.
> Remove the SettableTimestamp and SettableSequenceId
> ---
>
> Key: HBASE-19430
> URL: https://issues.apache.org/jira/browse/HBASE-19430
> Project: HBase
> Issue Type: Task
>Reporter: Chia-Ping Tsai
>
> They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP
> and denoted with deprecated. To my way of thinking, we should remove them
> before 2.0 release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278011#comment-16278011 ] stack commented on HBASE-19430: --- Wasn't it only server-side anyways? And CP. And we can make breaking changes on CPs for 2.0. I'd be +1 on removing them. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278001#comment-16278001 ] ramkrishna.s.vasudevan commented on HBASE-19430: I think this was added in branch-1 and so it should be deprecated in 2.0 and removed in 3.0 right? But not sure if any one is really using it since setting sequence ID (for eg) is not advisable. > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19430) Remove the SettableTimestamp and SettableSequenceId
[ https://issues.apache.org/jira/browse/HBASE-19430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277923#comment-16277923 ] Chia-Ping Tsai commented on HBASE-19430: ping [~anoop.hbase] [~ram_krish] > Remove the SettableTimestamp and SettableSequenceId > --- > > Key: HBASE-19430 > URL: https://issues.apache.org/jira/browse/HBASE-19430 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai > > They are introduced by HBASE-11777 and HBASE-12082. Both of them are IA.LP > and denoted with deprecated. To my way of thinking, we should remove them > before 2.0 release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
