[jira] [Commented] (HBASE-19464) Replace StringBuffer with StringBuilder for hbase-common
[
https://issues.apache.org/jira/browse/HBASE-19464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285356#comment-16285356
]
Hudson commented on HBASE-19464:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4202 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4202/])
HBASE-19464 Replace StringBuffer with StringBuilder for hbase-common (chia7712:
rev a0b0bcede0f4daf73b8a0795f0e88bceac368d8b)
* (edit)
hbase-common/src/main/java/org/apache/hadoop/hbase/CompoundConfiguration.java
* (edit)
hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
> Replace StringBuffer with StringBuilder for hbase-common
>
>
> Key: HBASE-19464
> URL: https://issues.apache.org/jira/browse/HBASE-19464
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19464.1.patch
>
>
> Replace {{StringBuffer}} with non-synchronized version {{StringBuilder}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19464) Replace StringBuffer with StringBuilder for hbase-common
[
https://issues.apache.org/jira/browse/HBASE-19464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285268#comment-16285268
]
Jan Hentschel commented on HBASE-19464:
---
+1 on the patch and suggestion from [~chia7712]
> Replace StringBuffer with StringBuilder for hbase-common
>
>
> Key: HBASE-19464
> URL: https://issues.apache.org/jira/browse/HBASE-19464
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19464.1.patch
>
>
> Replace {{StringBuffer}} with non-synchronized version {{StringBuilder}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19464) Replace StringBuffer with StringBuilder for hbase-common
[
https://issues.apache.org/jira/browse/HBASE-19464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285248#comment-16285248
]
Chia-Ping Tsai commented on HBASE-19464:
+1
> Replace StringBuffer with StringBuilder for hbase-common
>
>
> Key: HBASE-19464
> URL: https://issues.apache.org/jira/browse/HBASE-19464
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19464.1.patch
>
>
> Replace {{StringBuffer}} with non-synchronized version {{StringBuilder}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19464) Replace StringBuffer with StringBuilder for hbase-common
[
https://issues.apache.org/jira/browse/HBASE-19464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285247#comment-16285247
]
Chia-Ping Tsai commented on HBASE-19464:
What about filing a umbrella issue to contain all issues for each module? You
won't need to add the links for each issues.
> Replace StringBuffer with StringBuilder for hbase-common
>
>
> Key: HBASE-19464
> URL: https://issues.apache.org/jira/browse/HBASE-19464
> Project: HBase
> Issue Type: Improvement
> Components: hbase
>Affects Versions: 3.0.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19464.1.patch
>
>
> Replace {{StringBuffer}} with non-synchronized version {{StringBuilder}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19464) Replace StringBuffer with StringBuilder for hbase-common
[
https://issues.apache.org/jira/browse/HBASE-19464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284438#comment-16284438
]
Hadoop QA commented on HBASE-19464:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
8s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
53m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
13s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 72m 35s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19464 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12901317/HBASE-19464.1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2b9285b43b4b 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 07b193ae4f |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10309/testReport/ |
| modules | C: hbase-common U: hbase-common |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10309/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> Replace StringBuffer with StringBuilder for hbase-common
