[jira] [Commented] (HBASE-19530) New regions should always be added with state CLOSED

2017-12-16 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293712#comment-16293712
 ] 

Hudson commented on HBASE-19530:


FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4234 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/4234/])
HBASE-19530 New regions should always be added with state CLOSED (appy: rev 
a651ab93e3303eb5c60747c0a6bf6cc0122eee2f)
* (edit) 
hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java


> New regions should always be added with state CLOSED
> 
>
> Key: HBASE-19530
> URL: https://issues.apache.org/jira/browse/HBASE-19530
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19530.master.001.patch
>
>
> We shouldn't add regions with state null. In case of failures and recovery, 
> it's not possible to determine what did it mean and things become uncertain.
> All operations should add regions in a well defined state.
> For now, we'll set the default to CLOSED, since whatever ops are adding new 
> regions, they would anyways be enabling them explicitly if needed.
> fyi: [~stack]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19530) New regions should always be added with state CLOSED

2017-12-15 Thread Appy (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293663#comment-16293663
 ] 

Appy commented on HBASE-19530:
--

Btw, i predict that this patch might make "fix" TestTruncateTableProcedure.
I quote fix because, those failures are result of two assumption collectively 
resulting in a failure (region state = null --> assume OFFLINE, table state = 
null --> assume ENABLED).
This is break the first one of them and test might start passing.
But we still need to address the second one, and that will be done in 
HBASE-19529.

> New regions should always be added with state CLOSED
> 
>
> Key: HBASE-19530
> URL: https://issues.apache.org/jira/browse/HBASE-19530
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
> Attachments: HBASE-19530.master.001.patch
>
>
> We shouldn't add regions with state null. In case of failures and recovery, 
> it's not possible to determine what did it mean and things become uncertain.
> All operations should add regions in a well defined state.
> For now, we'll set the default to CLOSED, since whatever ops are adding new 
> regions, they would anyways be enabling them explicitly if needed.
> fyi: [~stack]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19530) New regions should always be added with state CLOSED

2017-12-15 Thread Appy (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293660#comment-16293660
 ] 

Appy commented on HBASE-19530:
--

Let's try it then! Pushing to master and branch-2.

> New regions should always be added with state CLOSED
> 
>
> Key: HBASE-19530
> URL: https://issues.apache.org/jira/browse/HBASE-19530
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
> Attachments: HBASE-19530.master.001.patch
>
>
> We shouldn't add regions with state null. In case of failures and recovery, 
> it's not possible to determine what did it mean and things become uncertain.
> All operations should add regions in a well defined state.
> For now, we'll set the default to CLOSED, since whatever ops are adding new 
> regions, they would anyways be enabling them explicitly if needed.
> fyi: [~stack]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19530) New regions should always be added with state CLOSED

2017-12-15 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293634#comment-16293634
 ] 

stack commented on HBASE-19530:
---

Patch looks great [~appy] +1

> New regions should always be added with state CLOSED
> 
>
> Key: HBASE-19530
> URL: https://issues.apache.org/jira/browse/HBASE-19530
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
> Attachments: HBASE-19530.master.001.patch
>
>
> We shouldn't add regions with state null. In case of failures and recovery, 
> it's not possible to determine what did it mean and things become uncertain.
> All operations should add regions in a well defined state.
> For now, we'll set the default to CLOSED, since whatever ops are adding new 
> regions, they would anyways be enabling them explicitly if needed.
> fyi: [~stack]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (HBASE-19530) New regions should always be added with state CLOSED

2017-12-15 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293572#comment-16293572
 ] 

Hadoop QA commented on HBASE-19530:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
10s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
35s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
19m 23s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
40s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 34s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19530 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12902476/HBASE-19530.master.001.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 6511d8b091c6 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / f9f869f60a |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/10486/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/10486/console |
| Powered by | Apache Yetus 0.6.0   http://yetus.apache.org |


This message was automatically generated.



> New regions should always be added with state CLOSED
>

[jira] [Commented] (HBASE-19530) New regions should always be added with state CLOSED

2017-12-15 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-19530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293436#comment-16293436
 ] 

stack commented on HBASE-19530:
---

Sounds good. Can we try it against hadoopqa and see what breaks?

> New regions should always be added with state CLOSED
> 
>
> Key: HBASE-19530
> URL: https://issues.apache.org/jira/browse/HBASE-19530
> Project: HBase
>  Issue Type: Bug
>Reporter: Appy
>
> We shouldn't add regions with state null. In case of failures and recovery, 
> it's not possible to determine what did it mean and things become uncertain.
> All operations should add regions in a well defined state.
> For now, we'll set the default to CLOSED, since whatever ops are adding new 
> regions, they would anyways be enabling them explicitly if needed.
> fyi: [~stack]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)