[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324807#comment-16324807
]
Hudson commented on HBASE-19775:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4390 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4390/])
HBASE-19775 hbase shell doesn't handle the exceptions that are wrapped (elserj:
rev 6bacb643bc66b994c386b7fd175664802047eef7)
* (edit) hbase-shell/src/main/ruby/shell/commands.rb
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19775-2-branch-2.patch, HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324180#comment-16324180
]
stack commented on HBASE-19775:
---
+1 for branch-2. Thanks for asking. Thanks for patch [~sergey.soldatov]
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19775-2-branch-2.patch, HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324168#comment-16324168
]
Josh Elser commented on HBASE-19775:
rubocop/rubylint stuff looks benign enough for us.
bq. As for the UT - honestly speaking I'm not sure how to check that
upper-level shell commands handled exception correctly.
I think that's fine. It looks like this happens when loading the next value
from ResultScanner errors out. I can't think of a good way to trigger this
either.
Looks like this UncheckedIOException came in via HBASE-17141 which is 2.0 only.
+1 from me. [~stack], may I land this on branch-2?
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19775-2-branch-2.patch, HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323290#comment-16323290
]
Hadoop QA commented on HBASE-19775:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 4 new + 24 unchanged - 4 fixed = 28
total (was 28) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
2s{color} | {color:red} The patch generated 1 new + 13 unchanged - 0 fixed = 14
total (was 13) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
44s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19775 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905771/HBASE-19775-2-branch-2.patch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux 9a184b0186c9 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4bd6ac3e10 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| rubocop | v0.52.1 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/11032/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/11032/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11032/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11032/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19775-2-branch-2.patch, HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323146#comment-16323146
]
Mike Drob commented on HBASE-19775:
---
I was able to manually verify the fix, so the logic is good.
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-2
>
> Attachments: HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323142#comment-16323142
]
Mike Drob commented on HBASE-19775:
---
yep, @josh is right about the oneliner style - it's much more ruby-esque.
{{cause = cause.getCause if cause.is_a? java.io.UncheckedIOException}}
can we add a test in {{hbase-shell/src/test/ruby/hbase/table_test.rb}}?
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323103#comment-16323103
]
Hadoop QA commented on HBASE-19775:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
58s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
19s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
3s{color} | {color:red} The patch generated 6 new + 24 unchanged - 4 fixed = 30
total (was 28) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
2s{color} | {color:red} The patch generated 1 new + 13 unchanged - 0 fixed = 14
total (was 13) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
32s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-19775 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12905749/HBASE-19775-branch-2.patch
|
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux b6f3c7287163 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4
19:09:19 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / 25e4bf8f37 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| rubocop | v0.52.1 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/11029/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/11029/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11029/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11029/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323072#comment-16323072
]
Josh Elser commented on HBASE-19775:
If it were me, I'd turn it into a oneline thing, but it's semantically
equivalent and maybe just my take :)
{code}
cause = cause.getCause() if cause.is_a? java.io.UncheckedIOException
{code}
We do have some Ruby tests in hbase-shell/src/test/ruby (invoked via some JUnit
tests e.g. hbase-shell/src/test/java/**/TestShell.java). What was the context
in which you saw this UncheckedIOException -- something we could reproduce
easily?
[~mdrob] has been in here recently too. Maybe he can drop a review :)
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19775) hbase shell doesn't handle the exceptions that are wrapped in java.io.UncheckedIOException
[
https://issues.apache.org/jira/browse/HBASE-19775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322982#comment-16322982
]
Sergey Soldatov commented on HBASE-19775:
-
FYI [~elserj], [~romil.choksi]
> hbase shell doesn't handle the exceptions that are wrapped in
> java.io.UncheckedIOException
> --
>
> Key: HBASE-19775
> URL: https://issues.apache.org/jira/browse/HBASE-19775
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.0.0-beta-1
>Reporter: Sergey Soldatov
>Assignee: Sergey Soldatov
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19775-branch-2.patch
>
>
> HBase shell doesn't have a notion of UncheckedIOException, so it may not
> handle it correctly. For an example, if we scan not existing table the error
> look weird:
> {noformat}
> hbase(main):001:0> scan 'a'
> ROW
> COLUMN+CELL
> ERROR: a
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
