[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363245#comment-16363245
]
Andrew Purtell commented on HBASE-19972:
[~Apache9] Sure, we can do a 1.4 release this month instead of waiting until
next month. Will start on it today, expect a vote by/for next week.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361684#comment-16361684
]
Hudson commented on HBASE-19972:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4574 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4574/])
HBASE-19972 Should rethrow the RetriesExhaustedWithDetailsException when
(stack: rev 00f88773239b96e256c585fae98d846e2b65b4a4)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361603#comment-16361603
]
Duo Zhang commented on HBASE-19972:
---
Thanks sir.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361265#comment-16361265
]
stack commented on HBASE-19972:
---
I pushed this addendum:
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
index fcce84fa1a..aa6c39cd53 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -317,8 +317,8 @@ public class TestReplicationSink {
Path dir = TEST_UTIL.getDataTestDirOnTestFS("testReplicateEntries");
Path familyDir = new Path(dir, Bytes.toString(FAM_NAME1));
int numRows = 10;
-
List p = new ArrayList<>(1);
+final String hfilePrefix = "hfile-";
// 1. Generate 25 hfile ranges
Random rng = new SecureRandom();
@@ -335,7 +335,7 @@ public class TestReplicationSink {
FileSystem fs = dir.getFileSystem(conf);
Iterator numbersItr = numberList.iterator();
for (int i = 0; i < 25; i++) {
- Path hfilePath = new Path(familyDir, "hfile_" + i);
+ Path hfilePath = new Path(familyDir, hfilePrefix + i);
HFileTestUtil.createHFile(conf, fs, hfilePath, FAM_NAME1, FAM_NAME1,
Bytes.toBytes(numbersItr.next()), Bytes.toBytes(numbersItr.next()),
numRows);
p.add(hfilePath);
@@ -370,10 +370,10 @@ public class TestReplicationSink {
.append(Bytes.toString(TABLE_NAME1.getName())).append(Path.SEPARATOR)
.append(Bytes.toString(loadDescriptor.getEncodedRegionName().toByteArray()))
.append(Path.SEPARATOR).append(Bytes.toString(FAM_NAME1)).append(Path.SEPARATOR)
- .append("hfile_" + i).toString();
+ .append(hfilePrefix + i).toString();
String dst = baseNamespaceDir + Path.SEPARATOR + pathToHfileFromNS;
-
- FileUtil.copy(fs, p.get(0), fs, new Path(dst), false, conf);
+ Path dstPath = new Path(dst);
+ FileUtil.copy(fs, p.get(0), fs, dstPath, false, conf);
}
entries.add(builder.build());
branch-2 and master have an extra test that writes hfiles in a form that is not
kosher... The new test this patch added was failing because it would try to
reenable table with the dirty bulk loaded files in it and fail. Fixed by making
the filenames in bulk load test fit expected hfile name... Really, the test
should cleanup after itself.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360742#comment-16360742
]
Hudson commented on HBASE-19972:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4571 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/4571/])
HBASE-19972 Should rethrow the RetriesExhaustedWithDetailsException when
(openinx: rev 629eaf8b74a443fb9f6c5c99b5b3174bc91514ba)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360544#comment-16360544
]
Duo Zhang commented on HBASE-19972:
---
Ping [~apurtell]. I think this is very critical bug which may cause
inconsistency if you use replication. Do you think we should make a 1.4.x
release ASAP? Maybe 1.4.1.1?
Thanks.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360373#comment-16360373
]
Zheng Hu commented on HBASE-19972:
--
Pushed to branch-1 & branch-1.4 & branch-2 & master , Thanks [~Apache9] for
reviewing.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360357#comment-16360357
]
Duo Zhang commented on HBASE-19972:
---
+1.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360332#comment-16360332
]
Zheng Hu commented on HBASE-19972:
--
All UT pass now, ping [~Apache9] & [~zghaobac] for review ...
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360309#comment-16360309
]
Hadoop QA commented on HBASE-19972:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
45s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 44s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}100m
1s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}141m 49s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19972 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12910131/HBASE-19972.v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d49f11863bfc 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 0593dda663 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11489/testReport/ |
| Max. process+thread count | 4852 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11489/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360220#comment-16360220
]
Zheng Hu commented on HBASE-19972:
--
Re-trigger Hadoop QA for master branch. The failed TestHBaseFsck ut in
branch-1 is unrelated to this patch, If master branch Hadoop QA is OK, I'll
commit this patch to master & branch-1 if no objection.
> Should rethrow the RetriesExhaustedWithDetailsException when failed to apply
> the batch in ReplicationSink
> --
>
> Key: HBASE-19972
> URL: https://issues.apache.org/jira/browse/HBASE-19972
> Project: HBase
> Issue Type: Bug
> Components: Replication
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2
>
> Attachments: HBASE-19972-branch-1.4.patch, HBASE-19972.v1.patch,
> HBASE-19972.v1.patch
>
>
> As [~Apache9] said in HBASE-12091.
> In ReplicationSink#batch，we swallow the RetriesExhaustedWithDetailsException
> except
> TableNotFoundException, actually, should rethrow the exception.
> {code:java}
> try {
> Connection connection = getConnection();
> table = connection.getTable(tableName);
> for (List rows : allRows) {
> table.batch(rows);
> }
> } catch (RetriesExhaustedWithDetailsException rewde) {
> for (Throwable ex : rewde.getCauses()) {
> if (ex instanceof TableNotFoundException) {
> throw new TableNotFoundException("'"+tableName+"'");
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19972) Should rethrow the RetriesExhaustedWithDetailsException when failed to apply the batch in ReplicationSink
[
https://issues.apache.org/jira/browse/HBASE-19972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359910#comment-16359910
]
Hadoop QA commented on HBASE-19972:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1.4 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
37s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
56s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
12s{color} | {color:green} branch-1.4 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} branch-1.4 passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1.4 passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
33s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 48s{color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1
2.5.2 2.6.5 2.7.4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed with JDK v1.8.0_162 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed with JDK v1.7.0_171 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 23s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}125m 50s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.util.TestHBaseFsck |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:74e3133 |
| JIRA Issue | HBASE-19972 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12910075/HBASE-19972-branch-1.4.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs
