[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362606#comment-16362606 ] Hudson commented on HBASE-19977: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4578 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4578/]) HBASE-19977 FileMmapEngine allocation of byte buffers should be (ramkrishna.s.vasudevan: rev 16f1f5b49424fcabc9b5c10882dab4f5bf7fa84b) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/FileMmapEngine.java > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19977.patch > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[
https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362123#comment-16362123
]
Hadoop QA commented on HBASE-19977:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
51s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
41s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 43s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}118m
0s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}156m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-19977 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12910355/HBASE-19977.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 2147af8d6f6a 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / b4622ffad7 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11504/testReport/ |
| Max. process+thread count | 5045 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11504/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> FileMmapEngine allocation of byte buffers should
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362085#comment-16362085 ] Ted Yu commented on HBASE-19977: +1 > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19977.patch > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361989#comment-16361989 ] Anoop Sam John commented on HBASE-19977: +1 > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19977.patch > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361977#comment-16361977 ] Duo Zhang commented on HBASE-19977: --- +1. > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19977.patch > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361962#comment-16361962 ] ramkrishna.s.vasudevan commented on HBASE-19977: Patch for branch-2 and master. The integer 'pos' is now AtomicInteger. > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19977.patch > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360542#comment-16360542 ] ramkrishna.s.vasudevan commented on HBASE-19977: Yes [~Apache9]. Using AtomicInteger will solve the problem. Will test this in a cluster. > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19977) FileMmapEngine allocation of byte buffers should be synchronized
[ https://issues.apache.org/jira/browse/HBASE-19977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360490#comment-16360490 ] Duo Zhang commented on HBASE-19977: --- An AtomicInteger is enough? > FileMmapEngine allocation of byte buffers should be synchronized > > > Key: HBASE-19977 > URL: https://issues.apache.org/jira/browse/HBASE-19977 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0-alpha-4 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Major > Fix For: 2.0.0-beta-2 > > > Recently we have been testing bucket cache with mmap mode. We found that > after the multi threading way of allocating the byte buffers for offheap > bucket cache, the creation of the mmapped byte buffers needs to be > synchronized for allocating the right sized mmapped buffers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
