[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381861#comment-16381861 ] Hudson commented on HBASE-20107: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4669 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4669/]) HBASE-20107 Add a test case for HBASE-14317 (Zephyr Guo) (tedyu: rev d7adc58e5203567b8083160d45f85f9986e272cd) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Assignee: Zephyr Guo >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-20107-v1.patch, HBASE-20107-v2.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > _TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup_. > We'll never see stuck in this test case, because > FailedSyncBeforeLogCloseException will break > _zigzagLatch.waitSafePoint(SyncFuture)_. Finally, > _zigzagLatch.releaseSafePoint()_ will be call, and _attainSafePoint(long)_ > get out stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[
https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381526#comment-16381526
]
Hadoop QA commented on HBASE-20107:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
48s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}116m
30s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}157m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20107 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12912516/HBASE-20107-v2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c41779c67152 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bdedcc5631 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11735/testReport/ |
| Max. process+thread count | 4833 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11735/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Add a test case for HBASE-14317
>
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381455#comment-16381455 ] Allan Yang commented on HBASE-20107: +1 for adding this case. This case helped us to verify the fix of HBASE-14317 > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20107-v1.patch, HBASE-20107-v2.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > _TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup_. > We'll never see stuck in this test case, because > FailedSyncBeforeLogCloseException will break > _zigzagLatch.waitSafePoint(SyncFuture)_. Finally, > _zigzagLatch.releaseSafePoint()_ will be call, and _attainSafePoint(long)_ > get out stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381406#comment-16381406 ] Zephyr Guo commented on HBASE-20107: Attached HBASE-20107-v2.patch to fix the checkstyle warmings. > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20107-v1.patch, HBASE-20107-v2.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > _TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup_. > We'll never see stuck in this test case, because > FailedSyncBeforeLogCloseException will break > _zigzagLatch.waitSafePoint(SyncFuture)_. Finally, > _zigzagLatch.releaseSafePoint()_ will be call, and _attainSafePoint(long)_ > get out stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381066#comment-16381066 ] Ted Yu commented on HBASE-20107: Please fix the checkstyle warnings in the new test > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20107-v1.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > _TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup_. > We'll never see stuck in this test case, because > FailedSyncBeforeLogCloseException will break > _zigzagLatch.waitSafePoint(SyncFuture)_. Finally, > _zigzagLatch.releaseSafePoint()_ will be call, and _attainSafePoint(long)_ > get out stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[
https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381064#comment-16381064
]
Hadoop QA commented on HBASE-20107:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
1s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
5s{color} | {color:red} hbase-server: The patch generated 4 new + 9 unchanged -
0 fixed = 13 total (was 9) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
51s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}109m
33s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}152m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20107 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12912470/HBASE-20107-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 148cd0d13deb 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 96ebab748f |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/11725/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/11725/testReport/ |
| Max. process+thread count | 4882 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380921#comment-16380921 ] Zephyr Guo commented on HBASE-20107: [~yuzhih...@gmail.com], thank you for reviewing. > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20107-v1.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > _TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup_. > We'll never see stuck in this test case, because > FailedSyncBeforeLogCloseException will break > _zigzagLatch.waitSafePoint(SyncFuture)_. Finally, > _zigzagLatch.releaseSafePoint()_ will be call, and _attainSafePoint(long)_ > get out stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380860#comment-16380860 ] Ted Yu commented on HBASE-20107: I ran the new test which passed. lgtm > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20107-v1.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > `TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup`. > We'll never see stuck in this test case, because > `FailedSyncBeforeLogCloseException` will break > `zigzagLatch.waitSafePoint(SyncFuture)`. Finally, > `zigzagLatch.releaseSafePoint()` will be call, and `attainSafePoint` get out > stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380837#comment-16380837 ] Zephyr Guo commented on HBASE-20107: [~yuzhih...@gmail.com] Yes, I mean that. > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Test > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > Attachments: HBASE-20107-v1.patch > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > `TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup`. > We'll never see stuck in this test case, because > `FailedSyncBeforeLogCloseException` will break > `zigzagLatch.waitSafePoint(SyncFuture)`. Finally, > `zigzagLatch.releaseSafePoint()` will be call, and `attainSafePoint` get out > stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20107) Add a test case for HBASE-14317
[ https://issues.apache.org/jira/browse/HBASE-20107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380826#comment-16380826 ] Ted Yu commented on HBASE-20107: bq. `attainSafePoint` get out stuck. Did you mean attainSafePoint would not get stuck ? > Add a test case for HBASE-14317 > --- > > Key: HBASE-20107 > URL: https://issues.apache.org/jira/browse/HBASE-20107 > Project: HBase > Issue Type: Improvement > Components: wal >Affects Versions: 3.0.0 >Reporter: Zephyr Guo >Priority: Minor > Fix For: 3.0.0 > > > RS might get stuck because of HBASE-14317. I met same problem in my hbase, > and HBASE-14317 can solve this problmen very well. > But I don't get stuck when I run > `TestWalLockup.testLockupWhenSyncInMiddleOfZigZagSetup`. > We'll never see stuck in this test case, because > `FailedSyncBeforeLogCloseException` will break > `zigzagLatch.waitSafePoint(SyncFuture)`. Finally, > `zigzagLatch.releaseSafePoint()` will be call, and `attainSafePoint` get out > stuck. > Here, we add a new test case to simulate stuck RS correctly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
