[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-06-29 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527710#comment-16527710
 ] 

Hudson commented on HBASE-20432:


Results for branch master
[build #380 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/380/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/380//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/380//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/380//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-20432.HBASE-19064.v1.patch, 
> HBASE-20432.HBASE-19064.v2.patch, HBASE-20432.HBASE-19064.v3.patch
>
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-05-03 Thread Zheng Hu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462298#comment-16462298
 ] 

Zheng Hu commented on HBASE-20432:
--

Pushed to branch HBASE-19064, Thanks [~Apache9] for reviewing ...

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Attachments: HBASE-20432.HBASE-19064.v1.patch, 
> HBASE-20432.HBASE-19064.v2.patch, HBASE-20432.HBASE-19064.v3.patch
>
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-05-03 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462119#comment-16462119
 ] 

Duo Zhang commented on HBASE-20432:
---

+1.

Please fix the checkstyle issue when committing.

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Attachments: HBASE-20432.HBASE-19064.v1.patch, 
> HBASE-20432.HBASE-19064.v2.patch, HBASE-20432.HBASE-19064.v3.patch
>
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-24 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449380#comment-16449380
 ] 

Hadoop QA commented on HBASE-20432:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-19064 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
50s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
46s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
26s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
36s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} HBASE-19064 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
17s{color} | {color:red} hbase-server: The patch generated 1 new + 0 unchanged 
- 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
32s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 37s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}120m 
26s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 30s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20432 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12920393/HBASE-20432.HBASE-19064.v3.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 8ab4fba0b913 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-19064 / 14687da733 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_162 |
| findbugs | v3.1.0-RC3 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12612/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/12612/testReport/ |
| Max. process+thread count | 4337 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445378#comment-16445378
 ] 

Hadoop QA commented on HBASE-20432:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-19064 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
51s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  
4s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
17s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
29s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
19s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} HBASE-19064 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m  
2s{color} | {color:red} hbase-server: The patch generated 1 new + 0 unchanged - 
0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
29s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
23s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}108m 
43s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
41s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}158m 46s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20432 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12919946/HBASE-20432.HBASE-19064.v2.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 47cabb1ab4ad 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-19064 / 2fd6813846 |
| maven | version: Apache Maven 3.5.3

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-19 Thread Zheng Hu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445203#comment-16445203
 ] 

Zheng Hu commented on HBASE-20432:
--

Ping [~Apache9] & [~zghaobac]  for reviewing.  Thanks. 

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Attachments: HBASE-20432.HBASE-19064.v1.patch
>
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-18 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442944#comment-16442944
 ] 

Hadoop QA commented on HBASE-20432:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} HBASE-19064 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
27s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
54s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
18s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
13s{color} | {color:green} HBASE-19064 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} HBASE-19064 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
16s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m 14s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
33s{color} | {color:green} hbase-replication in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}156m 
53s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
41s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}205m 20s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20432 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12919630/HBASE-20432.HBASE-19064.v1.patch
 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 3916a18cc42d 4.4.0-89-generic #112-Ubuntu SMP Mon Jul 31 
19:38:41 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | HBASE-19064 / 2fd6813846 |
| maven | version: Apache Maven 3.5.3 
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297;

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-18 Thread Zheng Hu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442182#comment-16442182
 ] 

Zheng Hu commented on HBASE-20432:
--

OK, Let me address this in document later  (HBASE-20393) ;

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-18 Thread Guanghao Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442166#comment-16442166
 ] 

Guanghao Zhang commented on HBASE-20432:


{quote}There's one problem: The source peerId may not match with the peerId in 
sink cluster
{quote}
So we need clear document for sync replication operations as our implementation 
is based on it..

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-18 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442162#comment-16442162
 ] 

Duo Zhang commented on HBASE-20432:
---

{quote}

There's one problem: The source peerId may not match with the peerId in sink 
cluster

{quote}

The design here is that you must use the same peer id... Think of how we decide 
the remote wal directory...

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-18 Thread Zheng Hu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442134#comment-16442134
 ] 

Zheng Hu commented on HBASE-20432:
--

bq. The remote wals on the remote cluster can be removed when we remove the 
sync replication peer on remote cluster ?

There's one problem:   The source peerId may not match with the peerId in sink 
cluster,  that's to say,  when I remove the sync replication peer with peerId = 
3 on remote cluster,  we'll remove the remote WALs for source peer with peerId 
= 3 , but source peer with peerId=3  may not be the correct sync replication 
peer  unless we ensure that both source & sink cluster will have the same 
peerId for sync-replication peer. 

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-17 Thread Guanghao Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441796#comment-16441796
 ] 

Guanghao Zhang commented on HBASE-20432:


As we don't have a cross-cluster procedure to handle this, so if we decide 
remove the remote wals dir when remove peer on remote cluster, we need add 
clear document for this operation. If user remove a peer in active cluster and 
add it back again, it will be wrong..

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-17 Thread Zheng Hu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441753#comment-16441753
 ] 

Zheng Hu commented on HBASE-20432:
--

bq. The remote wals on the remote cluster can be removed when we remove the 
sync replication peer on remote cluster ? 
Sound reasonable.  Will upload patch for this issue.

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20432) Cleanup related resources when remove a sync replication peer

2018-04-17 Thread Duo Zhang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440878#comment-16440878
 ] 

Duo Zhang commented on HBASE-20432:
---

The intention in the design of the sync replication is that, we do not touch 
the remote clusters in procedure. So I think we'd better only remove the remote 
WALs on our own cluster. The remote wals on the remote cluster can be removed 
when we remove the sync replication peer on remote cluster?

> Cleanup related resources when remove a sync replication peer
> -
>
> Key: HBASE-20432
> URL: https://issues.apache.org/jira/browse/HBASE-20432
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
>
> When remove a sync replication peer, we should clean:
> 1.  the SyncReplicationState in zookeeper or table. 
> 2.  Remote WALs  & Remote WALs directory in peer clusters. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)