[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[ https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524559#comment-16524559 ] stack commented on HBASE-20745: --- [~apurtell] Sorry about that. Should have made mention. Yeah, the logging every 5 seconds was worse that useless causing roll-away of actual problems. > Log when master proc wal rolls > -- > > Key: HBASE-20745 > URL: https://issues.apache.org/jira/browse/HBASE-20745 > Project: HBase > Issue Type: Sub-task > Components: debugging >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.2 > > Attachments: HBASE-20745.master.001.patch > > > Emit when we roll master proc WAL so can see when they happen. Want to > correlate instances of corruption w/ events on Master. Currently hard to do > on a server where log-level is INFO (default for many deploys). > Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck, > we can log so frequently, we roll away where the problem happened so lose the > chance to debug. Let me fix that too > Need both debugging instances of parent issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[ https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524482#comment-16524482 ] Andrew Purtell commented on HBASE-20745: Commit log talks about logging not config default change is all. > Log when master proc wal rolls > -- > > Key: HBASE-20745 > URL: https://issues.apache.org/jira/browse/HBASE-20745 > Project: HBase > Issue Type: Sub-task > Components: debugging >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.2 > > Attachments: HBASE-20745.master.001.patch > > > Emit when we roll master proc WAL so can see when they happen. Want to > correlate instances of corruption w/ events on Master. Currently hard to do > on a server where log-level is INFO (default for many deploys). > Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck, > we can log so frequently, we roll away where the problem happened so lose the > chance to debug. Let me fix that too > Need both debugging instances of parent issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[ https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524464#comment-16524464 ] stack commented on HBASE-20745: --- Intentional unless I changed wrong thing? In description I talk of how the 5 seconds is too frequent. Logs fill quickly. Issue that caused prob rolls away. What you thinking [~apurtell]? > Log when master proc wal rolls > -- > > Key: HBASE-20745 > URL: https://issues.apache.org/jira/browse/HBASE-20745 > Project: HBase > Issue Type: Sub-task > Components: debugging >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.2 > > Attachments: HBASE-20745.master.001.patch > > > Emit when we roll master proc WAL so can see when they happen. Want to > correlate instances of corruption w/ events on Master. Currently hard to do > on a server where log-level is INFO (default for many deploys). > Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck, > we can log so frequently, we roll away where the problem happened so lose the > chance to debug. Let me fix that too > Need both debugging instances of parent issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[
https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524450#comment-16524450
]
Andrew Purtell commented on HBASE-20745:
Intentional?
{noformat}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
index 3412c82f2d..d1e6e85f3c 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -136,7 +136,7 @@ public class AssignmentManager implements ServerListener {
public static final String RIT_CHORE_INTERVAL_MSEC_CONF_KEY =
"hbase.assignment.rit.chore.interval.msec";
- private static final int DEFAULT_RIT_CHORE_INTERVAL_MSEC = 5 * 1000;
+ private static final int DEFAULT_RIT_CHORE_INTERVAL_MSEC = 60 * 1000;
public static final String ASSIGN_MAX_ATTEMPTS =
"hbase.assignment.maximum.attempts";
{noformat}
Can we revert this bit and put it in with a separate JIRA? Or was this part of
a fix for something already logged?
> Log when master proc wal rolls
> --
>
> Key: HBASE-20745
> URL: https://issues.apache.org/jira/browse/HBASE-20745
> Project: HBase
> Issue Type: Sub-task
> Components: debugging
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.2
>
> Attachments: HBASE-20745.master.001.patch
>
>
> Emit when we roll master proc WAL so can see when they happen. Want to
> correlate instances of corruption w/ events on Master. Currently hard to do
> on a server where log-level is INFO (default for many deploys).
> Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck,
> we can log so frequently, we roll away where the problem happened so lose the
> chance to debug. Let me fix that too
> Need both debugging instances of parent issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[
https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518844#comment-16518844
]
Hudson commented on HBASE-20745:
Results for branch master
[build #371 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/371/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/371//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/371//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/371//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Log when master proc wal rolls
> --
>
> Key: HBASE-20745
> URL: https://issues.apache.org/jira/browse/HBASE-20745
> Project: HBase
> Issue Type: Sub-task
> Components: debugging
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.2
>
> Attachments: HBASE-20745.master.001.patch
>
>
> Emit when we roll master proc WAL so can see when they happen. Want to
> correlate instances of corruption w/ events on Master. Currently hard to do
> on a server where log-level is INFO (default for many deploys).
> Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck,
> we can log so frequently, we roll away where the problem happened so lose the
> chance to debug. Let me fix that too
> Need both debugging instances of parent issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[
https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518081#comment-16518081
]
Hudson commented on HBASE-20745:
Results for branch branch-2.0
[build #449 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/449/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/449//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/449//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/449//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Log when master proc wal rolls
> --
>
> Key: HBASE-20745
> URL: https://issues.apache.org/jira/browse/HBASE-20745
> Project: HBase
> Issue Type: Sub-task
> Components: debugging
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.2
>
> Attachments: HBASE-20745.master.001.patch
>
>
> Emit when we roll master proc WAL so can see when they happen. Want to
> correlate instances of corruption w/ events on Master. Currently hard to do
> on a server where log-level is INFO (default for many deploys).
> Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck,
> we can log so frequently, we roll away where the problem happened so lose the
> chance to debug. Let me fix that too
> Need both debugging instances of parent issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[
https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518047#comment-16518047
]
Hudson commented on HBASE-20745:
Results for branch branch-2
[build #883 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/883/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/883//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/883//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/883//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Log when master proc wal rolls
> --
>
> Key: HBASE-20745
> URL: https://issues.apache.org/jira/browse/HBASE-20745
> Project: HBase
> Issue Type: Sub-task
> Components: debugging
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.2
>
> Attachments: HBASE-20745.master.001.patch
>
>
> Emit when we roll master proc WAL so can see when they happen. Want to
> correlate instances of corruption w/ events on Master. Currently hard to do
> on a server where log-level is INFO (default for many deploys).
> Also, we log STUCK regions every 5 seconds. If a bundle of regions get stuck,
> we can log so frequently, we roll away where the problem happened so lose the
> chance to debug. Let me fix that too
> Need both debugging instances of parent issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20745) Log when master proc wal rolls
[
https://issues.apache.org/jira/browse/HBASE-20745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514932#comment-16514932
]
Hadoop QA commented on HBASE-20745:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
48s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
45s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 48s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
41s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
9s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}157m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-20745 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928092/HBASE-20745.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4867bec8e62c 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ac5bb8155b |
| maven | version:
