[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736497#comment-16736497
]
Sakthi commented on HBASE-21362:
Thanks [~elserj] for pushing this in.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Fix For: 3.0.0, 2.2.0
>
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736464#comment-16736464
]
Josh Elser commented on HBASE-21362:
Verified this on my local installation. Good work, Sakthi!
Going to look at pulling back to branch-2 as well.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736287#comment-16736287
]
Sakthi commented on HBASE-21362:
Thanks Josh.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736264#comment-16736264
]
Josh Elser commented on HBASE-21362:
It's on my list to merge this in. Got distracted last week when I started. Will
finish it up.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734478#comment-16734478
]
Josh Elser commented on HBASE-21362:
LGTM. Thanks for the nice little improvement, [~jatsakthi].
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729252#comment-16729252
]
Hadoop QA commented on HBASE-21362:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m
7s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 2s{color} | {color:orange} The patch generated 2 new + 15 unchanged - 0
fixed = 17 total (was 15) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m
49s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21362 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12953094/hbase-21362.master.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit rubocop
ruby_lint |
| uname | Linux f7feff247a79 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c552088877 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.60.0 |
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/15391/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/15391/testReport/ |
| Max. process+thread count | 2606 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15391/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
>
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16729245#comment-16729245
]
Sakthi commented on HBASE-21362:
The shell looks like this after the patch.
{noformat}
# ---SPACE QUOTA
hbase(main):013:0> put 't2','r','cf:col','val'
ERROR: NO_WRITES Puts are disallowed due to a space quota.
For usage try 'help "put"'
Took 0.0017 seconds
# ---THROTTLE QUOTA
hbase(main):008:0> scan 't2'
ROW COLUMN+CELL
ERROR: Number of read requests exceeded - wait 12sec
For usage try 'help "scan"'
Took 8.2191 seconds
hbase(main):003:0> put 't2','r','cf:col','value'
ERROR: Request size limit exceeded - wait 1hrs, 39mins, 0sec
For usage try 'help "put"'
Took 8.2057 seconds
{noformat}
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch, hbase-21362.master.003.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728540#comment-16728540
]
Sakthi commented on HBASE-21362:
The above patch is for Space quota. Working on throttle quota. Will upload a
patch soon.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727189#comment-16727189
]
Sakthi commented on HBASE-21362:
[~elserj], Could you please review? Thanks.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726997#comment-16726997
]
Hadoop QA commented on HBASE-21362:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m
5s{color} | {color:green} There were no new rubocop issues. {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 1s{color} | {color:orange} The patch generated 1 new + 15 unchanged - 0
fixed = 16 total (was 15) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
31s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21362 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12952725/hbase-21362.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit rubocop
ruby_lint |
| uname | Linux 3fc3bbce4dbc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 12786f80c1 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.60.0 |
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/15360/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/15360/testReport/ |
| Max. process+thread count | 2399 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15360/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch,
> hbase-21362.master.002.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
>
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726546#comment-16726546
]
Hadoop QA commented on HBASE-21362:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 1 new + 28 unchanged - 0 fixed = 29
total (was 28) {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 2s{color} | {color:orange} The patch generated 1 new + 15 unchanged - 0
fixed = 16 total (was 15) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 13m
18s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21362 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12952637/hbase-21362.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit rubocop
ruby_lint |
| uname | Linux af3aa0f4280c 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ad819380c7 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| rubocop | v0.61.1 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/15352/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/15352/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/15352/testReport/ |
| Max. process+thread count | 2511 (vs. ulimit of 1) |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15352/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
>
[jira] [Commented] (HBASE-21362) Disable printing of stack-trace in shell when quotas are violated
[
https://issues.apache.org/jira/browse/HBASE-21362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726509#comment-16726509
]
Sakthi commented on HBASE-21362:
A minor patch. It was verified using the shell. Didn't add a UT(was too minor)
> Disable printing of stack-trace in shell when quotas are violated
> -
>
> Key: HBASE-21362
> URL: https://issues.apache.org/jira/browse/HBASE-21362
> Project: HBase
> Issue Type: Sub-task
> Components: shell
>Reporter: Sakthi
>Assignee: Sakthi
>Priority: Minor
> Attachments: hbase-21362.master.001.patch
>
>
> When quotas are violated, a 'Quota violated on #table. Due to
> #ViolationPolicy, #Action is not allowed' message should suffice. The current
> trace in shell looks like this:
> {noformat}
> hbase(main):009:0> put 't2','r1','cf1:c','val'
> ERROR: org.apache.hadoop.hbase.quotas.SpaceLimitingException: NO_WRITES Puts
> are disallowed due to a space quota.
> at
> org.apache.hadoop.hbase.quotas.policies.NoWritesViolationPolicyEnforcement.check(NoWritesViolationPolicyEnforcement.java:46)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2779)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42000)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
