[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824015#comment-16824015
]
Hudson commented on HBASE-21388:
Results for branch master
[build #954 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/954/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/954//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/954//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/954//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch,
> HBASE-21388.master.004.patch, HBASE-21388.master.004.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672189#comment-16672189
]
Hudson commented on HBASE-21388:
Results for branch branch-2.1
[build #568 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/568/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/568//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/568//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/568//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch,
> HBASE-21388.master.004.patch, HBASE-21388.master.004.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672147#comment-16672147
]
Hudson commented on HBASE-21388:
Results for branch branch-2.0
[build #1048 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1048/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1048//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1048//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1048//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch,
> HBASE-21388.master.004.patch, HBASE-21388.master.004.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672138#comment-16672138
]
Hudson commented on HBASE-21388:
Results for branch branch-2
[build #1476 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1476/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1476//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1476//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1476//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch,
> HBASE-21388.master.004.patch, HBASE-21388.master.004.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671932#comment-16671932
]
Hudson commented on HBASE-21388:
Results for branch master
[build #580 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/580/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/580//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/580//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch,
> HBASE-21388.master.004.patch, HBASE-21388.master.004.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671266#comment-16671266 ] Guanghao Zhang commented on HBASE-21388: Pushed all branch-2.0+ branch. Thanks [~stack] [~anoop.hbase] for reviewing. > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2 > > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch, HBASE-21388.master.003.patch, > HBASE-21388.master.004.patch, HBASE-21388.master.004.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671094#comment-16671094 ] stack commented on HBASE-21388: --- +1 on patch. +1 for branch-2.1 and branch-2.0. Thanks for ping [~zghaobac] > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch, HBASE-21388.master.003.patch, > HBASE-21388.master.004.patch, HBASE-21388.master.004.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671043#comment-16671043
]
Hadoop QA commented on HBASE-21388:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 43s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946474/HBASE-21388.master.004.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7a16c8fa5a26 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 6d709c0311 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14915/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14915/testReport/ |
| Max. process+thread count | 99 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14915/console |
| Powered by | Apache
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671004#comment-16671004 ] Guanghao Zhang commented on HBASE-21388: Retry 004 patch for Hadoop QA. And ping [~stack] for branch-2.1 and branch-2.0. Thanks. > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch, HBASE-21388.master.003.patch, > HBASE-21388.master.004.patch, HBASE-21388.master.004.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670071#comment-16670071 ] Anoop Sam John commented on HBASE-21388: +1 > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch, HBASE-21388.master.003.patch, > HBASE-21388.master.004.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669916#comment-16669916
]
Hadoop QA commented on HBASE-21388:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
15s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
59s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 11s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946320/HBASE-21388.master.004.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d96255829abc 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24
13:14:43 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 02f5f171f5 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14907/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14907/testReport/ |
| Max. process+thread count | 99 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14907/console |
| Powered by | Apache
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16669849#comment-16669849
]
Guanghao Zhang commented on HBASE-21388:
[~anoop.hbase] Any more comments? And copy the comments from ReviewBoard.
{quote}bq. Now tables on master is broken. See HBASE-19831 and HBASE-19785. So
we can do these jobs in the future. 1. Make sure that isTablesOnMaster is false
and isSystemTablesOnlyOnMaster is true can't work. 2. introduce a special
memstore/blockcache(which is smaller than RS) config for
SystemTablesOnlyOnMaster.
{quote}
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch, HBASE-21388.master.003.patch,
> HBASE-21388.master.004.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668252#comment-16668252
]
Hadoop QA commented on HBASE-21388:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
51s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}221m
3s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}265m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946144/HBASE-21388.master.003.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 4e18b93b3c6d 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4b86dd248a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14897/testReport/ |
| Max. process+thread count | 4892 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14897/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> No need to
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667960#comment-16667960 ] Guanghao Zhang commented on HBASE-21388: Rebase master and add a new 003 patch for Hadoop QA. > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch, HBASE-21388.master.003.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667957#comment-16667957 ] Guanghao Zhang commented on HBASE-21388: We don't config a special hbase.hregion.memstore.chunkpool.initialsize and the default initial count percentage is 0. So the initial count is 0 in the log. But this jira's point is not to create any memstore chunk when master not carry table. It is useful when master only has a small heap/offheap. We may config hbase.hregion.memstore.chunkpool.initialsize for regionserver but we don't want master to create memstore chunk, too. Thanks. [~anoop.hbase] > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667950#comment-16667950
]
Guanghao Zhang commented on HBASE-21388:
{quote}bq. If initial count comes as >0, those many chunks (Each 2 MB) will be
created on server starts up itself. But here it is 0. So no worries much.
{quote}
Thanks. Let me check the code.
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667245#comment-16667245 ] Anoop Sam John commented on HBASE-21388: bq.So the chunk is lazy created? Only create chunk when need? Yes. If initial count comes as >0, those many chunks (Each 2 MB) will be created on server starts up itself. But here it is 0. So no worries much. > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667116#comment-16667116
]
Guanghao Zhang commented on HBASE-21388:
{quote}So there is no space reserved for these chunks.
{quote}
So the chunk is created lazied? Only create chunk when need?
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667112#comment-16667112
]
Guanghao Zhang commented on HBASE-21388:
{quote}bq.But ya when HM do not carry any region better not to have any MSLAB
chunks and Block cache there
{quote}
The block cache is finished in HBASE-21290.
> No need to instantiate MemStoreLAB for master which not carry table
> ---
>
> Key: HBASE-21388
> URL: https://issues.apache.org/jira/browse/HBASE-21388
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-21388.master.001.patch,
> HBASE-21388.master.002.patch
>
>
> We found this log in our master.
> 2018-10-26,10:00:00,449 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data
> MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0
> 2018-10-26,10:00:00,452 INFO
> [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster]
> org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index
> MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0
>
> Same with HBASE-21290, we don't need to instantiate MemStore for master which
> not carry table.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667031#comment-16667031 ] Anoop Sam John commented on HBASE-21388: bq.initial count 0 So there is no space reserved for these chunks. But ya when HM do not carry any region better not to have any MSLAB chunks and Block cache there > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0, 2.2.0, 2.1.1, 2.0.2 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch, > HBASE-21388.master.002.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1985#comment-1985
]
Hadoop QA commented on HBASE-21388:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
17s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 26s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}240m 50s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}286m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945984/HBASE-21388.master.002.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d3e72d93c211 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c0b994b0c6 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14894/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14894/testReport/ |
| Max. process+thread count | 4920 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/14894/console |
| Powered by |
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[
https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1821#comment-1821
]
Hadoop QA commented on HBASE-21388:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
14s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
49s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
16s{color} | {color:red} hbase-server: The patch generated 2 new + 158
unchanged - 0 fixed = 160 total (was 158) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
16s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
10m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 15s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}173m 39s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestMasterNotCarryTable |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21388 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945980/HBASE-21388.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 605ed17e46b7 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c0b994b0c6 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/14892/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/14892/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test
[jira] [Commented] (HBASE-21388) No need to instantiate MemStoreLAB for master which not carry table
[ https://issues.apache.org/jira/browse/HBASE-21388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1712#comment-1712 ] Guanghao Zhang commented on HBASE-21388: The MemStoreLAB and ChunkCreator is global per process. The minicluster start master and rs in same process, the ut will failed as rs will create a new MemStoreLAB. Will find a way to resolve this later. > No need to instantiate MemStoreLAB for master which not carry table > --- > > Key: HBASE-21388 > URL: https://issues.apache.org/jira/browse/HBASE-21388 > Project: HBase > Issue Type: Improvement >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Attachments: HBASE-21388.master.001.patch > > > We found this log in our master. > 2018-10-26,10:00:00,449 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating data > MemStoreChunkPool with chunk size 2 MB, max count 737, initial count 0 > 2018-10-26,10:00:00,452 INFO > [master/c4-hadoop-tst-ct16:42900:becomeActiveMaster] > org.apache.hadoop.hbase.regionserver.ChunkCreator: Allocating index > MemStoreChunkPool with chunk size 204.80 KB, max count 819, initial count 0 > > Same with HBASE-21290, we don't need to instantiate MemStore for master which > not carry table. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
