[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[ https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440137#comment-13440137 ] Hadoop QA commented on HBASE-2155: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542078/HBASE-2155.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2660//console This message is automatically generated. Add the option to bind to a specific IP address to the Nonblocking Thrift servers - Key: HBASE-2155 URL: https://issues.apache.org/jira/browse/HBASE-2155 Project: HBase Issue Type: Improvement Components: thrift Reporter: Lars Francke Assignee: liang xie Priority: Minor Fix For: 0.96.0 Attachments: HBASE-2155.patch This is not possible in Thrift 0.2.0 so we'll have to wait until the next version is released (which includes THRIFT-684). After that is released this is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[ https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440298#comment-13440298 ] Zhihong Ted Yu commented on HBASE-2155: --- Test failure is not related to thrift. Integrated to trunk. Thanks for the patch, Liang. Add the option to bind to a specific IP address to the Nonblocking Thrift servers - Key: HBASE-2155 URL: https://issues.apache.org/jira/browse/HBASE-2155 Project: HBase Issue Type: Improvement Components: thrift Reporter: Lars Francke Assignee: liang xie Priority: Minor Fix For: 0.96.0 Attachments: HBASE-2155.patch This is not possible in Thrift 0.2.0 so we'll have to wait until the next version is released (which includes THRIFT-684). After that is released this is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[ https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440356#comment-13440356 ] Hudson commented on HBASE-2155: --- Integrated in HBase-TRUNK #3257 (See [https://builds.apache.org/job/HBase-TRUNK/3257/]) HBASE-2155 Add the option to bind to a specific IP address to the Nonblocking Thrift servers (Liang Xie) (Revision 1376490) Result = SUCCESS Tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java Add the option to bind to a specific IP address to the Nonblocking Thrift servers - Key: HBASE-2155 URL: https://issues.apache.org/jira/browse/HBASE-2155 Project: HBase Issue Type: Improvement Components: thrift Reporter: Lars Francke Assignee: liang xie Priority: Minor Fix For: 0.96.0 Attachments: HBASE-2155.patch This is not possible in Thrift 0.2.0 so we'll have to wait until the next version is released (which includes THRIFT-684). After that is released this is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[ https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440781#comment-13440781 ] Hudson commented on HBASE-2155: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #144 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/144/]) HBASE-2155 Add the option to bind to a specific IP address to the Nonblocking Thrift servers (Liang Xie) (Revision 1376490) Result = FAILURE Tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java Add the option to bind to a specific IP address to the Nonblocking Thrift servers - Key: HBASE-2155 URL: https://issues.apache.org/jira/browse/HBASE-2155 Project: HBase Issue Type: Improvement Components: thrift Reporter: Lars Francke Assignee: liang xie Priority: Minor Fix For: 0.96.0 Attachments: HBASE-2155.patch This is not possible in Thrift 0.2.0 so we'll have to wait until the next version is released (which includes THRIFT-684). After that is released this is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[
https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439632#comment-13439632
]
Zhihong Ted Yu commented on HBASE-2155:
---
What about this server type :
{code}
THREADED_SELECTOR(
threadedselector, true, TThreadedSelectorServer.class, false);
{code}
Does the change apply to the above type ?
Add the option to bind to a specific IP address to the Nonblocking Thrift
servers
-
Key: HBASE-2155
URL: https://issues.apache.org/jira/browse/HBASE-2155
Project: HBase
Issue Type: Improvement
Components: thrift
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Minor
Attachments: HBASE-2155.patch
This is not possible in Thrift 0.2.0 so we'll have to wait until the next
version is released (which includes THRIFT-684). After that is released this
is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[ https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440019#comment-13440019 ] liang xie commented on HBASE-2155: -- I forgot to rename the patch V2, hence deleted the old patch to avoid misunderstanding:) Add the option to bind to a specific IP address to the Nonblocking Thrift servers - Key: HBASE-2155 URL: https://issues.apache.org/jira/browse/HBASE-2155 Project: HBase Issue Type: Improvement Components: thrift Reporter: Lars Francke Assignee: Lars Francke Priority: Minor Attachments: HBASE-2155.patch This is not possible in Thrift 0.2.0 so we'll have to wait until the next version is released (which includes THRIFT-684). After that is released this is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[
https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044065#comment-13044065
]
Krystian Nowak commented on HBASE-2155:
---
Thrift
[0.6.1|https://issues.apache.org/jira/browse/THRIFT/fixforversion/12316320] is
already available. It's also available through the Maven repo by including:
{noformat}
dependency
groupIdorg.apache.thrift/groupId
artifactIdlibthrift/artifactId
version0.6.1/version
/dependency
{noformat}
Add the option to bind to a specific IP address to the Nonblocking Thrift
servers
-
Key: HBASE-2155
URL: https://issues.apache.org/jira/browse/HBASE-2155
Project: HBase
Issue Type: Improvement
Components: thrift
Reporter: Lars Francke
Assignee: Lars Francke
Priority: Minor
This is not possible in Thrift 0.2.0 so we'll have to wait until the next
version is released (which includes THRIFT-684). After that is released this
is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-2155) Add the option to bind to a specific IP address to the Nonblocking Thrift servers
[ https://issues.apache.org/jira/browse/HBASE-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13044091#comment-13044091 ] Krystian Nowak commented on HBASE-2155: --- http://svn.apache.org/viewvc/hbase/trunk/pom.xml?view=markup already references thrift 0.6.1 in fact Add the option to bind to a specific IP address to the Nonblocking Thrift servers - Key: HBASE-2155 URL: https://issues.apache.org/jira/browse/HBASE-2155 Project: HBase Issue Type: Improvement Components: thrift Reporter: Lars Francke Assignee: Lars Francke Priority: Minor This is not possible in Thrift 0.2.0 so we'll have to wait until the next version is released (which includes THRIFT-684). After that is released this is an easy and quick fix. For a few more details see HBASE-1373 and HBASE-65. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
