[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[
https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728379#comment-16728379
]
Hudson commented on HBASE-21629:
Results for branch branch-2
[build #1575 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1575/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1575//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1575//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1575//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> draining_servers.rb is broken
> -
>
> Key: HBASE-21629
> URL: https://issues.apache.org/jira/browse/HBASE-21629
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.0.0, 2.1.1, 2.1.2
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4
>
> Attachments: HBASE-21629.master.001.patch, add_before.png,
> add_then_list_after.png, list_after.png, list_before.png, remove_before.png,
> remove_then_list_after.png
>
>
> 1) Handle missing methods and implementation changes in core code.
> * In
> [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79],
> variable znodePaths has now been made private from public (See HBASE-19761).
> Currently the script directly tries to reference znodePaths which will result
> in exception.
> * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See
> HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does
> not close the zkw instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[
https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728373#comment-16728373
]
Hudson commented on HBASE-21629:
Results for branch branch-2.1
[build #709 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/709/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/709//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/709//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/709//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> draining_servers.rb is broken
> -
>
> Key: HBASE-21629
> URL: https://issues.apache.org/jira/browse/HBASE-21629
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.0.0, 2.1.1, 2.1.2
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4
>
> Attachments: HBASE-21629.master.001.patch, add_before.png,
> add_then_list_after.png, list_after.png, list_before.png, remove_before.png,
> remove_then_list_after.png
>
>
> 1) Handle missing methods and implementation changes in core code.
> * In
> [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79],
> variable znodePaths has now been made private from public (See HBASE-19761).
> Currently the script directly tries to reference znodePaths which will result
> in exception.
> * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See
> HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does
> not close the zkw instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[
https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728346#comment-16728346
]
Hudson commented on HBASE-21629:
Results for branch master
[build #679 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/679/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/679//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/679//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/679//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> draining_servers.rb is broken
> -
>
> Key: HBASE-21629
> URL: https://issues.apache.org/jira/browse/HBASE-21629
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.0.0, 2.1.1, 2.1.2
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4
>
> Attachments: HBASE-21629.master.001.patch, add_before.png,
> add_then_list_after.png, list_after.png, list_before.png, remove_before.png,
> remove_then_list_after.png
>
>
> 1) Handle missing methods and implementation changes in core code.
> * In
> [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79],
> variable znodePaths has now been made private from public (See HBASE-19761).
> Currently the script directly tries to reference znodePaths which will result
> in exception.
> * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See
> HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does
> not close the zkw instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[
https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728337#comment-16728337
]
Hudson commented on HBASE-21629:
Results for branch branch-2.0
[build #1192 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1192/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1192//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1192//console].
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1192//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> draining_servers.rb is broken
> -
>
> Key: HBASE-21629
> URL: https://issues.apache.org/jira/browse/HBASE-21629
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.0.0, 2.1.1, 2.1.2
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.2, 2.0.4
>
> Attachments: HBASE-21629.master.001.patch, add_before.png,
> add_then_list_after.png, list_after.png, list_before.png, remove_before.png,
> remove_then_list_after.png
>
>
> 1) Handle missing methods and implementation changes in core code.
> * In
> [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79],
> variable znodePaths has now been made private from public (See HBASE-19761).
> Currently the script directly tries to reference znodePaths which will result
> in exception.
> * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See
> HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does
> not close the zkw instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[
https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728042#comment-16728042
]
Nihal Jain commented on HBASE-21629:
{quote}Paste in here evidence it works
{quote}
Sure Sir. Attached screenshots (before and after patch).
> draining_servers.rb is broken
> -
>
> Key: HBASE-21629
> URL: https://issues.apache.org/jira/browse/HBASE-21629
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.0.0, 2.1.1, 2.1.2
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-21629.master.001.patch, add_before.png,
> add_then_list_after.png, list_after.png, list_before.png, remove_before.png,
> remove_then_list_after.png
>
>
> 1) Handle missing methods and implementation changes in core code.
> * In
> [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79],
> variable znodePaths has now been made private from public (See HBASE-19761).
> Currently the script directly tries to reference znodePaths which will result
> in exception.
> * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See
> HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does
> not close the zkw instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[ https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728031#comment-16728031 ] stack commented on HBASE-21629: --- +1 on patch. Past in here evidence it works (perhaps a before and after [~nihaljain.cs]?) Thank you. > draining_servers.rb is broken > - > > Key: HBASE-21629 > URL: https://issues.apache.org/jira/browse/HBASE-21629 > Project: HBase > Issue Type: Bug > Components: scripts >Affects Versions: 3.0.0, 2.1.1, 2.1.2 >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Attachments: HBASE-21629.master.001.patch > > > 1) Handle missing methods and implementation changes in core code. > * In > [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79], > variable znodePaths has now been made private from public (See HBASE-19761). > Currently the script directly tries to reference znodePaths which will result > in exception. > * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See > HBASE-19200). The script relies on non-existant ZKUtil.joinZNode(). > 2) Close zk watcher while list draining servers: The list functionality does > not close the zkw instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21629) draining_servers.rb is broken
[
https://issues.apache.org/jira/browse/HBASE-21629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727840#comment-16727840
]
Hadoop QA commented on HBASE-21629:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
4s{color} | {color:red} The patch generated 3 new + 38 unchanged - 3 fixed = 41
total (was 41) {color} |
| {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange}
0m 2s{color} | {color:orange} The patch generated 5 new + 22 unchanged - 3
fixed = 27 total (was 25) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21629 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12952940/HBASE-21629.master.001.patch
|
| Optional Tests | dupname asflicense rubocop ruby_lint |
| uname | Linux 5d27c1770efc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7c0a3cc265 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| rubocop | v0.60.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/15366/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/15366/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Max. process+thread count | 48 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15366/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> draining_servers.rb is broken
> -
>
> Key: HBASE-21629
> URL: https://issues.apache.org/jira/browse/HBASE-21629
> Project: HBase
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.0.0, 2.1.1, 2.1.2
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Attachments: HBASE-21629.master.001.patch
>
>
> 1) Handle missing methods and implementation changes in core code.
> * In
> [ZKWatcher.java|https://github.com/apache/hbase/blob/12786f80c14c6f2c3c111a55bbf431fb2e81e828/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L79],
> variable znodePaths has now been made private from public (See HBASE-19761).
> Currently the script directly tries to reference znodePaths which will result
> in exception.
> * Also, joinZNode method is moved to ZNodePaths and removed from ZKUtil (See
> HBASE-19200). The script relies on non-existant ZKUtil.joinZNode().
> 2) Close zk watcher while list draining servers: The list functionality does
> not close the zkw instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
