[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2020-09-22 Thread zhengsicheng (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199901#comment-17199901
 ] 

zhengsicheng commented on HBASE-21678:
--

[~apurtell]

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2020-09-21 Thread zhengsicheng (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199347#comment-17199347
 ] 

zhengsicheng commented on HBASE-21678:
--

branch-1 
{code:java}
// code placeholder
org.apache.hadoop.hbase.regionserver.StoreFileScanner.java
@Override
public boolean shouldUseScanner(Scan scan, SortedSet columns, long 
oldestUnexpiredTS) {
  return reader.passesTimerangeFilter(scan, oldestUnexpiredTS)
  && reader.passesKeyRangeFilter(scan) && reader.passesBloomFilter(scan, 
columns);
}

org.apache.hadoop.hbase.regionserver.TestRowPrefixBloomFilter.java
HStore store = mock(HStore.class);

boolean exists = scanner.shouldUseScanner(scan, store, Long.MIN_VALUE);

The test failed !
{code}

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2020-07-25 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165104#comment-17165104
 ] 

Andrew Kyle Purtell commented on HBASE-21678:
-

This is available in HBase 2. No plans to backport.

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2020-07-24 Thread Alex Batyrshin (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164455#comment-17164455
 ] 

Alex Batyrshin commented on HBASE-21678:


[~apurtell] any information about releasing this feature?

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-24 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751352#comment-16751352
 ] 

Andrew Purtell commented on HBASE-21678:


This hasn't attracted any reviews and is not critical for inclusion in 1.5. I 
thought it would be a nice to have based on some Phoenix related discussion at 
my workplace, but even then it's not a must have. That's fine. Resolving this 
as Wont Fix.

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-19 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747263#comment-16747263
 ] 

Andrew Purtell commented on HBASE-21678:


Otherwise change looks good. I can fix the remaining checkstyle warns on 
commit. Would be good to get a +1 if you have any spare time to make a quick 
check [~lhofhansl] [~abhishek.chouhan] or original author [~andrewcheng]

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-19 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747261#comment-16747261
 ] 

Andrew Purtell commented on HBASE-21678:


Sigh, new checkstyle nits now that previous attempt is touching more files just 
to clean up checkstyle nits

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-18 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746900#comment-16746900
 ] 

Hadoop QA commented on HBASE-21678:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 10 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  5m 
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
 4s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
21s{color} | {color:green} branch-1 passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
52s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
46s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
10s{color} | {color:green} branch-1 passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
25s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
35s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
35s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
27s{color} | {color:red} hbase-server: The patch generated 2 new + 654 
unchanged - 29 fixed = 656 total (was 683) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
48s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m 42s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
19s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
30s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}112m 
52s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
35s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} |

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-18 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746764#comment-16746764
 ] 

Andrew Purtell commented on HBASE-21678:


Updated patch address checkstyle warnings and unit test failure

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch, 
> HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-18 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746757#comment-16746757
 ] 

Andrew Purtell commented on HBASE-21678:


TestHFileOutputFormat does look germane, checking

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-17 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745736#comment-16745736
 ] 

Hadoop QA commented on HBASE-21678:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 8 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
53s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
44s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
21s{color} | {color:green} branch-1 passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
37s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
52s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
45s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} branch-1 passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
24s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
39s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
27s{color} | {color:red} hbase-server: The patch generated 30 new + 286 
unchanged - 26 fixed = 316 total (was 312) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
45s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m 40s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
16s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
27s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}111m 18s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
35s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green}

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-17 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745654#comment-16745654
 ] 

Andrew Purtell commented on HBASE-21678:


Adjusted some formatting in StoreFile. Let's see if that is better

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch, HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-17 Thread Andrew Purtell (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745643#comment-16745643
 ] 

Andrew Purtell commented on HBASE-21678:


Test failures are unrelated. The checkstyle and whitespace issues reported are 
related. I didn't change formatting during the backport but can do so to make 
these tools happier. Let me do that

> Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and 
> ROWPREFIX_DELIMITED) to branch-1
> 
>
> Key: HBASE-21678
> URL: https://issues.apache.org/jira/browse/HBASE-21678
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: HBASE-21678-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-21678) Port HBASE-20636 (Introduce two bloom filter type ROWPREFIX and ROWPREFIX_DELIMITED) to branch-1

2019-01-14 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HBASE-21678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742628#comment-16742628
 ] 

Hadoop QA commented on HBASE-21678:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 8 new or modified test 
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  5m 
37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
 6s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
22s{color} | {color:green} branch-1 passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
37s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
50s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
47s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
8s{color} | {color:green} branch-1 passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
26s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
36s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
25s{color} | {color:red} hbase-server: The patch generated 26 new + 309 
unchanged - 3 fixed = 335 total (was 312) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
43s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
8s{color} | {color:green} the patch passed with JDK v1.8.0_192 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
11s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
26s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}117m 26s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
31s{color} | {color:green}