[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812401#comment-16812401 ] Peter Somogyi commented on HBASE-21818: --- Thanks [~iamgd67] for taking the time to fix the git issue. The tests errors are unrelated, only thejavadoc changed here. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch, > HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812389#comment-16812389 ] HBase QA commented on HBASE-21818: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m 59s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 32s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 40s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 20s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 38s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 36s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 35s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 1m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}180m 9s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}223m 41s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.client.TestAdmin2 | | | hadoop.hbase.master.TestMasterBalanceThrottling | | | hadoop.hbase.client.TestReplicaWithCluster | | | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint | | | hadoop.hbase.regionserver.TestBlocksRead | | |
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812232#comment-16812232 ] qiang Liu commented on HBASE-21818: --- after set core.autocrlf use {code:java} git config --global core.autocrlf true {code} the gernerate patch is still end with \r\n , I manually delete all \r , submmit patch 006 > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch, > HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812229#comment-16812229 ] HBase QA commented on HBASE-21818: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color} | {color:red} HBASE-21818 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12965169/HBASE-21818.branch-1.005.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/22/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.004.patch, HBASE-21818.branch-1.005.patch, > HBASE-21818.branch-1.006.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812215#comment-16812215 ] Peter Somogyi commented on HBASE-21818: --- After checking the patch file you uploaded it looks like the line ending is the windows format: CRLF. I think you set incorrectly core.autocrlf in your git config. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.004.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812200#comment-16812200 ] Peter Somogyi commented on HBASE-21818: --- Is your branch up-to-date with GitHub and your commit is applied on top of branch-1? > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.004.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812195#comment-16812195 ] HBase QA commented on HBASE-21818: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color} | {color:red} HBASE-21818 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12965165/HBASE-21818.branch-1.004.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/20/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.004.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812185#comment-16812185 ] qiang Liu commented on HBASE-21818: --- why not applyed? very confused > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812149#comment-16812149 ] HBase QA commented on HBASE-21818: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color} | {color:red} HBASE-21818 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12965160/HBASE-21818.branch-1.003.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/18/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.1.001.patch, HBASE-21818.branch-1.1.002.patch, > blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812147#comment-16812147 ] qiang Liu commented on HBASE-21818: --- sorry for submit the wront format patch, and thanks [~psomogyi] for teach me use submit-patch.py tool, I use it to resubmit a pach. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Assignee: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.002.patch, HBASE-21818.branch-1.003.patch, > HBASE-21818.branch-1.1.001.patch, HBASE-21818.branch-1.1.002.patch, > blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804838#comment-16804838 ] Peter Somogyi commented on HBASE-21818: --- Hi [~iamgd67], branch-1.1 is EOL. Could you try to attach a patch using dev-support/submit-patch.py instead targeting a patch for branch-1? Intellij does not have the same patch format and it does not have your commit informations in it (e.g. name, email address). > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.1.001.patch, HBASE-21818.branch-1.1.002.patch, > blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774643#comment-16774643 ] Hadoop QA commented on HBASE-21818: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} docker {color} | {color:red} 19m 2s{color} | {color:red} Docker failed to build yetus/hbase:a527708. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12959694/HBASE-21818.branch-1.1.002.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/16081/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.1.001.patch, HBASE-21818.branch-1.1.002.patch, > blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774632#comment-16774632 ] qiang Liu commented on HBASE-21818: --- patch number added > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.1.001.patch, HBASE-21818.branch-1.1.002.patch, > blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764651#comment-16764651 ] Hadoop QA commented on HBASE-21818: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} docker {color} | {color:red} 13m 49s{color} | {color:red} Docker failed to build yetus/hbase:a527708. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12958190/HBASE-21818.branch-1.1.001.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15919/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.1.001.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764639#comment-16764639 ] qiang Liu commented on HBASE-21818: --- patch for branch 1.1 [^HBASE-21818.branch-1.1.001.patch] > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, > HBASE-21818.branch-1.1.001.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758147#comment-16758147 ] qiang Liu commented on HBASE-21818: --- why branch-1 can't compile suucessful, witch branch should i create pach on? > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, blankLineOfJavaDoc.png > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758073#comment-16758073 ] Hadoop QA commented on HBASE-21818: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-1 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 59s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s{color} | {color:green} branch-1 passed with JDK v1.8.0_201 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 41s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 27s{color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 46s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} branch-1 passed with JDK v1.8.0_201 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} branch-1 passed with JDK v1.7.0_201 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s{color} | {color:green} the patch passed with JDK v1.8.0_201 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 39s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m 43s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 1m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} the patch passed with JDK v1.8.0_201 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} the patch passed with JDK v1.7.0_201 {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}110m 3s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}129m 27s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 | | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12957210/HBASE-21818.branch-1.001.patch | | Optional Tests | dupname asflicense javac javadoc unit
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758000#comment-16758000 ] qiang Liu commented on HBASE-21818: --- recreate pach from branch-1 [^HBASE-21818.branch-1.001.patch] > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: HBASE-21818.branch-1.001.patch, blankLineOfJavaDoc.png, > javadocOfHMaster.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21818) a document write misstack
[ https://issues.apache.org/jira/browse/HBASE-21818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757969#comment-16757969 ] Hadoop QA commented on HBASE-21818: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color} | {color:red} HBASE-21818 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HBASE-21818 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12957202/javadocOfHMaster.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15829/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > a document write misstack > - > > Key: HBASE-21818 > URL: https://issues.apache.org/jira/browse/HBASE-21818 > Project: HBase > Issue Type: Improvement > Components: documentation, master >Affects Versions: 1.1.0, 2.0.1 > Environment: has nothing to do with env >Reporter: qiang Liu >Priority: Trivial > Labels: easyfix, javadoc > Fix For: 2.0.2 > > Attachments: blankLineOfJavaDoc.png, javadocOfHMaster.patch > > Original Estimate: 1m > Remaining Estimate: 1m > > the java doc of this function type a as ,so dispaly a blanck line > {code:java} > //org.apache.hadoop.hbase.master.HMaster#finishActiveMasterInitialization > {code} > paste the function and it's doc here , please look the line "Ensure > assignment of meta/namespace regions" > > > {code:java} > /** > * Finish initialization of HMaster after becoming the primary master. > * > * > * Initialize master components - file system manager, server manager, > * assignment manager, region server tracker, etc > * Start necessary service threads - balancer, catalog janior, > * executor services, etc > * Set cluster as UP in ZooKeeper > * Wait for RegionServers to check-in > * Split logs and perform data recovery, if necessary > * Ensure assignment of meta/namespace regions > * Handle either fresh cluster start or master failover > * > * > * @throws IOException > * @throws InterruptedException > * @throws KeeperException > * @throws CoordinatedStateException > */ > private void finishActiveMasterInitialization(MonitoredTask status) > {code} > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)