[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-26 Thread Zach York (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827324#comment-16827324
 ] 

Zach York commented on HBASE-22291:
---

Thanks [~apurtell]!

> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-26 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826874#comment-16826874
 ] 

Hudson commented on HBASE-22291:


Results for branch branch-2
[build #1848 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1848/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1848//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1848//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1848//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-26 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826761#comment-16826761
 ] 

Hudson commented on HBASE-22291:


Results for branch branch-2.1
[build #1087 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1087/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1087//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1087//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1087//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-26 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826752#comment-16826752
 ] 

Hudson commented on HBASE-22291:


Results for branch master
[build #963 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/963/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/963//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/963//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/963//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-26 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826663#comment-16826663
 ] 

Hudson commented on HBASE-22291:


Results for branch branch-1
[build #792 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/792/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/792//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/792//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/792//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826657#comment-16826657
 ] 

Hudson commented on HBASE-22291:


Results for branch branch-1.4
[build #766 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/766/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/766//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/766//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/766//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826643#comment-16826643
 ] 

Hudson commented on HBASE-22291:


Results for branch branch-1.3
[build #741 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/741/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/741//General_Nightly_Build_Report/]


(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/741//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/741//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-25 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826603#comment-16826603
 ] 

Hudson commented on HBASE-22291:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #546 (See 
[https://builds.apache.org/job/HBase-1.3-IT/546/])
HBASE-22291 Fix recovery of recovered.edits files under root dir (apurtell: 
[https://github.com/apache/hbase/commit/0153872b3679ac791288c76c06bd73a98d20f0f1])
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 1.4.10, 2.3.0, 2.1.5, 2.2.1, 1.3.5
>
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-25 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826558#comment-16826558
 ] 

Andrew Purtell commented on HBASE-22291:


I've got a minute, let me try to commit this after some local checks

> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-24 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825510#comment-16825510
 ] 

Andrew Purtell commented on HBASE-22291:


+1

 

> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-23 Thread HBase QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824767#comment-16824767
 ] 

HBase QA commented on HBASE-22291:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
23s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
27s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
8m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}136m 
51s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
29s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}176m 21s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/164/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22291 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12966821/HBASE-22291.master.002.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 92e13979b750 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fe7cf10272 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/164/testReport/ |
| Max. process+thread count | 4969 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/164/console |
| 

[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-23 Thread Zach York (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824679#comment-16824679
 ] 

Zach York commented on HBASE-22291:
---

The test failures doesn't seem related and it passes locally.

> Fix recovery of recovered.edits files under root dir
> 
>
> Key: HBASE-22291
> URL: https://issues.apache.org/jira/browse/HBASE-22291
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 1.4.9
>Reporter: Zach York
>Assignee: Zach York
>Priority: Major
> Attachments: HBASE-22291.branch-1.001.patch, 
> HBASE-22291.master.001.patch, HBASE-22291.master.002.patch
>
>
> It looks like a few places are using incorrect FS instances in the 
> replayRecoveredEditsForPath method that was introduced in HBASE-20734.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (HBASE-22291) Fix recovery of recovered.edits files under root dir

2019-04-22 Thread HBase QA (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-22291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823628#comment-16823628
 ] 

HBase QA commented on HBASE-22291:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
54s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
35s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
39s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
22s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
42s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} branch-1 passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
36s{color} | {color:green} branch-1 passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  2m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}  
1m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed with JDK v1.8.0_202 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed with JDK v1.7.0_211 {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}103m 24s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}128m 58s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.TestAssignmentManagerOnCluster |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/150/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22291 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/1294/HBASE-22291.branch-1.001.patch