subject:"\[jira\] \[Commented\] \(HBASE\-22411\) Refactor codes of moving reigons in RSGroup"

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-06-16 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865232#comment-16865232
 ] 

Xiaolin Ha commented on HBASE-22411:


In moveTable(), if target group is null, the table will be moved from its 
source group info, and then updated to meta, zk and cache.
This is used in postDeleteTable(). 

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22411.branch-2.001.patch, 
> HBASE-22411.branch-2.2.001.patch, HBASE-22411.master.001.patch, 
> HBASE-22411.master.002.patch, HBASE-22411.master.003.patch, 
> HBASE-22411.master.004.patch, HBASE-22411.master.005.patch, 
> HBASE-22411.master.006.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.008.patch, 
> HBASE-22411.master.009.patch, HBASE-22411.master.010.patch, 
> HBASE-22411.master.011.patch, HBASE-22411.master.012.patch, 
> HBASE-22411.master.013.patch, HBASE-22411.master.014.patch, 
> HBASE-22411.master.015.patch, HBASE-22411.master.016.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851047#comment-16851047
 ] 

Hudson commented on HBASE-22411:


Results for branch branch-2.2
[build #304 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/304/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/304//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/304//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/304//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/304//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22411.branch-2.001.patch, 
> HBASE-22411.branch-2.2.001.patch, HBASE-22411.master.001.patch, 
> HBASE-22411.master.002.patch, HBASE-22411.master.003.patch, 
> HBASE-22411.master.004.patch, HBASE-22411.master.005.patch, 
> HBASE-22411.master.006.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.008.patch, 
> HBASE-22411.master.009.patch, HBASE-22411.master.010.patch, 
> HBASE-22411.master.011.patch, HBASE-22411.master.012.patch, 
> HBASE-22411.master.013.patch, HBASE-22411.master.014.patch, 
> HBASE-22411.master.015.patch, HBASE-22411.master.016.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851024#comment-16851024
 ] 

Hudson commented on HBASE-22411:


Results for branch branch-2
[build #1936 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1936/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1936//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1936//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1936//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1936//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22411.branch-2.001.patch, 
> HBASE-22411.branch-2.2.001.patch, HBASE-22411.master.001.patch, 
> HBASE-22411.master.002.patch, HBASE-22411.master.003.patch, 
> HBASE-22411.master.004.patch, HBASE-22411.master.005.patch, 
> HBASE-22411.master.006.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.008.patch, 
> HBASE-22411.master.009.patch, HBASE-22411.master.010.patch, 
> HBASE-22411.master.011.patch, HBASE-22411.master.012.patch, 
> HBASE-22411.master.013.patch, HBASE-22411.master.014.patch, 
> HBASE-22411.master.015.patch, HBASE-22411.master.016.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-29 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850765#comment-16850765
 ] 

Hudson commented on HBASE-22411:


Results for branch master
[build #1054 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1054/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1054//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1054//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1054//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1054//artifact/output-integration/hadoop-3.log].
 (note that this means we didn't check the Hadoop 3 shaded client)


> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0
>
> Attachments: HBASE-22411.branch-2.001.patch, 
> HBASE-22411.branch-2.2.001.patch, HBASE-22411.master.001.patch, 
> HBASE-22411.master.002.patch, HBASE-22411.master.003.patch, 
> HBASE-22411.master.004.patch, HBASE-22411.master.005.patch, 
> HBASE-22411.master.006.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.008.patch, 
> HBASE-22411.master.009.patch, HBASE-22411.master.010.patch, 
> HBASE-22411.master.011.patch, HBASE-22411.master.012.patch, 
> HBASE-22411.master.013.patch, HBASE-22411.master.014.patch, 
> HBASE-22411.master.015.patch, HBASE-22411.master.016.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850406#comment-16850406
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
33s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
24s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
26s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
18m 13s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  7m 
19s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 34s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/441/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12970099/HBASE-22411.branch-2.001.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 3e3f8ebc5354 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 4f05b22880 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/441/testReport/ |
| Max. process+thread count | 4365 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://build

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849600#comment-16849600
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
26s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
16s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 11s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  6m 
47s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/435/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12970024/HBASE-22411.master.016.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux cf8208cef666 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 97090560a5 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/435/testReport/ |
| Max. process+thread count | 4464 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job/PreCommi

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849564#comment-16849564
 ] 

Guanghao Zhang commented on HBASE-22411:


+1 for 016 patch.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch, 
> HBASE-22411.master.012.patch, HBASE-22411.master.013.patch, 
> HBASE-22411.master.014.patch, HBASE-22411.master.015.patch, 
> HBASE-22411.master.016.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849561#comment-16849561
 ] 

Xiaolin Ha commented on HBASE-22411:


Added null check of 'targetGroup' in moveTables(). 
I'll find out what happens when target group is null.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch, 
> HBASE-22411.master.012.patch, HBASE-22411.master.013.patch, 
> HBASE-22411.master.014.patch, HBASE-22411.master.015.patch, 
> HBASE-22411.master.016.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849470#comment-16849470
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
48s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
43s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 52s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m  
8s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m  6s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/434/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969984/HBASE-22411.master.015.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux bf430c585afc 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1c1638f698 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/434/testReport/ |
| Max. process+thread count | 3986 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849464#comment-16849464
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
31s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
40s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
40s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 26s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 
17s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/433/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969984/HBASE-22411.master.015.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e345e0105b64 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1c1638f698 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/433/testReport/ |
| Max. process+thread count | 3988 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849417#comment-16849417
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
40s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
12s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 2 unchanged 
- 0 fixed = 3 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
38s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 
58s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 33s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/431/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969970/HBASE-22411.master.013.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 6a9413421888 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 1c1638f698 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/431/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommi

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-28 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849412#comment-16849412
 ] 

Xiaolin Ha commented on HBASE-22411:


Changed log format.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch, 
> HBASE-22411.master.012.patch, HBASE-22411.master.013.patch, 
> HBASE-22411.master.014.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-27 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849376#comment-16849376
 ] 

Xiaolin Ha commented on HBASE-22411:


Renamed confusing methods, and simplify move methods.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch, 
> HBASE-22411.master.012.patch, HBASE-22411.master.013.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-27 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848748#comment-16848748
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
50s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
44s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 46s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  5m 
43s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/423/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969862/HBASE-22411.master.012.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 96a95a17a943 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 998b8416ca |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/423/testReport/ |
| Max. process+thread count | 4411 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-27 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848716#comment-16848716
 ] 

Xiaolin Ha commented on HBASE-22411:


Used Optional instead of null check, and has replied on the review board. 
[~zghaobac]

This method name is moveRegionsToServers. But the servers may be null? It 
is weird...

I think 'to server' is confusing here. Because in rsgroup moving region 
oprerations, target server is always null.
And in this method, the server set is part of the target group servers. 
Actually regions will be moved to the target group servers, not only these 
servers.

The targetGroup may be null in old implmenation?

'targetGroup' is a passed in parameter, and has checked if it is null in front 
codes.
I think 'targetGroup' won't be null here.



> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch, 
> HBASE-22411.master.012.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-26 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848585#comment-16848585
 ] 

Xiaolin Ha commented on HBASE-22411:


Uploaded to the review board, see at: https://reviews.apache.org/r/70638/

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-26 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848574#comment-16848574
 ] 

Guanghao Zhang commented on HBASE-22411:


Upload the 011 patch to review board?

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-26 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848566#comment-16848566
 ] 

Xiaolin Ha commented on HBASE-22411:


Can this patch be committed? Solving HBASE-22424 needs this patch.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch, 
> HBASE-22411.master.010.patch, HBASE-22411.master.011.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-24 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847405#comment-16847405
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
30s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
39s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 19s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
58s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 44s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/414/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969606/HBASE-22411.master.011.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 1c69eb7ae9d4 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon Sep 
24 17:14:57 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96d2aabfad |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/414/testReport/ |
| Max. process+thread count | 4472 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-24 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847296#comment-16847296
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
39s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
27s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 39s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 
57s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 54m 35s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/413/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969588/HBASE-22411.master.010.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 6b3711c64223 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 96d2aabfad |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/413/testReport/ |
| Max. process+thread count | 4428 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job/PreCommi

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847262#comment-16847262
 ] 

Xiaolin Ha commented on HBASE-22411:


OK，I‘ll change it back.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847238#comment-16847238
 ] 

HBase QA commented on HBASE-22411:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
25s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
26s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
18m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 
37s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
13s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 12s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/412/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969584/HBASE-22411.master.009.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 60466c9b67c9 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / de579cd243 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/412/testReport/ |
| Max. process+thread count | 4398 (vs. ulimit of 1) |
| modules | C: hbase-rsgroup U: hbase-rsgroup |
| Console output | 
https://builds.apache.org/job/PreCom

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847237#comment-16847237
 ] 

Guanghao Zhang commented on HBASE-22411:


After read the patch, I thought the old name "moveRegionsToServers" is better 
to understand..

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847207#comment-16847207
 ] 

Xiaolin Ha commented on HBASE-22411:


fixed checkstyle

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch, HBASE-22411.master.009.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847205#comment-16847205
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
12s{color} | {color:red} hbase-rsgroup: The patch generated 1 new + 2 unchanged 
- 0 fixed = 3 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
27s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  6m 
56s{color} | {color:green} hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 6s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 10s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/409/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969575/HBASE-22411.master.008.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux fae81591f7b0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / de579cd243 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/409/artifact/patchprocess/diff-checkstyle-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-B

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847189#comment-16847189
 ] 

Xiaolin Ha commented on HBASE-22411:


Patch resubmitted after Jenkins running shells was fixed in HBASE-22462.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.007.patch, HBASE-22411.master.007.patch, 
> HBASE-22411.master.008.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-23 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846756#comment-16846756
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
30s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
28s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 35s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 54m  0s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupsBasics |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
|   | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/400/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969498/HBASE-22411.master.007.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux fb82bfc41289 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6b899ccbbc |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-22 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846426#comment-16846426
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
43s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
26s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
22m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 39s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 57s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
|   | hadoop.hbase.rsgroup.TestRSGroupsBasics |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/393/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969463/HBASE-22411.master.007.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux b001f91a596c 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f1a8aa4fd7 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8b

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-22 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846383#comment-16846383
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
29s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
26s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m  7s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 13s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
|   | hadoop.hbase.rsgroup.TestRSGroupsBasics |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/389/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969457/HBASE-22411.master.007.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 3aed4b21457e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8e47c8e739 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-22 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845853#comment-16845853
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
51s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
40s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 52s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  5m  
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}161m 
57s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 23m 17s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
45s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}239m 50s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
|   | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupsBasics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/382/artifact/patchprocess/

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-22 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845629#comment-16845629
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
59s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
42s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
27s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
18m 20s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 35s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 47s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsBasics |
|   | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/380/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969362/HBASE-22411.master.006.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 108ddf713234 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-21 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845586#comment-16845586
 ] 

Guanghao Zhang commented on HBASE-22411:


Attach one line change for HBase QA.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch, HBASE-22411.master.004.patch, 
> HBASE-22411.master.005.patch, HBASE-22411.master.006.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-21 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845511#comment-16845511
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
 5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
 0s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} hbase-rsgroup: The patch generated 0 new + 0 
unchanged - 2 fixed = 0 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  6m 
 4s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
23m 29s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 26s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
11s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 74m 45s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupsBasics |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/377/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969340/HBASE-22411.master.005.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 123c8119227e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 U

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-21 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844645#comment-16844645
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
46s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
47s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 37s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 12s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
|   | hadoop.hbase.rsgroup.TestRSGroupsWithACL |
|   | hadoop.hbase.rsgroup.TestRSGroupsBasics |
|   | hadoop.hbase.rsgroup.TestRSGroupMajorCompactionTTL |
|   | hadoop.hbase.rsgroup.TestRSGroupsBalance |
|   | hadoop.hbase.rsgroup.TestRSGroupsOfflineMode |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin1 |
|   | hadoop.hbase.rsgroup.TestRSGroupsKillRS |
|   | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/369/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969238/HBASE-22411.master.004.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 76f2bb88663d 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Person

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1681#comment-1681
 ] 

Xiaolin Ha commented on HBASE-22411:


Patch for branch-2.2 contains formatting change, which I have delete for master 
branch.
Looks the regionservers for mini cluster didn't startup, I will dig more.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844433#comment-16844433
 ] 

Guanghao Zhang commented on HBASE-22411:


[~Xiaolin Ha] Seems the ut failed again?

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843838#comment-16843838
 ] 

Guanghao Zhang commented on HBASE-22411:


Why branch-2.2 patch is bigger than the patch for master?

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread Guanghao Zhang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843833#comment-16843833
 ] 

Guanghao Zhang commented on HBASE-22411:


[~Xiaolin Ha] You can reattach the patch to rerun the HADOOP QA. And you have 
permission to click "submit patch" button to change the Jira state to PATCH 
AVAILABLE...

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch, 
> HBASE-22411.master.003.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843812#comment-16843812
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
29s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
30s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
16m 18s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m  2s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
10s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 32s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/364/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969132/HBASE-22411.master.003.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 9904f0c56d5d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c80f2ad276 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/364/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.org/job/Pr

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843785#comment-16843785
 ] 

Xiaolin Ha commented on HBASE-22411:


Failure can not be reproduced on my PC, I have tried several times. 
Resubmit and try again.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch, HBASE-22411.master.002.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-20 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843762#comment-16843762
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
49s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 36s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m  0s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 48m 43s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/362/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12969127/HBASE-22411.master.002.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 4bdb02ba6754 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c80f2ad276 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/362/artifact/patchprocess/patch-unit-hbase-rsgroup.txt
 |
|  Test Results | 
https://builds.apache.o

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-19 Thread HBase QA (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843689#comment-16843689
 ] 

HBase QA commented on HBASE-22411:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
41s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
11s{color} | {color:red} hbase-rsgroup: The patch generated 2 new + 2 unchanged 
- 0 fixed = 4 total (was 2) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
37s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
17m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m  0s{color} 
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 13s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.rsgroup.TestEnableRSGroups |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/360/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-22411 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12968860/HBASE-22411.master.001.patch
 |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 3de22c2c3cc0 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c80f2ad276 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/360/artifact/patchprocess/diff-chec

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-19 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843576#comment-16843576
 ] 

Xiaolin Ha commented on HBASE-22411:


[~zghaobac] , could you help review the codes and make the Jira state as 'patch 
available' ?  [~xucang] has reviewed and thinks fine.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch, 
> HBASE-22411.master.001.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-15 Thread Xu Cang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840612#comment-16840612
 ] 

Xu Cang commented on HBASE-22411:
-

I read through the patch. Looks fine to me.

Please re-submit the patch and mark the Jira state as 'patch available' and let 
Hadoop-QA trigger the build and testing. Thanks

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-15 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840116#comment-16840116
 ] 

Xiaolin Ha commented on HBASE-22411:


[~apurtell] [~xucang] Could you review the diff codes?

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-14 Thread Xiaolin Ha (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839919#comment-16839919
 ] 

Xiaolin Ha commented on HBASE-22411:


No. Also contains changes of bulk move regions, and some docs I think 
uncertainty.

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-22411) Refactor codes of moving reigons in RSGroup

2019-05-14 Thread Xu Cang (JIRA)



[ 
https://issues.apache.org/jira/browse/HBASE-22411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839671#comment-16839671
 ] 

Xu Cang commented on HBASE-22411:
-

Is this formatting change only? Thanks. 

> Refactor codes of moving reigons in RSGroup
> ---
>
> Key: HBASE-22411
> URL: https://issues.apache.org/jira/browse/HBASE-22411
> Project: HBase
>  Issue Type: Improvement
>  Components: rsgroup
>Affects Versions: 2.2.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Attachments: HBASE-22411.branch-2.2.001.patch
>
>
> Essentially RSGroup managed regions. Organizing tables or servers' RSGroups 
> is to move relevant regions. Codes of moving regions can be refactored.
> So that some problems caused by moving regions can be fixed elegantly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

47 matches

Mail list logo