[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868339#comment-16868339
]
Hudson commented on HBASE-22596:
Results for branch master
[build #1159 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1159/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1159//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1159//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1159//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868328#comment-16868328
]
Hudson commented on HBASE-22596:
Results for branch branch-2.2
[build #379 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/379/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/379//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/379//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/379//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868321#comment-16868321
]
Hudson commented on HBASE-22596:
Results for branch branch-2.1
[build #1286 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1286/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1286//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1286//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1286//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868299#comment-16868299
]
Hudson commented on HBASE-22596:
Results for branch branch-2
[build #2013 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2013/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2013//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2013//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2013//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868275#comment-16868275
]
Hudson commented on HBASE-22596:
Results for branch branch-1
[build #906 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/906/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/906//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/906//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/906//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868229#comment-16868229
]
Hudson commented on HBASE-22596:
Results for branch branch-1.4
[build #863 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/863/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/863//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/863//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/863//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.4.11
>
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868216#comment-16868216
]
Reid Chan commented on HBASE-22596:
---
Thanks all!
Pushed to branch-1, branch-1.4, branch-2, branch-2.1, branch-2.2, master.
BTW, i filed a documentation issue HBASE-22609.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868122#comment-16868122
]
Xu Cang commented on HBASE-22596:
-
+1
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867182#comment-16867182
]
Reid Chan commented on HBASE-22596:
---
bq. all of them still share the same core service with only one thread.
Yeah, at the beginning. It will spawn a new thread if
{{ChoreService#onChoreMissedStartTime}}.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867040#comment-16867040
]
Zach York commented on HBASE-22596:
---
Otherwise, the change looks good. +1 from me.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867036#comment-16867036
]
Zach York commented on HBASE-22596:
---
The other consideration is that looking at the code it appears all of them
still share the same core service with only one thread. So even if you change
the wake threshold it appears that it would be possible for one of these chores
to monopolize the time.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866285#comment-16866285
]
HBase QA commented on HBASE-22596:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
19s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
24s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}134m
51s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}181m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/551/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22596 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972034/HBASE-22596.master.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux dcdd26d46af4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 5da5deb59d |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/551/testReport/ |
| Max. process+thread count | 4751 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/551/console
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866187#comment-16866187
]
Reid Chan commented on HBASE-22596:
---
Patch for master branch.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
> Attachments: HBASE-22596.master.001.patch
>
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865706#comment-16865706
]
Reid Chan commented on HBASE-22596:
---
After reviewed, will forward-port master branch and branch-2.
Then i will file a documentation JIRA about this!
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865705#comment-16865705
]
Reid Chan commented on HBASE-22596:
---
Created a PR in Github, against branch-1.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22596) [Chore] Separate the execution period between CompactionChecker and PeriodicMemStoreFlusher
[
https://issues.apache.org/jira/browse/HBASE-22596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865308#comment-16865308
]
Reid Chan commented on HBASE-22596:
---
It affects all version, i will target branch-1 first.
> [Chore] Separate the execution period between CompactionChecker and
> PeriodicMemStoreFlusher
> ---
>
> Key: HBASE-22596
> URL: https://issues.apache.org/jira/browse/HBASE-22596
> Project: HBase
> Issue Type: Improvement
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Minor
>
> The story started at tuning RS performance where I found:
> {code}
> public static final String THREAD_WAKE_FREQUENCY =
> "hbase.server.thread.wakefrequency";
> ...
> this.threadWakeFrequency = conf.getInt(HConstants.THREAD_WAKE_FREQUENCY, 10 *
> 1000);
> ...
> this.compactionChecker = new CompactionChecker(this,
> this.threadWakeFrequency, this);
> this.periodicFlusher = new PeriodicMemStoreFlusher(this.threadWakeFrequency,
> this);
> {code}
> CompactionChecker and PeriodicMemStoreFlusher execution period are bound
> together. (as well as LeaseChecker)
> This issue is going to introduce two new parameters such that user/admin can
> tune them according to business workload.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
