[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947185#comment-16947185
]
Hudson commented on HBASE-23116:
Results for branch branch-1.4
[build #1049 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1049/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1049//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1049//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/1049//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945063#comment-16945063
]
Hudson commented on HBASE-23116:
Results for branch master
[build #1494 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1494/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1494//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1494//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1494//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945035#comment-16945035
]
Hudson commented on HBASE-23116:
Results for branch branch-1
[build #1096 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1096/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1096//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1096//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1096//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944990#comment-16944990
]
Hudson commented on HBASE-23116:
Results for branch branch-2.1
[build #1662 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1662/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1662//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1662//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1662//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944946#comment-16944946
]
HBase QA commented on HBASE-23116:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
10s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} branch-1 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} branch-1 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
14s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} branch-1 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} branch-1 passed with JDK v1.7.0_232 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
0s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
56s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
6s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
5m 9s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}119m
16s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
26s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944918#comment-16944918
]
Hudson commented on HBASE-23116:
Results for branch branch-2
[build #2312 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2312/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2312//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2312//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2312//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944898#comment-16944898
]
Hudson commented on HBASE-23116:
Results for branch branch-2.2
[build #651 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/651/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/651//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/651//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/651//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944883#comment-16944883
]
Andrew Kyle Purtell commented on HBASE-23116:
-
I was thinking of doing the same thing as you have in #689, leave the test
alone, but you have also improved it a little, so I approved and merged the PR.
Thanks [~bharathv] . Picked to branch-1.4. Does not apply to branch-1.3
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944880#comment-16944880
]
Bharath Vissapragada commented on HBASE-23116:
--
I see what you are saying. It is annoying for an RM if things keep getting
piled up in the last minute. Anyway, I've subscribed to the dev list and I'll
keep an eye on things going forward.
Coming to the back port, like you said, it appears there are some non-trivial
changes to ClusterStatus. I don't have much context of those, so I've created a
slightly pared down patch that passes the tests. Here it is if you can take a
look. Thanks. https://github.com/apache/hbase/pull/689
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944860#comment-16944860
]
Andrew Kyle Purtell commented on HBASE-23116:
-
To clarify, this isn't a blocker per se but since you are basically ready to
commit I will wait a day.
Lars and I were discussing issues related to releasing and I want to point out
this an example of the kind of thing that can delay.
Strictly speaking, I don't need to wait, but would like to wait, to be
collegial.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944847#comment-16944847
]
Andrew Kyle Purtell commented on HBASE-23116:
-
I announced on dev@ that an RC would happen today. Its fine that you didn't
know about this communication channel [~bharathv] but nonetheless here we are.
I will wait until Monday. Please provide a backport. /cc [~larsh]
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944846#comment-16944846
]
Andrew Kyle Purtell commented on HBASE-23116:
-
Nontrivial backport due to test changes (ClusterStatus differences), may drop
them, let's see.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944845#comment-16944845
]
Bharath Vissapragada commented on HBASE-23116:
--
[~apurtell] I was planning to backport it later today. Sorry, I didn't know
this was blocking an RC.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944844#comment-16944844
]
HBase QA commented on HBASE-23116:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
3s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 33s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}307m 57s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}365m 17s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestSnapshotCloneIndependence |
| | hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable |
| | hadoop.hbase.master.TestSplitWALManager |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.TestAsyncTableAdminApi |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.2 Server=19.03.2 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/687 |
| JIRA Issue | HBASE-23116 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 3210a8a8ed2d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944837#comment-16944837
]
Andrew Kyle Purtell commented on HBASE-23116:
-
Answering my own question - I am doing the backport now. Trying to get 1.5.0 RC
out.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944836#comment-16944836
]
Andrew Kyle Purtell commented on HBASE-23116:
-
There are fix versions for 1.x here but no commits to branch-1s. Is there a
backport in progress?
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.4.10, 2.2.1, 2.1.6
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944335#comment-16944335
]
HBase QA commented on HBASE-23116:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
37s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
39s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
34s{color} | {color:red} hbase-server: The patch generated 2 new + 170
unchanged - 0 fixed = 172 total (was 170) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
39s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 25s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}168m 40s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}237m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-687/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/687 |
| JIRA Issue | HBASE-23116 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 977c3daa96bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-687/out/precommit/personality/provided.sh
|
| git revision | master / 5aa8d3a20b |
| Default Java | 1.8.0_181 |
| checkstyle |
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944217#comment-16944217
]
Bharath Vissapragada commented on HBASE-23116:
--
I've created a PR here [1]. I'm not able to request reviews from specific
reviewers though, maybe my account on github (bharathv) is lacking some
privileges.
[1] https://github.com/apache/hbase/pull/687
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.4.11, 2.2.2, 1.3.7, 2.1.8
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943265#comment-16943265
]
Bharath Vissapragada commented on HBASE-23116:
--
[~apurtell] Thanks. I'll submit a PR for master and will figure out the back
port mechanics to 1.x and 2.x branches.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943264#comment-16943264
]
Andrew Kyle Purtell commented on HBASE-23116:
-
[~bharathv] Have at it! I assigned this to you. I also added you as a
contributor on the project so in the future you can assign issues to yourself.
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23116) LoadBalancer should log table name when balancing per table
[
https://issues.apache.org/jira/browse/HBASE-23116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943263#comment-16943263
]
Bharath Vissapragada commented on HBASE-23116:
--
[~apurtell] I'm new to the HBase project and I'm poking around in the code.
This seems like a newbie task that helps me understand the review process. Can
I assign it to myself?
> LoadBalancer should log table name when balancing per table
> ---
>
> Key: HBASE-23116
> URL: https://issues.apache.org/jira/browse/HBASE-23116
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Priority: Minor
> Fix For: 3.0.0, 1.5.0, 2.3.0, 1.3.6, 1.4.11, 2.1.7, 2.2.2
>
>
> The load balancer logs lines like these:
> {noformat}
> 2019-10-02 23:18:47,664 INFO [46493_ChoreService_6]
> balancer.StochasticLoadBalancer - Skipping load balancing because balanced
> cluster; total cost is 46.68964334022376, sum multiplier is 1087.0 min cost
> which need balance is 0.05
> {noformat}
> When balancing per table it would be useful if the table name was also
> printed in the log line.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
