[jira] [Commented] (HBASE-23639) Moving classes out of hbase-it /test for direct API use of chaos.
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237620#comment-17237620 ] Andrew Kyle Purtell commented on HBASE-23639: - Moving out of 2.4. > Moving classes out of hbase-it /test for direct API use of chaos. > - > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0 > > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23639) Moving classes out of hbase-it /test for direct API use of chaos.
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112073#comment-17112073 ] Viraj Jasani commented on HBASE-23639: -- AssignmentTestingUtil, HBaseZKTestingUtility, MapReduceTestingShim and the most important HBaseCommonTestingUtility is also being moved to src/main/java/ ? Any chance we can avoid these classes? > Moving classes out of hbase-it /test for direct API use of chaos. > - > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0 > > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23639) Moving classes out of hbase-it /test for direct API use of chaos.
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090714#comment-17090714 ] Lokesh Khurana commented on HBASE-23639: [~ndimiduk] I moved the whole hierarchy from root class from test to /src in PR, these classes are mostly parent classes of IntegrationTestingUtility and DistributedHBaseCluster and their dependencies, Can you please take a look. CC: [~apurtell] [~vjasani]. > Moving classes out of hbase-it /test for direct API use of chaos. > - > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.4.0 > > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23639) Moving classes out of hbase-it /test for direct API use of chaos.
[ https://issues.apache.org/jira/browse/HBASE-23639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081836#comment-17081836 ] Lokesh Khurana commented on HBASE-23639: Addressed [~ndimiduk]'s Comments blocked on one question: https://github.com/apache/hbase/pull/1201#discussion_r407216041 > Moving classes out of hbase-it /test for direct API use of chaos. > - > > Key: HBASE-23639 > URL: https://issues.apache.org/jira/browse/HBASE-23639 > Project: HBase > Issue Type: Improvement > Components: API, integration tests, test >Affects Versions: master >Reporter: Mihir Monani >Assignee: Lokesh Khurana >Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.4.0 > > Attachments: HBASE-23639-master.patch > > > In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager > which has some part of implementation code for Chaos Action. > > If any user wants to create private implementation which resembles > HBaseClusterManager, then it has to be merged with hbase-it package as > ClusterManager Interface and it's extended implementations are private. > > We should make them public so anyone can have their own implementation and > need to be merged with hbase-it. -- This message was sent by Atlassian Jira (v8.3.4#803005)