[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-02-17 Thread Sakthi (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038612#comment-17038612
 ] 

Sakthi commented on HBASE-23658:


I think this fix can be backported to branch-1+ as well. This UT has been very 
flakey in those branches as well.

> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-12 Thread Guanghao Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013928#comment-17013928
 ] 

Guanghao Zhang commented on HBASE-23658:


|master.cleaner.TestSnapshotFromMaster|20.0% (6 / 30)|

Not flaky anymore. See 
[https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html].

> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-09 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012357#comment-17012357
 ] 

Hudson commented on HBASE-23658:


Results for branch branch-2
[build #2411 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2411/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2411//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2411//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2411//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-09 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012348#comment-17012348
 ] 

Hudson commented on HBASE-23658:


Results for branch branch-2.2
[build #749 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/749/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/749//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/749//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/749//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-09 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012318#comment-17012318
 ] 

Hudson commented on HBASE-23658:


Results for branch branch-2.1
[build #1767 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1767/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1767//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1767//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1767//JDK8_Nightly_Build_Report_(Hadoop3)/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1767//console].


> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-09 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011855#comment-17011855
 ] 

Hudson commented on HBASE-23658:


Results for branch master
[build #1593 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1593/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1593//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1593//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1593//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9
>
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-09 Thread Guanghao Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011637#comment-17011637
 ] 

Guanghao Zhang commented on HBASE-23658:


Pushed to branch-2.1+. Thanks [~zhangduo] for reviewing.

> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Priority: Major
> Attachments: HBASE-23658.branch-2.2.001.patch
>
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23658) Fix flaky TestSnapshotFromMaster

2020-01-07 Thread Guanghao Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010229#comment-17010229
 ] 

Guanghao Zhang commented on HBASE-23658:


Use waitfor to make the ut more stable.

> Fix flaky TestSnapshotFromMaster
> 
>
> Key: HBASE-23658
> URL: https://issues.apache.org/jira/browse/HBASE-23658
> Project: HBase
>  Issue Type: Bug
>Reporter: Guanghao Zhang
>Priority: Major
>
> testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may 
> fail.
> {code:java}
> assertTrue(master.getSnapshotManager().isTakingAnySnapshot());
> future.get(); // in branch-2.2, here is Thread.sleep
> assertFalse(master.getSnapshotManager().isTakingAnySnapshot());
> {code}
> See 
> [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]
>  
> [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)