[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121087#comment-17121087 ] Hudson commented on HBASE-24479: Results for branch branch-2 [build #2687 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2687/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2687/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2687/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2687/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2687/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} --Failed when running client tests on top of Hadoop 3 using Hadoop's shaded client. [see log for details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2687//artifact/output-integration/hadoop-3-shaded.log]. > Deflake TestCompaction#testStopStartCompaction > -- > > Key: HBASE-24479 > URL: https://issues.apache.org/jira/browse/HBASE-24479 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Labels: compaction > Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0 > > > Saw this in our internal test runs. > {noformat} > org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor.testStopStartCompaction > Failing for the past 1 build (Since Unstable#10 ) > Took 0.72 sec. > add description > Error Message > expected:<1> but was:<0> > Stacktrace > java.lang.AssertionError: expected:<1> but was:<0> > {noformat} > The test asserts can be tightened to improve this. Will follow up with a > patch shortly. HBASE-23899 added some debug logging to figure out why. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121080#comment-17121080 ] Hudson commented on HBASE-24479: Results for branch branch-2.3 [build #116 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/116/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/116/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/116/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/116/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/116/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Deflake TestCompaction#testStopStartCompaction > -- > > Key: HBASE-24479 > URL: https://issues.apache.org/jira/browse/HBASE-24479 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Labels: compaction > Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0 > > > Saw this in our internal test runs. > {noformat} > org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor.testStopStartCompaction > Failing for the past 1 build (Since Unstable#10 ) > Took 0.72 sec. > add description > Error Message > expected:<1> but was:<0> > Stacktrace > java.lang.AssertionError: expected:<1> but was:<0> > {noformat} > The test asserts can be tightened to improve this. Will follow up with a > patch shortly. HBASE-23899 added some debug logging to figure out why. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121041#comment-17121041 ] Hudson commented on HBASE-24479: Results for branch master [build #1743 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1743/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1743/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1600//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1743/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1743/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Deflake TestCompaction#testStopStartCompaction > -- > > Key: HBASE-24479 > URL: https://issues.apache.org/jira/browse/HBASE-24479 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Labels: compaction > Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0 > > > Saw this in our internal test runs. > {noformat} > org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor.testStopStartCompaction > Failing for the past 1 build (Since Unstable#10 ) > Took 0.72 sec. > add description > Error Message > expected:<1> but was:<0> > Stacktrace > java.lang.AssertionError: expected:<1> but was:<0> > {noformat} > The test asserts can be tightened to improve this. Will follow up with a > patch shortly. HBASE-23899 added some debug logging to figure out why. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120841#comment-17120841 ] Hudson commented on HBASE-24479: Results for branch branch-1 [build #1305 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1305/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1305//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1305//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1305//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Deflake TestCompaction#testStopStartCompaction > -- > > Key: HBASE-24479 > URL: https://issues.apache.org/jira/browse/HBASE-24479 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > Labels: compaction > Fix For: 3.0.0-alpha-1, 2.3.0, 1.7.0, 2.4.0 > > > Saw this in our internal test runs. > {noformat} > org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor.testStopStartCompaction > Failing for the past 1 build (Since Unstable#10 ) > Took 0.72 sec. > add description > Error Message > expected:<1> but was:<0> > Stacktrace > java.lang.AssertionError: expected:<1> but was:<0> > {noformat} > The test asserts can be tightened to improve this. Will follow up with a > patch shortly. HBASE-23899 added some debug logging to figure out why. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24479) Deflake TestCompaction#testStopStartCompaction
[ https://issues.apache.org/jira/browse/HBASE-24479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120648#comment-17120648 ] Bharath Vissapragada commented on HBASE-24479: -- I think the test is racy.. (following snippet from branch-1) {noformat} public void testStopStartCompaction() throws IOException { ... thread.requestCompaction(r, store, "test", Store.PRIORITY_USER, new CompactionRequest(), null); -> Add a sleep here and the test fails reliably <-- assertEquals(1, thread.getLongCompactions().getActiveCount() + thread.getShortCompactions() .getActiveCount()); } {noformat} The problem is that the compaction asynchronously finishes before we even poll for the {{activeCount}} > Deflake TestCompaction#testStopStartCompaction > -- > > Key: HBASE-24479 > URL: https://issues.apache.org/jira/browse/HBASE-24479 > Project: HBase > Issue Type: Bug > Components: test >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Bharath Vissapragada >Assignee: Bharath Vissapragada >Priority: Major > > Saw this in our internal test runs. > {noformat} > org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor.testStopStartCompaction > Failing for the past 1 build (Since Unstable#10 ) > Took 0.72 sec. > add description > Error Message > expected:<1> but was:<0> > Stacktrace > java.lang.AssertionError: expected:<1> but was:<0> > {noformat} > The test asserts can be tightened to improve this. Will follow up with a > patch shortly. HBASE-23899 added some debug logging to figure out why. -- This message was sent by Atlassian Jira (v8.3.4#803005)