[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388350#comment-17388350 ] Huaxiang Sun commented on HBASE-24492: -- Correct the release for 2.3 branch, it is in 2.3.3, not 2.3.6. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207727#comment-17207727
]
Hudson commented on HBASE-24492:
Results for branch branch-2.3
[build #74 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/74//console].
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206608#comment-17206608
]
Hudson commented on HBASE-24492:
Results for branch branch-2.2
[build #78 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/78/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/78//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/78//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/78//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/78//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206564#comment-17206564
]
Hudson commented on HBASE-24492:
Results for branch branch-2.3
[build #69 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/69//console].
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125808#comment-17125808
]
Hudson commented on HBASE-24492:
Results for branch branch-1
[build #1308 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1308/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1308//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1308//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1308//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125446#comment-17125446
]
Hudson commented on HBASE-24492:
Results for branch branch-2
[build #2689 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125119#comment-17125119 ] Viraj Jasani commented on HBASE-24492: -- I just looked at branch-1 and this is applicable there also (even though the code is not up-to-date with branch-2). Let me take care of it, and after 2.3.0 is out, will create sub task for backports on all 2.x branches. Thanks > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[
https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125106#comment-17125106
]
Hudson commented on HBASE-24492:
Results for branch master
[build #1746 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1600//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1746/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> ProtobufLogReader.readNext does not need looping
>
>
> Key: HBASE-24492
> URL: https://issues.apache.org/jira/browse/HBASE-24492
> Project: HBase
> Issue Type: Task
> Components: Replication, wal
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> ProtobufLogReader.readNext is using infinite while loop for the whole method,
> however it returns value or throws errors in single execution. while(true)
> was part of initial code and with better improvements in the method, this
> loop has not been removed yet.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125098#comment-17125098 ] Viraj Jasani commented on HBASE-24492: -- Yup, it's committed to master and branch-2 both with Duo's +1. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125094#comment-17125094 ] Michael Stack commented on HBASE-24492: --- [~vjasani] put it on branch-2? > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125088#comment-17125088 ] Viraj Jasani commented on HBASE-24492: -- No worries. Although I am quite certain that it's not going to make any difference execution wise, I am not in favor of putting more burden on one of the cleanest(feature heavy but 0 flakes :) ) upcoming release 2.3. Let me close this Jira. [~zhangduo] maybe I can revisit this for committing to all 2.x branch after releasing 2.3.0. Sounds good to you? > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125076#comment-17125076 ] Nick Dimiduk commented on HBASE-24492: -- Yeah please keep exclude from 2.3, let's avoid tweaking wal code this close to release. Thanks. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125027#comment-17125027 ] Michael Stack commented on HBASE-24492: --- Thanks [~vjasani]for the helpful cleanup. Seems good. Lets NOT include in branch-2.3. I'm being conservative. [~ndimiduk] is running last tests trying to cut an RC. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124743#comment-17124743 ] Viraj Jasani commented on HBASE-24492: -- Let's wait for [~stack]'s confirmation. So far, pushed to master and branch-2. Thanks for the quick review [~zhangduo]. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124695#comment-17124695 ] Viraj Jasani commented on HBASE-24492: -- Thanks [~zhangduo] Exactly the loop is useless and confusing for readers. When I came here, I started searching for howmany times this could loop, ran some tests and then suddenly realized, this is not at all looping. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124691#comment-17124691 ] Duo Zhang commented on HBASE-24492: --- OK, checked the code, there is a 'return true' at the last of the while(true) loop, and there is no continue statement in the middle, so I agree with you that the loop is useless. +1 on removing it. [~stack] I think this could go into all 2.x branches? Just a code clean. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124667#comment-17124667 ] Viraj Jasani commented on HBASE-24492: -- [~zhangduo] The issue is not visible at production level. This is a code improvement I would say. I was going through WAL specific code and stumbled upon ProtobufLogReader.readNext and realized that while(true) is a confusing for any reader. If you look at the code closely, there is no loop happening at all. And I am fine with keeping this till branch-2. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124664#comment-17124664 ] Duo Zhang commented on HBASE-24492: --- Do you hit this in real production? Or can you reproduce the problem through a UT? Otherwise I do not think it is necessary to do this right now? Thanks. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124619#comment-17124619 ] Viraj Jasani commented on HBASE-24492: -- [~stack] sure I am definitely fine with restricting this till branch-2. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124459#comment-17124459 ] Michael Stack commented on HBASE-24492: --- I went back to the cited issue. It was a bit messy in the end. On removing the while, did you hit an infinite retry? We could undo the while but can we not commit on branch-2.3? The RM is running ITBLL verifications and this looks like a candidate for possible data loss (hard to tell but maybe a retry will be skipped if the while is undone). What you reckon [~vjasani]? If good by you I'll do deeper review for branch-2. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124185#comment-17124185 ] Viraj Jasani commented on HBASE-24492: -- Sure [~stack]. The last improvement after which looping is no longer required is HBASE-20604. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value of throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124161#comment-17124161 ] Michael Stack commented on HBASE-24492: --- Can you give more history here please [~vjasani] so we can follow along. Why do we not need the while any more? Thanks. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value of throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
