[jira] [Commented] (HBASE-24957) ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.
[
https://issues.apache.org/jira/browse/HBASE-24957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189343#comment-17189343
]
Rushabh Shah commented on HBASE-24957:
--
Thank you [~vjasani] for review and commit, [~bharathv] for the review.
> ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or
> not.
> --
>
> Key: HBASE-24957
> URL: https://issues.apache.org/jira/browse/HBASE-24957
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.6.0, 1.3.6, 1.7.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.0
>
>
> The following bug exists only in branch-1 and below.
> ZKTableStateClientSideReader#isDisabledTable returns false even if table
> doesn't exists.
> Below is the code snippet:
> {code:title=ZKTableStateClientSideReader.java|borderStyle=solid}
> public static boolean isDisabledTable(final ZooKeeperWatcher zkw,
> final TableName tableName)
> throws KeeperException, InterruptedException {
> ZooKeeperProtos.Table.State state = getTableState(zkw, tableName);
> ---> We should check here if state is null or not.
> return isTableState(ZooKeeperProtos.Table.State.DISABLED, state);
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24957) ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.
[
https://issues.apache.org/jira/browse/HBASE-24957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188593#comment-17188593
]
Hudson commented on HBASE-24957:
Results for branch branch-1
[build #15 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/15/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/15//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/15//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/15//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or
> not.
> --
>
> Key: HBASE-24957
> URL: https://issues.apache.org/jira/browse/HBASE-24957
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.6.0, 1.3.6, 1.7.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.0
>
>
> The following bug exists only in branch-1 and below.
> ZKTableStateClientSideReader#isDisabledTable returns false even if table
> doesn't exists.
> Below is the code snippet:
> {code:title=ZKTableStateClientSideReader.java|borderStyle=solid}
> public static boolean isDisabledTable(final ZooKeeperWatcher zkw,
> final TableName tableName)
> throws KeeperException, InterruptedException {
> ZooKeeperProtos.Table.State state = getTableState(zkw, tableName);
> ---> We should check here if state is null or not.
> return isTableState(ZooKeeperProtos.Table.State.DISABLED, state);
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24957) ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.
[
https://issues.apache.org/jira/browse/HBASE-24957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188262#comment-17188262
]
Viraj Jasani commented on HBASE-24957:
--
Merged changes to branch-1. Thanks for the contribution [~shahrs87].
> ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or
> not.
> --
>
> Key: HBASE-24957
> URL: https://issues.apache.org/jira/browse/HBASE-24957
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.6.0, 1.3.6, 1.7.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.0
>
>
> The following bug exists only in branch-1 and below.
> ZKTableStateClientSideReader#isDisabledTable returns false even if table
> doesn't exists.
> Below is the code snippet:
> {code:title=ZKTableStateClientSideReader.java|borderStyle=solid}
> public static boolean isDisabledTable(final ZooKeeperWatcher zkw,
> final TableName tableName)
> throws KeeperException, InterruptedException {
> ZooKeeperProtos.Table.State state = getTableState(zkw, tableName);
> ---> We should check here if state is null or not.
> return isTableState(ZooKeeperProtos.Table.State.DISABLED, state);
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
