[jira] [Commented] (HBASE-24973) Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner
[
https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190233#comment-17190233
]
Hudson commented on HBASE-24973:
Results for branch branch-2
[build #31 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/31/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/31//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/31//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/31//console].
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/31//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/31//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Remove read point parameter in method StoreFlush#performFlush and
> StoreFlush#createScanner
> --
>
> Key: HBASE-24973
> URL: https://issues.apache.org/jira/browse/HBASE-24973
> Project: HBase
> Issue Type: Improvement
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Currently, read point parameter in method StoreFlush#performFlush is useless
> and can be safely removed.
> and then method StoreFlush#createScanner can also remove this parameter
> See below
> {code:java}
> // Some comments here
> /**
>* Performs memstore flush, writing data from scanner into sink.
>* @param scanner Scanner to get data from.
>* @param sink Sink to write data to. Could be StoreFile.Writer.
>* @param smallestReadPoint Smallest read point used for the flush.
>* @param throughputController A controller to avoid flush too fast
>*/
> protected void performFlush(InternalScanner scanner, CellSink sink,
> long smallestReadPoint, ThroughputController throughputController)
> throws IOException
> {code}
> Parameter smallestReadPoint is not used in this method. When
> `smallestReadPoint` is removed, inner method `createScanner` can remove this
> necessary parameter too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24973) Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner
[
https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189773#comment-17189773
]
Hudson commented on HBASE-24973:
Results for branch master
[build #33 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33//console].
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Remove read point parameter in method StoreFlush#performFlush and
> StoreFlush#createScanner
> --
>
> Key: HBASE-24973
> URL: https://issues.apache.org/jira/browse/HBASE-24973
> Project: HBase
> Issue Type: Improvement
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Currently, read point parameter in method StoreFlush#performFlush is useless
> and can be safely removed.
> and then method StoreFlush#createScanner can also remove this parameter
> See below
> {code:java}
> // Some comments here
> /**
>* Performs memstore flush, writing data from scanner into sink.
>* @param scanner Scanner to get data from.
>* @param sink Sink to write data to. Could be StoreFile.Writer.
>* @param smallestReadPoint Smallest read point used for the flush.
>* @param throughputController A controller to avoid flush too fast
>*/
> protected void performFlush(InternalScanner scanner, CellSink sink,
> long smallestReadPoint, ThroughputController throughputController)
> throws IOException
> {code}
> Parameter smallestReadPoint is not used in this method. When
> `smallestReadPoint` is removed, inner method `createScanner` can remove this
> necessary parameter too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
