[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275681#comment-17275681
 ] 

Hudson commented on HBASE-25533:


Results for branch branch-2
[build #167 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/167/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/167/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/167/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/167/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/167/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275674#comment-17275674
 ] 

Hudson commented on HBASE-25533:


Results for branch branch-2.3
[build #161 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/161/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/161/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/161/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/161/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/161/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275662#comment-17275662
 ] 

Hudson commented on HBASE-25533:


Results for branch branch-1
[build #80 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/80/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/80//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/80//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/80//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275568#comment-17275568
 ] 

Hudson commented on HBASE-25533:


Results for branch master
[build #199 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/199/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/199/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/199/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/199/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-29 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275465#comment-17275465
 ] 

Hudson commented on HBASE-25533:


Results for branch branch-2.4
[build #43 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/43/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/43/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/43/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/43/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/43/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.5.0, 2.3.5, 2.4.2
>
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-28 Thread Baiqiang Zhao (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17274109#comment-17274109
 ] 

Baiqiang Zhao commented on HBASE-25533:
---

Will raise RPs for other branches, thanks [~vjasani]

>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-28 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273438#comment-17273438
 ] 

Viraj Jasani commented on HBASE-25533:
--

If you can raise PRs for branch-2, branch-2.3 and branch-1, that would be great.

Thanks [~DeanZ]

>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-27 Thread Viraj Jasani (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272707#comment-17272707
 ] 

Viraj Jasani commented on HBASE-25533:
--

You are correct in the sense that empty value can cause issues with conversion. 
Thanks for filing this [~DeanZ], will take a look sometime later today or 
tomorrow.

>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HBASE-25533) The metadata of the table and family should not be an empty string

2021-01-26 Thread Baiqiang Zhao (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-25533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272535#comment-17272535
 ] 

Baiqiang Zhao commented on HBASE-25533:
---

My current idea is to remove the metadata if it is set to an empty string, just 
like null. Because empty string is meaningless. And maybe HBCK should support 
to repair this extreme situation. Ping [~stack] [~zhangduo] [~vjasani]

>  The metadata of the table and family should not be an empty string
> ---
>
> Key: HBASE-25533
> URL: https://issues.apache.org/jira/browse/HBASE-25533
> Project: HBase
>  Issue Type: Bug
>Reporter: Baiqiang Zhao
>Assignee: Baiqiang Zhao
>Priority: Major
>
> If the metadata of the table is set to null, the metadata will be removed. 
> The code is:
> [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721]
> But if set metadata as empty string, serious errors may occur. Some metadata 
> is number, 
> it will throw a NumberFormatException when converting empty string to a 
> number. If the exception is thrown when the region is initialized, all 
> regions of the table will be in RIT.
> The following command can reproduced this issue. *Note: Please execute in the 
> test environment.*
> {code:java}
> alter 'test_table', CONFIGURATION => 
> {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''}
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)