[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module
[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17361339#comment-17361339 ] Clara Xiong commented on HBASE-25649: - I see. I do have more pr in the pipeline and other observability pr that I want to back port, backporting every single one seems a lot of overhead. But I see your point there was already another refactoring than this one, may be I will just do a refactoring to align. > Complete the work on moving all the balancer related classes to > hbase-balancer module > - > > Key: HBASE-25649 > URL: https://issues.apache.org/jira/browse/HBASE-25649 > Project: HBase > Issue Type: Umbrella > Components: Balancer >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > This is the follow up issue of HBASE-23933, where we set up the new > hbase-balancer module and moved several classes into it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module
[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17361318#comment-17361318 ] Duo Zhang commented on HBASE-25649: --- [~claraxiong] See HBASE-25947, I've backported the most important performance improvements to branch-2.4 and branch-2.3. And it is already one branch-2. For me, as the main work is based on the previous refactoring of moving rs group related code to hbase-server, which is only done on master branch, so I'm not sure what is the best way to land the refactoring in this issue to branch-2. If you have clear requirements, just go ahead take the backport work. Thanks. > Complete the work on moving all the balancer related classes to > hbase-balancer module > - > > Key: HBASE-25649 > URL: https://issues.apache.org/jira/browse/HBASE-25649 > Project: HBase > Issue Type: Umbrella > Components: Balancer >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > This is the follow up issue of HBASE-23933, where we set up the new > hbase-balancer module and moved several classes into it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module
[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17361303#comment-17361303 ] Clara Xiong commented on HBASE-25649: - Hi [~zhangduo] The refactoring was great. The module in a much better state. May I ask this to be back ported to branch 2? There have been/is to be a few balancer improvements after this work that projects on release 2 will benefit. Without back porting this work, it will become very laborious and risky. If you don't have the time, I will take it. > Complete the work on moving all the balancer related classes to > hbase-balancer module > - > > Key: HBASE-25649 > URL: https://issues.apache.org/jira/browse/HBASE-25649 > Project: HBase > Issue Type: Umbrella > Components: Balancer >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > This is the follow up issue of HBASE-23933, where we set up the new > hbase-balancer module and moved several classes into it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module
[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17354509#comment-17354509 ] Duo Zhang commented on HBASE-25649: --- After reviewing the code for rs group again, I do not think it is worth to force move it to hbase-balancer for now. We have a lot of code for migrating and keeping compatibility, which use a lot of internal stuff of HMaster, so it is not easy to move it hbase-balancer module. We could try to do this again in 4.0.0, when we can remove the migration and compatibility code. Filed HBASE-25953 for this. > Complete the work on moving all the balancer related classes to > hbase-balancer module > - > > Key: HBASE-25649 > URL: https://issues.apache.org/jira/browse/HBASE-25649 > Project: HBase > Issue Type: Umbrella > Components: Balancer >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-1 > > > This is the follow up issue of HBASE-23933, where we set up the new > hbase-balancer module and moved several classes into it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module
[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302228#comment-17302228 ] Michael Stack commented on HBASE-25649: --- Sorry. Late to design. Left a comment. > Complete the work on moving all the balancer related classes to > hbase-balancer module > - > > Key: HBASE-25649 > URL: https://issues.apache.org/jira/browse/HBASE-25649 > Project: HBase > Issue Type: Umbrella > Components: Balancer >Reporter: Duo Zhang >Priority: Major > > This is the follow up issue of HBASE-23933, where we set up the new > hbase-balancer module and moved several classes into it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25649) Complete the work on moving all the balancer related classes to hbase-balancer module
[ https://issues.apache.org/jira/browse/HBASE-25649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297852#comment-17297852 ] Duo Zhang commented on HBASE-25649: --- [~stack] FYI. > Complete the work on moving all the balancer related classes to > hbase-balancer module > - > > Key: HBASE-25649 > URL: https://issues.apache.org/jira/browse/HBASE-25649 > Project: HBase > Issue Type: Umbrella > Components: Balancer >Reporter: Duo Zhang >Priority: Major > > This is the follow up issue of HBASE-23933, where we set up the new > hbase-balancer module and moved several classes into it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
