[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

[Michael Stack (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385941#comment-17385941
 ] 

Michael Stack commented on HBASE-25938:
---

This change was reverted from branch-2.3. Removing 2.3.6 as a fix version.
{code:java}
  
075c055c87 Revert "HBASE-25938 The 
SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer 
is just a dummy one (#3329)"{code}

> The SnapshotOfRegionAssignmentFromMeta.initialize call in 
> FavoredNodeLoadBalancer is just a dummy one
> -
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
>  Issue Type: Bug
>  Components: Balancer, FavoredNodes
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this 
> information every time when balancing, as all the updates to favored nodes 
> will go to FavoredNodesManager and it can update its in memory state 
> accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one 
> in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355601#comment-17355601
 ] 

Hudson commented on HBASE-25938:


Results for branch branch-2.3
[build #229 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/229/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/229/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/229/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/229/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/229/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/229//console].


> The SnapshotOfRegionAssignmentFromMeta.initialize call in 
> FavoredNodeLoadBalancer is just a dummy one
> -
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
>  Issue Type: Bug
>  Components: Balancer, FavoredNodes
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this 
> information every time when balancing, as all the updates to favored nodes 
> will go to FavoredNodesManager and it can update its in memory state 
> accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one 
> in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353912#comment-17353912
 ] 

Hudson commented on HBASE-25938:


Results for branch branch-2.4
[build #130 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/130/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/130/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/130/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/130/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/130/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The SnapshotOfRegionAssignmentFromMeta.initialize call in 
> FavoredNodeLoadBalancer is just a dummy one
> -
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
>  Issue Type: Bug
>  Components: Balancer, FavoredNodes
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this 
> information every time when balancing, as all the updates to favored nodes 
> will go to FavoredNodesManager and it can update its in memory state 
> accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one 
> in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353828#comment-17353828
 ] 

Hudson commented on HBASE-25938:


Results for branch branch-2
[build #264 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The SnapshotOfRegionAssignmentFromMeta.initialize call in 
> FavoredNodeLoadBalancer is just a dummy one
> -
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
>  Issue Type: Bug
>  Components: Balancer, FavoredNodes
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this 
> information every time when balancing, as all the updates to favored nodes 
> will go to FavoredNodesManager and it can update its in memory state 
> accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one 
> in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353756#comment-17353756
 ] 

Hudson commented on HBASE-25938:


Results for branch master
[build #308 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/308/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/308/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/308/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/308/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The SnapshotOfRegionAssignmentFromMeta.initialize call in 
> FavoredNodeLoadBalancer is just a dummy one
> -
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
>  Issue Type: Bug
>  Components: Balancer, FavoredNodes
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this 
> information every time when balancing, as all the updates to favored nodes 
> will go to FavoredNodesManager and it can update its in memory state 
> accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one 
> in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25938) The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353699#comment-17353699
 ] 

Hudson commented on HBASE-25938:


Results for branch branch-2.3
[build #227 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/227/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/227/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/227/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/227/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/227/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/227//console].


> The SnapshotOfRegionAssignmentFromMeta.initialize call in 
> FavoredNodeLoadBalancer is just a dummy one
> -
>
> Key: HBASE-25938
> URL: https://issues.apache.org/jira/browse/HBASE-25938
> Project: HBase
>  Issue Type: Bug
>  Components: Balancer, FavoredNodes
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0, 2.3.6, 2.4.4
>
>
> After we introduced FavoredNodesManager, we do not need to load this 
> information every time when balancing, as all the updates to favored nodes 
> will go to FavoredNodesManager and it can update its in memory state 
> accordingly.
> The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one 
> in FavoredNodeLoadBalancer, as we never use it in the method.
> It will introduce a full scan on hbase:meta so let's just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)