[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547683#comment-17547683 ] Hudson commented on HBASE-27023: Results for branch master [build #602 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/602/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/602/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/602/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Duo Zhang >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17546688#comment-17546688 ] Hudson commented on HBASE-27023: Results for branch branch-2.5 [build #133 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/133/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Duo Zhang >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13 > > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545669#comment-17545669 ] Hudson commented on HBASE-27023: Results for branch branch-2.4 [build #361 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/361/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/361/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/361/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/361/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/361/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3, 2.4.13, 2.5.1 > > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17545641#comment-17545641 ] Hudson commented on HBASE-27023: Results for branch branch-2 [build #556 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/556/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/556/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/556/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/556/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/556/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} -- Something went wrong with this stage, [check relevant console output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/556//console]. > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0-alpha-3, 2.4.13, 2.5.1 > > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535905#comment-17535905 ] Duo Zhang commented on HBASE-27023: --- The files with 'Copyright Google Inc' are hbase-common/src/main/java/org/apache/hadoop/hbase/util/AbstractByteRange.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/SimpleMutableByteRange.java hbase-common/src/main/java/org/apache/hadoop/hbase/util/SimplePositionedMutableByteRange.java The files with 'Copyright Josh' are hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/metrics/impl/HBaseMetrics2HadoopMetricsAdapter.java The files with 'Copyright Martin Kleppmann' are hbase-it/src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCFileReader.java hbase-it/src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCFileWriter.java hbase-it/src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCInputFormat.java hbase-it/src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCOutputFormat.java hbase-it/src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCRecord.java hbase-it/src/test/java/org/apache/hadoop/hbase/test/util/warc/WARCWritable.java Let me see what is the best way to keep the license for these files while spotless is on. > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535901#comment-17535901 ] Duo Zhang commented on HBASE-27023: --- I downloaded the PR for https://github.com/apache/hbase/pull/4312/files Run {code} grep Copyright 4312.diff.txt | grep -v "The Apache Software Foundation" {code} The output is {noformat} - * Copyright 2008 Google Inc. All rights reserved. - * Copyright 2008 Google Inc. All rights reserved. - * Copyright 2008 Google Inc. All rights reserved. - * Copyright 2016 Josh Elser - * Copyright (c) 2014 Martin Kleppmann - * Copyright (c) 2014 Martin Kleppmann - * Copyright (c) 2014 Martin Kleppmann - * Copyright (c) 2014 Martin Kleppmann - * Copyright (c) 2014 Martin Kleppmann - * Copyright (c) 2014 Martin Kleppmann {noformat} {code} grep COPYRIGHT 4312.diff.txt | grep -v "The Apache Software Foundation" {code} The output is {noformat} - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -expectedVisString[3] = "(\"secret\"&\"" + COPYRIGHT + "\\\"" + ACCENT + "" + SECRET +expectedVisString[3] = "(\"secret\"&\"" + COPYRIGHT + "\\\"" + ACCENT + "" + SECRET + "\\\"" public static final String COPYRIGHT = "\u00A9ABC"; - public static final String UNICODE_VIS_TAG = COPYRIGHT + "\"" + ACCENT + "\\" + SECRET + "\"" +COPYRIGHT + "\"" + ACCENT + "\\" + SECRET + "\"" + "\u0027&\\"; -SECRET + "|" + CellVisibility.quote(COPYRIGHT), "(" + CellVisibility.quote(COPYRIGHT) + SECRET + "|" + CellVisibility.quote(COPYRIGHT), "(" + CellVisibility.quote(COPYRIGHT) + "&" - s.setAuthorizations(new Authorizations(SECRET, CONFIDENTIAL, PRIVATE, COPYRIGHT, ACCENT, +new Authorizations(SECRET, CONFIDENTIAL, PRIVATE, COPYRIGHT, ACCENT, UNICODE_VIS_TAG)); -String[] labels = { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE, COPYRIGHT, ACCENT, + String[] labels = { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE, COPYRIGHT, ACCENT, public static final String COPYRIGHT = "\u00A9ABC"; - public static final String UNICODE_VIS_TAG = COPYRIGHT + "\"" + ACCENT + "\\" + SECRET + "\"" +COPYRIGHT + "\"" + ACCENT + "\\" + SECRET + "\"" + "\u0027&\\"; - "(\"secret\"&\"" + COPYRIGHT + "\\\"" + ACCENT + "" + SECRET + "\\\"" + "\u0027&" + "(!\"topsecret\"&\"secret\")|(!\"topsecret\"&\"confidential\")", "(\"secret\"&\"" + COPYRIGHT + // { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE, COPYRIGHT, ACCENT, -// { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE, COPYRIGHT, ACCENT, {noformat} No new findings, 'THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS' and 'A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT' are from the BSD license. {noformat} - * The portion of this file denoted by 'Copied from com.google.protobuf.CodedOutputStream' - * is from Protocol Buffers v2.5.0 under the following license - * - * Copyright 2008 Google Inc. All rights reserved. - * http://code.google.com/p/protobuf/ - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are - * met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above - * copyright notice, this list of conditions and the following disclaimer - * in the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Google Inc. nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535887#comment-17535887 ] Duo Zhang commented on HBASE-27023: --- The license header feature in spotless will do this. Let me see what is the suitable way to solve this. > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535794#comment-17535794 ] Andrew Kyle Purtell commented on HBASE-27023: - Why does spotless remove extra headers? It really nukes the comment? > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534993#comment-17534993 ] Peter Somogyi commented on HBASE-27023: --- Thanks for the details on licensing, [~busbey]! [~zhangduo], do you know what changes would be required to allow additional headers by spotless? > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534983#comment-17534983 ] Sean Busbey commented on HBASE-27023: - any files with a third party notice, yes. > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534952#comment-17534952 ] Duo Zhang commented on HBASE-27023: --- Ah, so then maybe we should exclude this file from spotless, at least when adding license header? > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HBASE-27023) Add protobuf to NOTICE file
[ https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534939#comment-17534939 ] Sean Busbey commented on HBASE-27023: - copying some comments over from the PR. 3-Clause BSD licensed works only get entered into relevant LICENSE files. Our inclusion of protocol buffers source is currently included in the existing LICENSE files. we should add the protobuf credit back to the AbstractByteRange source file in order to remain in compliance with the [ASF policy on third party works included in our project source|https://www.apache.org/legal/src-headers.html#3party]. > Add protobuf to NOTICE file > --- > > Key: HBASE-27023 > URL: https://issues.apache.org/jira/browse/HBASE-27023 > Project: HBase > Issue Type: Task >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Major > > The spotless formatting removed the protobuf credit from the > AbstractByteRange. It is currently not included in the NOTICE file. > https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52 -- This message was sent by Atlassian Jira (v8.20.7#820007)