[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600817#comment-17600817
]
Sean Busbey commented on HBASE-27328:
-
(the enforcer plugin has been marked threadsafe since 1.0.1 and it looks like
the beanshell evaluator is threadsafe.)
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600815#comment-17600815
]
Sean Busbey commented on HBASE-27328:
-
can we reproduce this with a `-X` on maven? the source for the beanshell
evaluation should include the exception that caused the failure:
https://github.com/apache/maven-enforcer/blob/master/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/EvaluateBeanshell.java#L114
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600813#comment-17600813
]
Sean Busbey commented on HBASE-27328:
-
the license validator failing to run should fail the build, because it means
our failsafe on obviously bad license info couldn't run.
the logging situation wrt multithreaded builds is pretty bad, sorry this
particular issue is kind of a nightmare with it. Are we sure both the enforcer
plugin and the plugin we use to run beanshell are threadsafe?
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600314#comment-17600314
]
Nick Dimiduk commented on HBASE-27328:
--
[~busbey] have you seen this one before? Any insight?
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584820#comment-17584820
]
Nick Dimiduk commented on HBASE-27328:
--
And FYI, the artifact called "hbase-shaded-client" has the friendly name
"Apache HBase - Shaded - Client (with Hadoop bundled)"
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584814#comment-17584814
]
Nick Dimiduk commented on HBASE-27328:
--
Okay no, the multi-threaded build is interleaving log lines. I believe this
enforcer rule is the reason that the build fails. Here's the log output with a
bit more context.
{noformat}
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (check-aggregate-license) @
hbase-shaded-client-byo-hadoop ---
[INFO]
[INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @
hbase-shaded-client ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/src/main/resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (check-aggregate-license) @
hbase-shaded-client ---
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
hbase-shaded-client-byo-hadoop ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
with message:
Couldn't evaluate condition: File license = new
File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
// Beanshell does not support try-with-resources,
// so we must close this scanner manually
Scanner scanner = new Scanner(license);
while (scanner.hasNextLine()) {
if (scanner.nextLine().startsWith("ERROR:")) {
scanner.close();
return false;
}
}
scanner.close();
return true;
[INFO] No sources to compile
{noformat}
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584807#comment-17584807
]
Nick Dimiduk commented on HBASE-27328:
--
Err, no. {{hbase-shaded-client-byo-hadoop}} is not the same as {{Apache HBase -
Shaded - Client (with Hadoop bundled)}}. Why does this build fail then?
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27328) Enforcer phase EvaluateBeanShell fails occasionally
[
https://issues.apache.org/jira/browse/HBASE-27328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584804#comment-17584804
]
Nick Dimiduk commented on HBASE-27328:
--
Despite the logged message being at WARN level, from the reactor summary, it
appears that this expression evaluation is the cause of the failure.
{noformat}
[INFO] Apache HBase - Shaded - Client (with Hadoop bundled) FAILURE [ 1.074 s]
{noformat}
> Enforcer phase EvaluateBeanShell fails occasionally
> ---
>
> Key: HBASE-27328
> URL: https://issues.apache.org/jira/browse/HBASE-27328
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Nick Dimiduk
>Priority: Major
>
> For example, from
> https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @
> hbase-shaded-client-byo-hadoop ---
> [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed
> with message:
> Couldn't evaluate condition: File license = new
> File("/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE");
> // Beanshell does not support try-with-resources,
> // so we must close this scanner manually
> Scanner scanner = new Scanner(license);
> while (scanner.hasNextLine()) {
> if (scanner.nextLine().startsWith("ERROR:")) {
> scanner.close();
> return false;
> }
> }
> scanner.close();
> return true;
> [INFO] No sources to compile
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
