[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629535#comment-17629535
]
Hudson commented on HBASE-27414:
Results for branch branch-2.5
[build #239 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/239/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Search order for locations in HFileLink
>
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Reporter: Huaxiang Sun
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Found that search order for locations is following the order of these
> locations added to HFileLink object.
>
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in
> archivePath, so we can move archivePath to the first parameter to avoid
> unnecessary NN query.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629532#comment-17629532
]
Hudson commented on HBASE-27414:
Results for branch master
[build #715 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/715/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Search order for locations in HFileLink
>
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Reporter: Huaxiang Sun
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Found that search order for locations is following the order of these
> locations added to HFileLink object.
>
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in
> archivePath, so we can move archivePath to the first parameter to avoid
> unnecessary NN query.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629417#comment-17629417
]
Hudson commented on HBASE-27414:
Results for branch branch-2
[build #674 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/674/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/674/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/674/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/674/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/674/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Search order for locations in HFileLink
>
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Reporter: Huaxiang Sun
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Found that search order for locations is following the order of these
> locations added to HFileLink object.
>
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in
> archivePath, so we can move archivePath to the first parameter to avoid
> unnecessary NN query.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629415#comment-17629415
]
Hudson commented on HBASE-27414:
Results for branch branch-2.4
[build #453 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/453/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/453/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/453/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/453/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/453/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Search order for locations in HFileLink
>
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Reporter: Huaxiang Sun
>Assignee: ruanhui
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.2, 2.4.16
>
>
> Found that search order for locations is following the order of these
> locations added to HFileLink object.
>
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in
> archivePath, so we can move archivePath to the first parameter to avoid
> unnecessary NN query.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[
https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629332#comment-17629332
]
Duo Zhang commented on HBASE-27414:
---
{quote}
Looking at the PR, it is odd the way the dir order is flipped without comment.
There could have been evidence or a thinking behind the change but it is lost
now.
{quote}
Thanks for confirmation.
{quote}
Agree to flip it back and move on.
{quote}
Yes sir. Let me help merging the PR.
> Search order for locations in HFileLink
>
>
> Key: HBASE-27414
> URL: https://issues.apache.org/jira/browse/HBASE-27414
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Reporter: Huaxiang Sun
>Priority: Minor
>
> Found that search order for locations is following the order of these
> locations added to HFileLink object.
>
> setLocations(originPath, tempPath, mobPath, archivePath);
> archivePath is the last one to be searched. For most cases, hfile exists in
> archivePath, so we can move archivePath to the first parameter to avoid
> unnecessary NN query.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17629073#comment-17629073 ] Michael Stack commented on HBASE-27414: --- Looking at the PR, it is odd the way the dir order is flipped without comment. There could have been evidence or a thinking behind the change but it is lost now. Agree to flip it back and move on. > Search order for locations in HFileLink > > > Key: HBASE-27414 > URL: https://issues.apache.org/jira/browse/HBASE-27414 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Huaxiang Sun >Priority: Minor > > Found that search order for locations is following the order of these > locations added to HFileLink object. > > setLocations(originPath, tempPath, mobPath, archivePath); > archivePath is the last one to be searched. For most cases, hfile exists in > archivePath, so we can move archivePath to the first parameter to avoid > unnecessary NN query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628994#comment-17628994 ] Duo Zhang commented on HBASE-27414: --- I'm not sure about the review and commit workflow at that time... [~jmhsieh] [~stack] Do you guys still remember something? For me, I guess it should be a typo while cherry-picking? Thanks. > Search order for locations in HFileLink > > > Key: HBASE-27414 > URL: https://issues.apache.org/jira/browse/HBASE-27414 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Huaxiang Sun >Priority: Minor > > Found that search order for locations is following the order of these > locations added to HFileLink object. > > setLocations(originPath, tempPath, mobPath, archivePath); > archivePath is the last one to be searched. For most cases, hfile exists in > archivePath, so we can move archivePath to the first parameter to avoid > unnecessary NN query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628989#comment-17628989 ] Duo Zhang commented on HBASE-27414: --- The order is changed in this commit https://github.com/apache/hbase/commit/f70ed5ab6de7cc71592a1714c9a3cc03b115c7fd The commit message said it is for HBASE-7583, but checking the uploaded patch for HBASE-7593, we did not touch HFileLink... > Search order for locations in HFileLink > > > Key: HBASE-27414 > URL: https://issues.apache.org/jira/browse/HBASE-27414 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Huaxiang Sun >Priority: Minor > > Found that search order for locations is following the order of these > locations added to HFileLink object. > > setLocations(originPath, tempPath, mobPath, archivePath); > archivePath is the last one to be searched. For most cases, hfile exists in > archivePath, so we can move archivePath to the first parameter to avoid > unnecessary NN query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619679#comment-17619679 ] ruanhui commented on HBASE-27414: - hi [~huaxiangsun] would you mind if I prepare a patch for this ? > Search order for locations in HFileLink > > > Key: HBASE-27414 > URL: https://issues.apache.org/jira/browse/HBASE-27414 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Huaxiang Sun >Priority: Minor > > Found that search order for locations is following the order of these > locations added to HFileLink object. > > setLocations(originPath, tempPath, mobPath, archivePath); > archivePath is the last one to be searched. For most cases, hfile exists in > archivePath, so we can move archivePath to the first parameter to avoid > unnecessary NN query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27414) Search order for locations in HFileLink
[ https://issues.apache.org/jira/browse/HBASE-27414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615433#comment-17615433 ] Lijin Bin commented on HBASE-27414: --- Can you supply any patch? > Search order for locations in HFileLink > > > Key: HBASE-27414 > URL: https://issues.apache.org/jira/browse/HBASE-27414 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Huaxiang Sun >Priority: Minor > > Found that search order for locations is following the order of these > locations added to HFileLink object. > > setLocations(originPath, tempPath, mobPath, archivePath); > archivePath is the last one to be searched. For most cases, hfile exists in > archivePath, so we can move archivePath to the first parameter to avoid > unnecessary NN query. -- This message was sent by Atlassian Jira (v8.20.10#820010)
