[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715314#comment-17715314
]
Hudson commented on HBASE-27785:
Results for branch master
[build #823 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/823/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715235#comment-17715235
]
Hudson commented on HBASE-27785:
Results for branch branch-2
[build #796 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/796/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27785) Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
[
https://issues.apache.org/jira/browse/HBASE-27785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715018#comment-17715018
]
chenglei commented on HBASE-27785:
--
Pushed to 2.6+, thanks [~zhangduo] for reviewing!
> Encapsulate and centralize totalBufferUsed in ReplicationSourceManager
> --
>
> Key: HBASE-27785
> URL: https://issues.apache.org/jira/browse/HBASE-27785
> Project: HBase
> Issue Type: Improvement
> Components: Replication
>Affects Versions: 3.0.0-alpha-3
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
>
> {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to
> {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and
> {{ReplicationSourceWALReader}}, which makes the logic about
> {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout
> {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}}
> and {{ReplicationSourceShipper}}. It causes duplicated code and would make
> tracing the buffer usage somewhat difficult when there is problem about
> {{totalBufferUsed}}. I think we should encapsulate and centralize it in
> {{ReplicationSourceManager}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
