[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[
https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848057#comment-17848057
]
Hudson commented on HBASE-28599:
Results for branch branch-2
[build #1059 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1059/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1059/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1059/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1059/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1059/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowTooBigException is thrown when duplicate increment RPC call is attempted
> ---
>
> Key: HBASE-28599
> URL: https://issues.apache.org/jira/browse/HBASE-28599
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8
>Reporter: Robin Infant A
>Assignee: youngju kim
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
> Attachments: RowTooBig_trace.txt
>
>
> *Issue:*
> `RowTooBigException` is thrown when a duplicate increment RPC call is
> attempted.
> *Expected Behavior:*
> 1. The initial RPC increment call should time out for some reason.
> 2. The duplicate RPC call should be converted to a GET request and fetch the
> result that I am trying to increment.
> 3. The result should contain only the qualifier that I am attempting to
> increment.
> *Actual Behavior:*
> 1. The initial RPC increment call timed out, which is expected.
> 2. The duplicate RPC call is converted to a GET request but fails to clone
> the qualifier into the GET request.
> 3. Hence, the GET request attempts to retrieve all qualifiers for the given
> row and columnfamily, resulting in a `RowTooBigException`.
> *Steps to Reproduce:*
> 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize`
> (default = 1073741824) exists.
> 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is
> actually defaulted to true.
> 3. Attempt to increment a qualifier against the same row.
> 4. In my case, I am using a postIncrement co-processor which may cause a
> delay (longer than the RPC timeout property).
> 5. A duplicate increment call should be triggered, which tries to get the
> value rather than increment it.
> 6. The GET request actually tries to retrieve all the qualifiers for the row,
> resulting in a `RowTooBigException`.
> *Insights:*
> Upon further debugging, I found that qualifiers are not cloned into the GET
> instance due to incorrect usage of
> [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833]
> *Fix Suggestion:*
> Removing the `!` operation from `while (!CellScanner.advance)` may resolve
> the issue.
> Attached Exception Stack Trace for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[
https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848050#comment-17848050
]
Hudson commented on HBASE-28599:
Results for branch branch-2.4
[build #740 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/740/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/740/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/740/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/740/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/740/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowTooBigException is thrown when duplicate increment RPC call is attempted
> ---
>
> Key: HBASE-28599
> URL: https://issues.apache.org/jira/browse/HBASE-28599
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8
>Reporter: Robin Infant A
>Assignee: youngju kim
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
> Attachments: RowTooBig_trace.txt
>
>
> *Issue:*
> `RowTooBigException` is thrown when a duplicate increment RPC call is
> attempted.
> *Expected Behavior:*
> 1. The initial RPC increment call should time out for some reason.
> 2. The duplicate RPC call should be converted to a GET request and fetch the
> result that I am trying to increment.
> 3. The result should contain only the qualifier that I am attempting to
> increment.
> *Actual Behavior:*
> 1. The initial RPC increment call timed out, which is expected.
> 2. The duplicate RPC call is converted to a GET request but fails to clone
> the qualifier into the GET request.
> 3. Hence, the GET request attempts to retrieve all qualifiers for the given
> row and columnfamily, resulting in a `RowTooBigException`.
> *Steps to Reproduce:*
> 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize`
> (default = 1073741824) exists.
> 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is
> actually defaulted to true.
> 3. Attempt to increment a qualifier against the same row.
> 4. In my case, I am using a postIncrement co-processor which may cause a
> delay (longer than the RPC timeout property).
> 5. A duplicate increment call should be triggered, which tries to get the
> value rather than increment it.
> 6. The GET request actually tries to retrieve all the qualifiers for the row,
> resulting in a `RowTooBigException`.
> *Insights:*
> Upon further debugging, I found that qualifiers are not cloned into the GET
> instance due to incorrect usage of
> [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833]
> *Fix Suggestion:*
> Removing the `!` operation from `while (!CellScanner.advance)` may resolve
> the issue.
> Attached Exception Stack Trace for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[
https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848043#comment-17848043
]
Hudson commented on HBASE-28599:
Results for branch branch-2.6
[build #121 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/121/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/121/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/121/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/121/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/121/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowTooBigException is thrown when duplicate increment RPC call is attempted
> ---
>
> Key: HBASE-28599
> URL: https://issues.apache.org/jira/browse/HBASE-28599
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8
>Reporter: Robin Infant A
>Assignee: youngju kim
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
> Attachments: RowTooBig_trace.txt
>
>
> *Issue:*
> `RowTooBigException` is thrown when a duplicate increment RPC call is
> attempted.
> *Expected Behavior:*
> 1. The initial RPC increment call should time out for some reason.
> 2. The duplicate RPC call should be converted to a GET request and fetch the
> result that I am trying to increment.
> 3. The result should contain only the qualifier that I am attempting to
> increment.
> *Actual Behavior:*
> 1. The initial RPC increment call timed out, which is expected.
> 2. The duplicate RPC call is converted to a GET request but fails to clone
> the qualifier into the GET request.
> 3. Hence, the GET request attempts to retrieve all qualifiers for the given
> row and columnfamily, resulting in a `RowTooBigException`.
> *Steps to Reproduce:*
> 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize`
> (default = 1073741824) exists.
> 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is
> actually defaulted to true.
> 3. Attempt to increment a qualifier against the same row.
> 4. In my case, I am using a postIncrement co-processor which may cause a
> delay (longer than the RPC timeout property).
> 5. A duplicate increment call should be triggered, which tries to get the
> value rather than increment it.
> 6. The GET request actually tries to retrieve all the qualifiers for the row,
> resulting in a `RowTooBigException`.
> *Insights:*
> Upon further debugging, I found that qualifiers are not cloned into the GET
> instance due to incorrect usage of
> [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833]
> *Fix Suggestion:*
> Removing the `!` operation from `while (!CellScanner.advance)` may resolve
> the issue.
> Attached Exception Stack Trace for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[
https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847987#comment-17847987
]
Hudson commented on HBASE-28599:
Results for branch branch-3
[build #209 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/209/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/209/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/209/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-3/209/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowTooBigException is thrown when duplicate increment RPC call is attempted
> ---
>
> Key: HBASE-28599
> URL: https://issues.apache.org/jira/browse/HBASE-28599
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8
>Reporter: Robin Infant A
>Assignee: youngju kim
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
> Attachments: RowTooBig_trace.txt
>
>
> *Issue:*
> `RowTooBigException` is thrown when a duplicate increment RPC call is
> attempted.
> *Expected Behavior:*
> 1. The initial RPC increment call should time out for some reason.
> 2. The duplicate RPC call should be converted to a GET request and fetch the
> result that I am trying to increment.
> 3. The result should contain only the qualifier that I am attempting to
> increment.
> *Actual Behavior:*
> 1. The initial RPC increment call timed out, which is expected.
> 2. The duplicate RPC call is converted to a GET request but fails to clone
> the qualifier into the GET request.
> 3. Hence, the GET request attempts to retrieve all qualifiers for the given
> row and columnfamily, resulting in a `RowTooBigException`.
> *Steps to Reproduce:*
> 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize`
> (default = 1073741824) exists.
> 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is
> actually defaulted to true.
> 3. Attempt to increment a qualifier against the same row.
> 4. In my case, I am using a postIncrement co-processor which may cause a
> delay (longer than the RPC timeout property).
> 5. A duplicate increment call should be triggered, which tries to get the
> value rather than increment it.
> 6. The GET request actually tries to retrieve all the qualifiers for the row,
> resulting in a `RowTooBigException`.
> *Insights:*
> Upon further debugging, I found that qualifiers are not cloned into the GET
> instance due to incorrect usage of
> [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833]
> *Fix Suggestion:*
> Removing the `!` operation from `while (!CellScanner.advance)` may resolve
> the issue.
> Attached Exception Stack Trace for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[
https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847978#comment-17847978
]
Hudson commented on HBASE-28599:
Results for branch master
[build #1076 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1076/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1076/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1076/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1076/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowTooBigException is thrown when duplicate increment RPC call is attempted
> ---
>
> Key: HBASE-28599
> URL: https://issues.apache.org/jira/browse/HBASE-28599
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8
>Reporter: Robin Infant A
>Assignee: youngju kim
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
> Attachments: RowTooBig_trace.txt
>
>
> *Issue:*
> `RowTooBigException` is thrown when a duplicate increment RPC call is
> attempted.
> *Expected Behavior:*
> 1. The initial RPC increment call should time out for some reason.
> 2. The duplicate RPC call should be converted to a GET request and fetch the
> result that I am trying to increment.
> 3. The result should contain only the qualifier that I am attempting to
> increment.
> *Actual Behavior:*
> 1. The initial RPC increment call timed out, which is expected.
> 2. The duplicate RPC call is converted to a GET request but fails to clone
> the qualifier into the GET request.
> 3. Hence, the GET request attempts to retrieve all qualifiers for the given
> row and columnfamily, resulting in a `RowTooBigException`.
> *Steps to Reproduce:*
> 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize`
> (default = 1073741824) exists.
> 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is
> actually defaulted to true.
> 3. Attempt to increment a qualifier against the same row.
> 4. In my case, I am using a postIncrement co-processor which may cause a
> delay (longer than the RPC timeout property).
> 5. A duplicate increment call should be triggered, which tries to get the
> value rather than increment it.
> 6. The GET request actually tries to retrieve all the qualifiers for the row,
> resulting in a `RowTooBigException`.
> *Insights:*
> Upon further debugging, I found that qualifiers are not cloned into the GET
> instance due to incorrect usage of
> [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833]
> *Fix Suggestion:*
> Removing the `!` operation from `while (!CellScanner.advance)` may resolve
> the issue.
> Attached Exception Stack Trace for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[
https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847966#comment-17847966
]
Hudson commented on HBASE-28599:
Results for branch branch-2.5
[build #532 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/532/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/532/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/532/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/532/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/532/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowTooBigException is thrown when duplicate increment RPC call is attempted
> ---
>
> Key: HBASE-28599
> URL: https://issues.apache.org/jira/browse/HBASE-28599
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8
>Reporter: Robin Infant A
>Assignee: youngju kim
>Priority: Major
> Labels: pull-request-available
> Fix For: 2.4.18, 2.7.0, 3.0.0-beta-2, 2.6.1, 2.5.9
>
> Attachments: RowTooBig_trace.txt
>
>
> *Issue:*
> `RowTooBigException` is thrown when a duplicate increment RPC call is
> attempted.
> *Expected Behavior:*
> 1. The initial RPC increment call should time out for some reason.
> 2. The duplicate RPC call should be converted to a GET request and fetch the
> result that I am trying to increment.
> 3. The result should contain only the qualifier that I am attempting to
> increment.
> *Actual Behavior:*
> 1. The initial RPC increment call timed out, which is expected.
> 2. The duplicate RPC call is converted to a GET request but fails to clone
> the qualifier into the GET request.
> 3. Hence, the GET request attempts to retrieve all qualifiers for the given
> row and columnfamily, resulting in a `RowTooBigException`.
> *Steps to Reproduce:*
> 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize`
> (default = 1073741824) exists.
> 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is
> actually defaulted to true.
> 3. Attempt to increment a qualifier against the same row.
> 4. In my case, I am using a postIncrement co-processor which may cause a
> delay (longer than the RPC timeout property).
> 5. A duplicate increment call should be triggered, which tries to get the
> value rather than increment it.
> 6. The GET request actually tries to retrieve all the qualifiers for the row,
> resulting in a `RowTooBigException`.
> *Insights:*
> Upon further debugging, I found that qualifiers are not cloned into the GET
> instance due to incorrect usage of
> [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833]
> *Fix Suggestion:*
> Removing the `!` operation from `while (!CellScanner.advance)` may resolve
> the issue.
> Attached Exception Stack Trace for reference.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[ https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847675#comment-17847675 ] youngju kim commented on HBASE-28599: - Hello, [~zhangduo] Could you review this PR? [https://github.com/apache/hbase/pull/5927] > RowTooBigException is thrown when duplicate increment RPC call is attempted > --- > > Key: HBASE-28599 > URL: https://issues.apache.org/jira/browse/HBASE-28599 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8 >Reporter: Robin Infant A >Assignee: youngju kim >Priority: Major > Labels: pull-request-available > Attachments: RowTooBig_trace.txt > > > *Issue:* > `RowTooBigException` is thrown when a duplicate increment RPC call is > attempted. > *Expected Behavior:* > 1. The initial RPC increment call should time out for some reason. > 2. The duplicate RPC call should be converted to a GET request and fetch the > result that I am trying to increment. > 3. The result should contain only the qualifier that I am attempting to > increment. > *Actual Behavior:* > 1. The initial RPC increment call timed out, which is expected. > 2. The duplicate RPC call is converted to a GET request but fails to clone > the qualifier into the GET request. > 3. Hence, the GET request attempts to retrieve all qualifiers for the given > row and columnfamily, resulting in a `RowTooBigException`. > *Steps to Reproduce:* > 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize` > (default = 1073741824) exists. > 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is > actually defaulted to true. > 3. Attempt to increment a qualifier against the same row. > 4. In my case, I am using a postIncrement co-processor which may cause a > delay (longer than the RPC timeout property). > 5. A duplicate increment call should be triggered, which tries to get the > value rather than increment it. > 6. The GET request actually tries to retrieve all the qualifiers for the row, > resulting in a `RowTooBigException`. > *Insights:* > Upon further debugging, I found that qualifiers are not cloned into the GET > instance due to incorrect usage of > [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833] > *Fix Suggestion:* > Removing the `!` operation from `while (!CellScanner.advance)` may resolve > the issue. > Attached Exception Stack Trace for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28599) RowTooBigException is thrown when duplicate increment RPC call is attempted
[ https://issues.apache.org/jira/browse/HBASE-28599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847554#comment-17847554 ] youngju kim commented on HBASE-28599: - Hi,[~robiee17] . I'm operating HBase clusters in my company from Korea. Thank you for explaining the detailed problem definition, reproduction process with some hint. I'd like to do HBase contributing. Is it okay if I try to solve this issue? > RowTooBigException is thrown when duplicate increment RPC call is attempted > --- > > Key: HBASE-28599 > URL: https://issues.apache.org/jira/browse/HBASE-28599 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 2.5.5, 2.5.6, 2.5.7, 2.5.8 >Reporter: Robin Infant A >Priority: Major > Attachments: RowTooBig_trace.txt > > > *Issue:* > `RowTooBigException` is thrown when a duplicate increment RPC call is > attempted. > *Expected Behavior:* > 1. The initial RPC increment call should time out for some reason. > 2. The duplicate RPC call should be converted to a GET request and fetch the > result that I am trying to increment. > 3. The result should contain only the qualifier that I am attempting to > increment. > *Actual Behavior:* > 1. The initial RPC increment call timed out, which is expected. > 2. The duplicate RPC call is converted to a GET request but fails to clone > the qualifier into the GET request. > 3. Hence, the GET request attempts to retrieve all qualifiers for the given > row and columnfamily, resulting in a `RowTooBigException`. > *Steps to Reproduce:* > 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize` > (default = 1073741824) exists. > 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is > actually defaulted to true. > 3. Attempt to increment a qualifier against the same row. > 4. In my case, I am using a postIncrement co-processor which may cause a > delay (longer than the RPC timeout property). > 5. A duplicate increment call should be triggered, which tries to get the > value rather than increment it. > 6. The GET request actually tries to retrieve all the qualifiers for the row, > resulting in a `RowTooBigException`. > *Insights:* > Upon further debugging, I found that qualifiers are not cloned into the GET > instance due to incorrect usage of > [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833] > *Fix Suggestion:* > Removing the `!` operation from `while (!CellScanner.advance)` may resolve > the issue. > Attached Exception Stack Trace for reference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
