[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558939#comment-13558939 ] Devaraj Das commented on HBASE-3170: bq. We could probably just throw an exception if you try and pass a Get a null row too.. Was wondering about the test. Ok [~stack], will review the patch from that point of view.. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch, 3170v5.txt I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558941#comment-13558941 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565810/3170v5.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4110//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch, 3170v5.txt I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558964#comment-13558964 ] Ted Yu commented on HBASE-3170: --- How about adding the new test to: {code} public class TestFromClientSide3 { {code} RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch, 3170v5.txt I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559056#comment-13559056 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565830/3170-5.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4114//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-5.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch, 3170v5.txt I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559204#comment-13559204 ] Hudson commented on HBASE-3170: --- Integrated in HBase-TRUNK #3775 (See [https://builds.apache.org/job/HBase-TRUNK/3775/]) HBASE-3170 RegionServer confused about empty row keys (Revision 1436587) Result = FAILURE stack : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-5.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch, 3170v5.txt I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559249#comment-13559249 ] Hudson commented on HBASE-3170: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #365 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/365/]) HBASE-3170 RegionServer confused about empty row keys (Revision 1436587) Result = FAILURE stack : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/Scan.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-5.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch, 3170v5.txt I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558343#comment-13558343 ] Ted Yu commented on HBASE-3170: --- The following test failure seems to be related: {code} Failed tests: testMultipleTimestampRanges[0](org.apache.hadoop.hbase.regionserver.TestSeekOptimizations): Expected and actual KV arrays differ at position 0: row1/myCF:qual0/2999/Put/vlen=0/ts=0 (length 3) vs. out_of_range (length 0). Bloom=NONE, compr=NONE, Scan: all columns, row=1, maxVersions=1, lazySeek=false testMultipleTimestampRanges[1](org.apache.hadoop.hbase.regionserver.TestSeekOptimizations): Expected and actual KV arrays differ at position 0: row1/myCF:qual0/2999/Put/vlen=0/ts=0 (length 3) vs. out_of_range (length 0). Bloom=ROW, compr=NONE, Scan: all columns, row=1, maxVersions=1, lazySeek=false testMultipleTimestampRanges[2](org.apache.hadoop.hbase.regionserver.TestSeekOptimizations): Expected and actual KV arrays differ at position 0: row1/myCF:qual0/2999/Put/vlen=0/ts=0 (length 3) vs. out_of_range (length 0). Bloom=ROWCOL, compr=NONE, Scan: all columns, row=1, maxVersions=1, lazySeek=false testMultipleTimestampRanges[3](org.apache.hadoop.hbase.regionserver.TestSeekOptimizations): Expected and actual KV arrays differ at position 0: row1/myCF:qual0/2999/Put/vlen=0/ts=0 (length 3) vs. out_of_range (length 0). Bloom=NONE, compr=GZ, Scan: all columns, row=1, maxVersions=1, lazySeek=false testMultipleTimestampRanges[4](org.apache.hadoop.hbase.regionserver.TestSeekOptimizations): Expected and actual KV arrays differ at position 0: row1/myCF:qual0/2999/Put/vlen=0/ts=0 (length 3) vs. out_of_range (length 0). Bloom=ROW, compr=GZ, Scan: all columns, row=1, maxVersions=1, lazySeek=false testMultipleTimestampRanges[5](org.apache.hadoop.hbase.regionserver.TestSeekOptimizations): Expected and actual KV arrays differ at position 0: row1/myCF:qual0/2999/Put/vlen=0/ts=0 (length 3) vs. out_of_range (length 0). Bloom=ROWCOL, compr=GZ, Scan: all columns, row=1, maxVersions=1, lazySeek=false {code} RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558346#comment-13558346 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565705/3170-3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster org.apache.hadoop.hbase.regionserver.TestSeekOptimizations Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4105//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558374#comment-13558374 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565706/3170-4.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4106//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558417#comment-13558417 ] stack commented on HBASE-3170: -- bq. On the point about disabling Get with empty row, I was also having the same opinion until I started digging into why Get with empty row key is broken at all. Can you say more? Would it be hard just throwing IllegalArgument if Get is passed a null or empty row? v3 patch seems to keep isScanCreatedFromGet beside a method called isGetScan. I'd think this'll confuse (and yeah, will think that not all Gets use the Get constructor. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558466#comment-13558466 ] Devaraj Das commented on HBASE-3170: Well I just wanted to fix the problem reported by Benoit if possible :-) Please have a look at the 3170-4.patch. That's the last iteration from me and passes all tests. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-3.patch, 3170-4.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558034#comment-13558034 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565638/3170-v3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.constraint.TestConstraint org.apache.hadoop.hbase.TestLocalHBaseCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4102//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-v2.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558049#comment-13558049 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565641/3170-v3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestLocalHBaseCluster {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4103//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558108#comment-13558108 ] stack commented on HBASE-3170: -- bq. It turns out that we need to keep the original behavior of Scan.isGetScan() Why is that? Seems odd having isGetScan and isScanCreatedFromGet. I'd think that a method named isGetScan would return true if this was a Scan made to service a Get? It seems like isGetScan is trying to look at scanner specs to see if a Get scan rather than just at whether or not the Scan constructor that takes a Get was used. Looking at this, if you pass a Get a null or empty row, should we just throw an exception immediately and not even start the Scan going? Let a Get with an empty row be illegal? RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch, 3170-v2.patch, 3170-v3.patch, 3170-v3.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557899#comment-13557899 ] Ted Yu commented on HBASE-3170: --- {code} +public class TestGetEmptyRowKey { {code} The new test would be a medium test, right ? Please add annotation. {code} + //don't stop + return false; {code} You can save the comment such as the one above if you add javadoc for isStopRowConsideringEmptyRows(). RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing problem with the command-line of the shell. I can reproduce this behavior both with plain Java code and with my asynchbase client. Since I don't actually have a row with an empty row key, I expected that the first {{get}} would return nothing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13557900#comment-13557900 ] Hadoop QA commented on HBASE-3170: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565622/3170-1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.TestCheckTestClasses org.apache.hadoop.hbase.regionserver.TestScanWithBloomError org.apache.hadoop.hbase.regionserver.TestStoreFile Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4099//console This message is automatically generated. RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure Assignee: Devaraj Das Priority: Critical Fix For: 0.96.0 Attachments: 3170-1.patch I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo
[jira] [Commented] (HBASE-3170) RegionServer confused about empty row keys
[ https://issues.apache.org/jira/browse/HBASE-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482257#comment-13482257 ] Martin Fiala commented on HBASE-3170: - We are hitting this too, this is a really unexpected behaviour. Why getting empty key should return data of the first row in table? Reproduced in CDH3u4 (0.90.6): {code} hbase(main):005:0 create 'emptykey', {NAME='data', VERSION=1} 0 row(s) in 0.2070 seconds hbase(main):011:0 get 'emptykey', '' COLUMN CELL 0 row(s) in 0.0120 seconds hbase(main):006:0 put 'emptykey', 'a', 'data:a', '1234' 0 row(s) in 0.1980 seconds hbase(main):007:0 put 'emptykey', 'b', 'data:b', '5678' 0 row(s) in 0.0070 seconds hbase(main):008:0 scan 'emptykey' ROWCOLUMN+CELL a column=data:a, timestamp=1350989443394, value=1234 b column=data:b, timestamp=1350989450499, value=5678 2 row(s) in 0.0660 seconds hbase(main):009:0 get 'emptykey', '' COLUMN CELL data:atimestamp=1350989443394, value=1234 1 row(s) in 0.0120 seconds {code} It works the same way also using thrift. We can even see, that empty key is supported in fact. {code} hbase(main):012:0 put 'emptykey', '', 'data:c', '90' 0 row(s) in 0.0130 seconds hbase(main):013:0 get 'emptykey', '' COLUMN CELL data:ctimestamp=1350989869682, value=90 1 row(s) in 0.0120 seconds hbase(main):018:0 scan 'emptykey' ROWCOLUMN+CELL column=data:c, timestamp=1350989869682, value=90 a column=data:a, timestamp=1350989933922, value=1234 b column=data:b, timestamp=1350989937820, value=5678 3 row(s) in 0.0180 seconds {code} RegionServer confused about empty row keys -- Key: HBASE-3170 URL: https://issues.apache.org/jira/browse/HBASE-3170 Project: HBase Issue Type: Bug Components: regionserver Affects Versions: 0.89.20100621, 0.89.20100924, 0.90.0, 0.90.1, 0.90.2, 0.90.3, 0.90.4, 0.90.5, 0.90.6, 0.92.0, 0.92.1 Reporter: Benoit Sigoure I'm no longer sure about the expected behavior when using an empty row key (e.g. a 0-byte long byte array). I assumed that this was a legitimate row key, just like having an empty column qualifier is allowed. But it seems that the RegionServer considers the empty row key to be whatever the first row key is. {code} Version: 0.89.20100830, r0da2890b242584a8a5648d83532742ca7243346b, Sat Sep 18 15:30:09 PDT 2010 hbase(main):001:0 scan 'tsdb-uid', {LIMIT = 1} ROW COLUMN+CELL \x00 column=id:metrics, timestamp=1288375187699, value=foo \x00 column=id:tagk, timestamp=1287522021046, value=bar \x00 column=id:tagv, timestamp=1288111387685, value=qux 1 row(s) in 0.4610 seconds hbase(main):002:0 get 'tsdb-uid', '' COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0910 seconds hbase(main):003:0 get 'tsdb-uid', \000 COLUMNCELL id:metrics timestamp=1288375187699, value=foo id:tagk timestamp=1287522021046, value=bar id:tagv timestamp=1288111387685, value=qux 3 row(s) in 0.0550 seconds {code} This isn't a parsing