[jira] [Commented] (HBASE-4476) Compactions must fail if column tracker gets columns out of order
[
https://issues.apache.org/jira/browse/HBASE-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118429#comment-13118429
]
Mikhail Bautin commented on HBASE-4476:
---
This patch passes all unit tests.
Compactions must fail if column tracker gets columns out of order
-
Key: HBASE-4476
URL: https://issues.apache.org/jira/browse/HBASE-4476
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.92.0, 0.94.0
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4476) Compactions must fail if column tracker gets columns out of order
[
https://issues.apache.org/jira/browse/HBASE-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118436#comment-13118436
]
jirapos...@reviews.apache.org commented on HBASE-4476:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2050/#review2233
---
Ship it!
- Ted
On 2011-09-29 23:45:46, Mikhail Bautin wrote:
bq.
bq. ---
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2050/
bq. ---
bq.
bq. (Updated 2011-09-29 23:45:46)
bq.
bq.
bq. Review request for hbase and Kannan Muthukkaruppan.
bq.
bq.
bq. Summary
bq. ---
bq.
bq. We found this in ScanWildcardColumnTracker:
bq.
bq. // new col oldcol
bq. // if (cmp 0) {
bq. // WARNING: This means that very likely an edit for some other family
bq. // was incorrectly stored into the store for this one. Continue, but
bq. // complain.
bq. LOG.error(ScanWildcardColumnTracker.checkColumn ran +
bq. into a column actually smaller than the previous column: +
bq.
bq. This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
bq.
bq.
bq. This addresses bug HBASE-4476.
bq. https://issues.apache.org/jira/browse/HBASE-4476
bq.
bq.
bq. Diffs
bq. -
bq.
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
1176613
bq.
bq. Diff: https://reviews.apache.org/r/2050/diff
bq.
bq.
bq. Testing
bq. ---
bq.
bq. Run unit tests.
bq. Will also push to a 5-node dev cluster.
bq.
bq.
bq. Thanks,
bq.
bq. Mikhail
bq.
bq.
Compactions must fail if column tracker gets columns out of order
-
Key: HBASE-4476
URL: https://issues.apache.org/jira/browse/HBASE-4476
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.92.0, 0.94.0
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4476) Compactions must fail if column tracker gets columns out of order
[
https://issues.apache.org/jira/browse/HBASE-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118456#comment-13118456
]
jirapos...@reviews.apache.org commented on HBASE-4476:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2050/#review2235
---
Ship it!
- Michael
On 2011-09-29 23:45:46, Mikhail Bautin wrote:
bq.
bq. ---
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2050/
bq. ---
bq.
bq. (Updated 2011-09-29 23:45:46)
bq.
bq.
bq. Review request for hbase and Kannan Muthukkaruppan.
bq.
bq.
bq. Summary
bq. ---
bq.
bq. We found this in ScanWildcardColumnTracker:
bq.
bq. // new col oldcol
bq. // if (cmp 0) {
bq. // WARNING: This means that very likely an edit for some other family
bq. // was incorrectly stored into the store for this one. Continue, but
bq. // complain.
bq. LOG.error(ScanWildcardColumnTracker.checkColumn ran +
bq. into a column actually smaller than the previous column: +
bq.
bq. This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
bq.
bq.
bq. This addresses bug HBASE-4476.
bq. https://issues.apache.org/jira/browse/HBASE-4476
bq.
bq.
bq. Diffs
bq. -
bq.
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
1176613
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
1176613
bq.
bq. Diff: https://reviews.apache.org/r/2050/diff
bq.
bq.
bq. Testing
bq. ---
bq.
bq. Run unit tests.
bq. Will also push to a 5-node dev cluster.
bq.
bq.
bq. Thanks,
bq.
bq. Mikhail
bq.
bq.
Compactions must fail if column tracker gets columns out of order
-
Key: HBASE-4476
URL: https://issues.apache.org/jira/browse/HBASE-4476
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.92.0, 0.94.0
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4476) Compactions must fail if column tracker gets columns out of order
[
https://issues.apache.org/jira/browse/HBASE-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118588#comment-13118588
]
Hudson commented on HBASE-4476:
---
Integrated in HBase-0.92 #35 (See
[https://builds.apache.org/job/HBase-0.92/35/])
HBASE-4476 Compactions must fail if column tracker gets columns out of order
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
*
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
*
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
Compactions must fail if column tracker gets columns out of order
-
Key: HBASE-4476
URL: https://issues.apache.org/jira/browse/HBASE-4476
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.92.0, 0.94.0
Attachments: HBASE-4476_v2_2011-09-27_17_38_48.patch
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4476) Compactions must fail if column tracker gets columns out of order
[
https://issues.apache.org/jira/browse/HBASE-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13118631#comment-13118631
]
Hudson commented on HBASE-4476:
---
Integrated in HBase-TRUNK #2274 (See
[https://builds.apache.org/job/HBase-TRUNK/2274/])
HBASE-4476 Compactions must fail if column tracker gets columns out of order
stack :
Files :
* /hbase/trunk/CHANGES.txt
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
*
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
*
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
Compactions must fail if column tracker gets columns out of order
-
Key: HBASE-4476
URL: https://issues.apache.org/jira/browse/HBASE-4476
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.92.0, 0.94.0
Attachments: HBASE-4476_v2_2011-09-27_17_38_48.patch
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4476) Compactions must fail if column tracker gets columns out of order
[
https://issues.apache.org/jira/browse/HBASE-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117749#comment-13117749
]
jirapos...@reviews.apache.org commented on HBASE-4476:
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2050/
---
(Updated 2011-09-29 23:45:46.477105)
Review request for hbase and Kannan Muthukkaruppan.
Changes
---
Linking to HBASE-4476.
Summary
---
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family name
was misspelled first, but then was renamed by renaming directories in the
HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
This addresses bug HBASE-4476.
https://issues.apache.org/jira/browse/HBASE-4476
Diffs
-
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
1176613
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
1176613
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
1176613
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
1176613
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
1176613
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
1176613
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
1176613
Diff: https://reviews.apache.org/r/2050/diff
Testing
---
Run unit tests.
Will also push to a 5-node dev cluster.
Thanks,
Mikhail
Compactions must fail if column tracker gets columns out of order
-
Key: HBASE-4476
URL: https://issues.apache.org/jira/browse/HBASE-4476
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
Fix For: 0.92.0, 0.94.0
We found this in ScanWildcardColumnTracker:
// new col oldcol
// if (cmp 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error(ScanWildcardColumnTracker.checkColumn ran +
into a column actually smaller than the previous column: +
This went under the radar in our dark launch cluster when a column family
name was misspelled first, but then was renamed by renaming directories in
the HBase storage directory tree. We ended up with inconsistent data, but
compactions still succeeded most of the time, likely discarding part of input
data.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
