[jira] [Commented] (HBASE-4636) Refactor catalog MetaReader and MetaEditor so one class only

2011-10-20 Thread Jonathan Gray (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131952#comment-13131952
 ] 

Jonathan Gray commented on HBASE-4636:
--

is this really a noob task?  i'm +1 on revisiting the structure here, but 
shouldn't it be part of the larger CatalogTracker / retry facilities / etc?

 Refactor catalog MetaReader and MetaEditor so one class only
 

 Key: HBASE-4636
 URL: https://issues.apache.org/jira/browse/HBASE-4636
 Project: HBase
  Issue Type: Improvement
Reporter: stack
  Labels: noob

 I suggest we collapse MetaReader and MetaEditor.  Setters are in one class 
 while Getters are in another which is a little disorientating.  The Editor 
 class uses facility from the Reader class to do edits which seems a little 
 off.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-4636) Refactor catalog MetaReader and MetaEditor so one class only

2011-10-20 Thread stack (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131956#comment-13131956
 ] 

stack commented on HBASE-4636:
--

Ok

 Refactor catalog MetaReader and MetaEditor so one class only
 

 Key: HBASE-4636
 URL: https://issues.apache.org/jira/browse/HBASE-4636
 Project: HBase
  Issue Type: Improvement
Reporter: stack
  Labels: noob

 I suggest we collapse MetaReader and MetaEditor.  Setters are in one class 
 while Getters are in another which is a little disorientating.  The Editor 
 class uses facility from the Reader class to do edits which seems a little 
 off.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira