[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140832#comment-13140832 ] Hudson commented on HBASE-4687: --- Integrated in HBase-0.92 #90 (See [https://builds.apache.org/job/HBase-0.92/90/]) HBASE-4687 regionserver may miss zk-heartbeats to master when replaying edits at region open (prakash via jgray) jgray : Files : * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > Fix For: 0.92.0 > > Attachments: > 0001-HBASE-4687-regionserver-may-miss-zk-heartbeats-to-ma.patch > > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138988#comment-13138988 ] Hudson commented on HBASE-4687: --- Integrated in HBase-TRUNK #2380 (See [https://builds.apache.org/job/HBase-TRUNK/2380/]) HBASE-4687 regionserver may miss zk-heartbeats to master when replaying edits at region open (prakash via jgray) jgray : Files : * /hbase/trunk/CHANGES.txt * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > Fix For: 0.92.0 > > Attachments: > 0001-HBASE-4687-regionserver-may-miss-zk-heartbeats-to-ma.patch > > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138828#comment-13138828 ] Jonathan Gray commented on HBASE-4687: -- Thanks Prakash! > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > Fix For: 0.92.0 > > Attachments: > 0001-HBASE-4687-regionserver-may-miss-zk-heartbeats-to-ma.patch > > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138752#comment-13138752 ] jirapos...@reviews.apache.org commented on HBASE-4687: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2585/#review2916 --- Ship it! looks good to me - Jonathan On 2011-10-27 19:32:54, Prakash Khemani wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2585/ bq. --- bq. bq. (Updated 2011-10-27 19:32:54) bq. bq. bq. Review request for hbase, Dhruba Borthakur, Jonathan Gray, and Nicolas Spiegelberg. bq. bq. bq. Summary bq. --- bq. bq. must report.progress() at least once per edits file when replaying edits bq. bq. bq. This addresses bug HBASE-4687. bq. https://issues.apache.org/jira/browse/HBASE-4687 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 5243b58 bq. bq. Diff: https://reviews.apache.org/r/2585/diff bq. bq. bq. Testing bq. --- bq. bq. small change and not tested. bq. bq. bq. Thanks, bq. bq. Prakash bq. bq. > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137495#comment-13137495 ] Prakash Khemani commented on HBASE-4687: The progress reporter in this case heartbeats to the master via zk and therefore I had called them zk-heartbeats. I know realize that calling them zk-heartbeats easily confuses matters with the region server's "I am Alive" zk-heartbeat. In this case, master has put up the zk node /hbase/UNASSIGNED/ and is waiting for the rs to open the region. The rs, while opening the region, keeps updating that zk node to let the master know of that region open is progressing. On 10/27/11 12:46 PM, "jirapos...@reviews.apache.org (Commented) (JIRA)" > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137443#comment-13137443 ] jirapos...@reviews.apache.org commented on HBASE-4687: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2585/#review2889 --- Looks good to me. Could you explain what the ramifications of not doing this are? I.e. what does the progress reporter have to do with ZK heartbeats? Thanks! - Lars On 2011-10-27 19:32:54, Prakash Khemani wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2585/ bq. --- bq. bq. (Updated 2011-10-27 19:32:54) bq. bq. bq. Review request for hbase, Dhruba Borthakur, Jonathan Gray, and Nicolas Spiegelberg. bq. bq. bq. Summary bq. --- bq. bq. must report.progress() at least once per edits file when replaying edits bq. bq. bq. This addresses bug HBASE-4687. bq. https://issues.apache.org/jira/browse/HBASE-4687 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 5243b58 bq. bq. Diff: https://reviews.apache.org/r/2585/diff bq. bq. bq. Testing bq. --- bq. bq. small change and not tested. bq. bq. bq. Thanks, bq. bq. Prakash bq. bq. > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4687) regionserver may miss zk-heartbeats to master when replaying edits at region open
[ https://issues.apache.org/jira/browse/HBASE-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137425#comment-13137425 ] jirapos...@reviews.apache.org commented on HBASE-4687: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2585/ --- Review request for hbase, Dhruba Borthakur, Jonathan Gray, and Nicolas Spiegelberg. Summary --- must report.progress() at least once per edits file when replaying edits This addresses bug HBASE-4687. https://issues.apache.org/jira/browse/HBASE-4687 Diffs - src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 5243b58 Diff: https://reviews.apache.org/r/2585/diff Testing --- small change and not tested. Thanks, Prakash > regionserver may miss zk-heartbeats to master when replaying edits at region > open > - > > Key: HBASE-4687 > URL: https://issues.apache.org/jira/browse/HBASE-4687 > Project: HBase > Issue Type: Bug >Reporter: Prakash Khemani >Assignee: Prakash Khemani > > replayRecoveredEdits() should do another reporter.progress() before returning. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
