[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173370#comment-13173370 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- bq. On 2011-12-20 00:48:41, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 29 bq. https://reviews.apache.org/r/3188/diff/3/?file=64523#file64523line29 bq. bq. If this is an md5 under the wraps, maybe we should just do md5 rather than do this uuid indirection? But maybe the UUID class has some facility you like that makes it easier to work with? I'm down with moving to an md5 bq. On 2011-12-20 00:48:41, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 340 bq. https://reviews.apache.org/r/3188/diff/3/?file=64523#file64523line340 bq. bq. Why line here? woops bq. On 2011-12-20 00:48:41, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 352 bq. https://reviews.apache.org/r/3188/diff/3/?file=64523#file64523line352 bq. bq. Were we talking about uuids in original code? bq. bq. Should we cache tablename in HRI if we are passed it so can avoid a meta hit if absent? bq. bq. If a meta hit to get table name, its in the last HRI only? Is that the plan? The last HRI in a table has the table name? Or if not this, where is it in the meta table? That's true, i must have gotten that comment in my previous patch (https://reviews.apache.org/r/3186/) I assumed the tablename was in the hregioninfo. Not sure what the third question means. bq. On 2011-12-20 00:48:41, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 398 bq. https://reviews.apache.org/r/3188/diff/3/?file=64523#file64523line398 bq. bq. Whats UUID tablename? And though its not you, whats the 1|2 about? The 1 or 2 is how you know it's the last region I can make it more clear i'm sure. bq. On 2011-12-20 00:48:41, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 422 bq. https://reviews.apache.org/r/3188/diff/3/?file=64523#file64523line422 bq. bq. Something is wrong w/ this patch ? We had a '@return The UUID of the Table name' in original src? Woops bq. On 2011-12-20 00:48:41, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java, line 21 bq. https://reviews.apache.org/r/3188/diff/3/?file=64525#file64525line21 bq. bq. MetaSearchRow is not in src, its brought in by another related patch? So this is a patch on top of that patch? https://reviews.apache.org/r/3186/ - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/#review3992 --- On 2011-12-13 23:36:44, Alex Newman wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3188/ bq. --- bq. bq. (Updated 2011-12-13 23:36:44) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. PART 2 of hbase-4616 bq. bq. By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker bq. bq. bq. This addresses bug HBASE-4895. bq. https://issues.apache.org/jira/browse/HBASE-4895 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 bq.src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 bq.src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda bq.src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 bq.src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b bq.src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 bq.src/test/ruby/hbase/admin_test.rb 0c2672b bq. bq. Diff: https://reviews.apache.org/r/3188/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Alex bq. bq. Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172798#comment-13172798 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/#review3992 --- I probably shouldn't be reviewing this again? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment9044 If this is an md5 under the wraps, maybe we should just do md5 rather than do this uuid indirection? But maybe the UUID class has some facility you like that makes it easier to work with? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment9039 Why line here? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment9040 Were we talking about uuids in original code? Should we cache tablename in HRI if we are passed it so can avoid a meta hit if absent? If a meta hit to get table name, its in the last HRI only? Is that the plan? The last HRI in a table has the table name? Or if not this, where is it in the meta table? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment9041 Whats UUID tablename? And though its not you, whats the 1|2 about? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment9042 Something is wrong w/ this patch ? We had a '@return The UUID of the Table name' in original src? src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java https://reviews.apache.org/r/3188/#comment9043 MetaSearchRow is not in src, its brought in by another related patch? So this is a patch on top of that patch? - Michael On 2011-12-13 23:36:44, Alex Newman wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3188/ bq. --- bq. bq. (Updated 2011-12-13 23:36:44) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. PART 2 of hbase-4616 bq. bq. By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker bq. bq. bq. This addresses bug HBASE-4895. bq. https://issues.apache.org/jira/browse/HBASE-4895 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 bq.src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 bq.src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda bq.src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 bq.src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b bq.src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 bq.src/test/ruby/hbase/admin_test.rb 0c2672b bq. bq. Diff: https://reviews.apache.org/r/3188/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Alex bq. bq. Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman Attachments: 0002-Moved-to-a-uuid-tablename.patch This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168725#comment-13168725 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/ --- Review request for hbase. Summary --- PART 2 of hbase-4616 By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker This addresses bug HBASE-4895. https://issues.apache.org/jira/browse/HBASE-4895 Diffs - src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 src/test/ruby/hbase/admin_test.rb 0c2672b Diff: https://reviews.apache.org/r/3188/diff Testing --- Thanks, Alex Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168733#comment-13168733 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/ --- (Updated 2011-12-13 21:13:46.258788) Review request for hbase. Summary --- PART 2 of hbase-4616 By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker This addresses bug HBASE-4895. https://issues.apache.org/jira/browse/HBASE-4895 Diffs (updated) - src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 src/test/ruby/hbase/admin_test.rb 0c2672b Diff: https://reviews.apache.org/r/3188/diff Testing --- Thanks, Alex Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman Attachments: 0002-Moved-to-a-uuid-tablename.patch This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168732#comment-13168732 ] Alex Newman commented on HBASE-4895: I updated the review for this change, although this should still be considered a talking point we still need to figure out migrations and a couple of tests. I am just curious if the approach makes sense. Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman Attachments: 0002-Moved-to-a-uuid-tablename.patch This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168828#comment-13168828 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/#review3892 --- When I scan, I'll see uuids. How do I go from uuid to tablename as I ask in below? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment8750 This uuid type 3 will be same no matter what machine or time (it looks like it but asking if you verified) One day we should add to Bytes a Bytes.toBytes that takes a uuid src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment8751 Whats this here? UUID tablename? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment8752 Is this tablename or uuid? Don't you have to deprecate the old method rather than just drop it? src/main/java/org/apache/hadoop/hbase/HRegionInfo.java https://reviews.apache.org/r/3188/#comment8753 How do I go from uuid of tablename back to tablename? I don't see it. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java https://reviews.apache.org/r/3188/#comment8755 Whats going on here? The other patch adds this file. So it has to go in first? - Michael On 2011-12-13 21:13:46, Alex Newman wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3188/ bq. --- bq. bq. (Updated 2011-12-13 21:13:46) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. PART 2 of hbase-4616 bq. bq. By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker bq. bq. bq. This addresses bug HBASE-4895. bq. https://issues.apache.org/jira/browse/HBASE-4895 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 bq.src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 bq.src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda bq.src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 bq.src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b bq.src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 bq.src/test/ruby/hbase/admin_test.rb 0c2672b bq. bq. Diff: https://reviews.apache.org/r/3188/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Alex bq. bq. Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman Attachments: 0002-Moved-to-a-uuid-tablename.patch This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168872#comment-13168872 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- bq. On 2011-12-13 23:06:02, Michael Stack wrote: bq. When I scan, I'll see uuids. How do I go from uuid to tablename as I ask in below? You can do it by getting the last hri for that table , and getting it's tablename. So it would require a meta hit. Expect an update soon bq. On 2011-12-13 23:06:02, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 347 bq. https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line347 bq. bq. This uuid type 3 will be same no matter what machine or time (it looks like it but asking if you verified) bq. bq. One day we should add to Bytes a Bytes.toBytes that takes a uuid Verified bq. On 2011-12-13 23:06:02, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 391 bq. https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line391 bq. bq. Whats this here? UUID tablename? correct bq. On 2011-12-13 23:06:02, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 417 bq. https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line417 bq. bq. Is this tablename or uuid? Don't you have to deprecate the old method rather than just drop it? It is no longer possible to go from just a regionName to a tablename without a meta hit. I could implement the metahit? bq. On 2011-12-13 23:06:02, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 450 bq. https://reviews.apache.org/r/3188/diff/2/?file=64456#file64456line450 bq. bq. How do I go from uuid of tablename back to tablename? I don't see it. You can't without a meta hit. bq. On 2011-12-13 23:06:02, Michael Stack wrote: bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java, line 50 bq. https://reviews.apache.org/r/3188/diff/2/?file=64458#file64458line50 bq. bq. Whats going on here? The other patch adds this file. So it has to go in first? Correct, these three reviews are tied in a certain order. They could be combined into one patch to work, but they are easier to review on their own imho. I'd be glad to combine like the first review. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/#review3892 --- On 2011-12-13 21:13:46, Alex Newman wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3188/ bq. --- bq. bq. (Updated 2011-12-13 21:13:46) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. PART 2 of hbase-4616 bq. bq. By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker bq. bq. bq. This addresses bug HBASE-4895. bq. https://issues.apache.org/jira/browse/HBASE-4895 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 bq.src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 bq.src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda bq.src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 bq.src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 bq.src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b bq.src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 bq.src/test/ruby/hbase/admin_test.rb 0c2672b bq. bq. Diff: https://reviews.apache.org/r/3188/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Alex bq. bq. Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman Attachments: 0002-Moved-to-a-uuid-tablename.patch This is something
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168876#comment-13168876 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3188/ --- (Updated 2011-12-13 23:36:44.874504) Review request for hbase. Summary --- PART 2 of hbase-4616 By uuiding the tablename in the metarow, it enables us to be able to use binary values for the end of table marker This addresses bug HBASE-4895. https://issues.apache.org/jira/browse/HBASE-4895 Diffs (updated) - src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 74cb821 src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/util/Merge.java 67d0fda src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 95712dd src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java ff9c502 src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 368a0e5 src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java 36dd289 src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 6e1211b src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java cffdcb6 src/test/ruby/hbase/admin_test.rb 0c2672b Diff: https://reviews.apache.org/r/3188/diff Testing --- Thanks, Alex Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman Attachments: 0002-Moved-to-a-uuid-tablename.patch This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4895) Change tablename format in meta to be the UUID of the tablename rather than the tablename.
[ https://issues.apache.org/jira/browse/HBASE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159611#comment-13159611 ] jirapos...@reviews.apache.org commented on HBASE-4895: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2965/ --- Review request for hbase. Summary --- The issue is we have to have a custom compareter for metakey/rootkey scanning to work. One of the reasons why this is required is that the tablenames are currently lexically sorted. This addresses bug HBASE-4895. https://issues.apache.org/jira/browse/HBASE-4895 Diffs - src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f Diff: https://reviews.apache.org/r/2965/diff Testing --- Thanks, Alex Change tablename format in meta to be the UUID of the tablename rather than the tablename. -- Key: HBASE-4895 URL: https://issues.apache.org/jira/browse/HBASE-4895 Project: HBase Issue Type: Sub-task Reporter: Alex Newman Assignee: Alex Newman This is something stack and I discussed at hadoop world. Overall I think it cleans thing up significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
