[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13240900#comment-13240900
]
Hudson commented on HBASE-5641:
---
Integrated in HBase-TRUNK #2697 (See
[https://builds.apache.org/job/HBase-TRUNK/2697/])
HBASE-5641 decayingSampleTick1 prevents HBase from shutting down. (Revision
1305722)
Result = FAILURE
larsh :
Files :
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239216#comment-13239216
]
Hudson commented on HBASE-5641:
---
Integrated in HBase-TRUNK-security #151 (See
[https://builds.apache.org/job/HBase-TRUNK-security/151/])
HBASE-5641 decayingSampleTick1 prevents HBase from shutting down. (Revision
1305722)
Result = FAILURE
larsh :
Files :
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239634#comment-13239634
]
Andrew Purtell commented on HBASE-5641:
---
+1 on patch but is there a clear case where a utility factory like this should
be producing non-daemon threads?
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239652#comment-13239652
]
Lars Hofhansl commented on HBASE-5641:
--
@Andrew: In this case this is a constantly running background thread that keeps
statistics around for as long as the server is up. So in this case these must
be daemon threads (only one in this case, though) or the executor must be
shutdown on server shutdown.
Not sure I understand your question. I suppose there are cases where we want to
create non-daemon threads, but typically not in our servers.
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239967#comment-13239967
]
Hudson commented on HBASE-5641:
---
Integrated in HBase-0.94-security #5 (See
[https://builds.apache.org/job/HBase-0.94-security/5/])
HBASE-5641 decayingSampleTick1 prevents HBase from shutting down. (Revision
1305721)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/CHANGES.txt
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239138#comment-13239138
]
Lars Hofhansl commented on HBASE-5641:
--
This fixes the problem for me. Please have a look, so that I can trigger 0.94
build tonight.
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239139#comment-13239139
]
Ted Yu commented on HBASE-5641:
---
+1 on patch.
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239145#comment-13239145
]
Lars Hofhansl commented on HBASE-5641:
--
Committed to 0.94 and 0.96
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5641) decayingSampleTick1 prevents HBase from shutting down.
[
https://issues.apache.org/jira/browse/HBASE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13239175#comment-13239175
]
Hudson commented on HBASE-5641:
---
Integrated in HBase-0.94 #60 (See
[https://builds.apache.org/job/HBase-0.94/60/])
HBASE-5641 decayingSampleTick1 prevents HBase from shutting down. (Revision
1305721)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/CHANGES.txt
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
decayingSampleTick1 prevents HBase from shutting down.
--
Key: HBASE-5641
URL: https://issues.apache.org/jira/browse/HBASE-5641
Project: HBase
Issue Type: Sub-task
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Blocker
Fix For: 0.94.0, 0.96.0
Attachments: 5641.txt
I think this is the problem. It creates a non-daemon thread.
{code}
private static final ScheduledExecutorService TICK_SERVICE =
Executors.newScheduledThreadPool(1,
Threads.getNamedThreadFactory(decayingSampleTick));
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
