[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[
https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271614#comment-13271614
]
ramkrishna.s.vasudevan commented on HBASE-5654:
---
Yes Jon. You can see the latest patch uploaded in that defect? This is how it
has been handled in the latest patch
{code}
case RS_ZK_REGION_SPLITTING:
+LOG.debug("Processed region in state : " + et);
+break;
+ case RS_ZK_REGION_SPLIT:
+LOG.debug("Processed region in state : " + et);
+break;
default:
-throw new IllegalStateException("Received event is not valid.");
+throw new IllegalStateException("Received region in state :" + et + "
is not valid");
{code}
> [findbugs] Address dodgy bugs
> -
>
> Key: HBASE-5654
> URL: https://issues.apache.org/jira/browse/HBASE-5654
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
>Affects Versions: 0.96.0
>Reporter: Jonathan Hsieh
>Assignee: Ashutosh Jindal
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: Hbase 5654_v3.patch, Hbase-5654.patch,
> Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271612#comment-13271612 ] Jonathan Hsieh commented on HBASE-5654: --- Ram - are you going to handle the fix for this in HBASE-5806? > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269640#comment-13269640 ] ramkrishna.s.vasudevan commented on HBASE-5654: --- Because RS_ZK_REGION_SPLIT and RS_ZK_REGION_SPLITTING will not be handled in processRIT. I think in that case we can just say break in default. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269634#comment-13269634 ] ramkrishna.s.vasudevan commented on HBASE-5654: --- Default should not throw illegal argument exception in processRIT on master failover in trunk. Found it when a test case was written for HBASE-5806. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259760#comment-13259760 ] Hudson commented on HBASE-5654: --- Integrated in HBase-TRUNK-security #181 (See [https://builds.apache.org/job/HBase-TRUNK-security/181/]) HBASE-5654 [findbugs] Address dodgy bugs (Ashutosh Jindal) (Revision 1329132) Result = FAILURE jmhsieh : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompoundBloomFilterWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259498#comment-13259498 ] Ashutosh Jindal commented on HBASE-5654: @Jon Thanks for your review and patch you attached for the remaining bugs. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259486#comment-13259486 ] Hudson commented on HBASE-5654: --- Integrated in HBase-TRUNK #2797 (See [https://builds.apache.org/job/HBase-TRUNK/2797/]) HBASE-5654 [findbugs] Address dodgy bugs (Ashutosh Jindal) (Revision 1329132) Result = FAILURE jmhsieh : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/dev-support/test-patch.properties * /hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HServerLoad.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompoundBloomFilterWriter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch, hbase-5654_v5.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259459#comment-13259459 ] Hadoop QA commented on HBASE-5654: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523764/hbase-5654-tweak.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1605//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1605//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1605//console This message is automatically generated. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch, hbase-5654-tweak.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[
https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259434#comment-13259434
]
Jonathan Hsieh commented on HBASE-5654:
---
@Ashotosh - sorry for the delay on review. Looks good.
I believe this isn't needed - looks like it was fixed in code. I'll submit a
new version of the patch with this excluded and to get the new findbug numbers,
and commit.
{code}
+
+
+
+
+
+
+
{code}
> [findbugs] Address dodgy bugs
> -
>
> Key: HBASE-5654
> URL: https://issues.apache.org/jira/browse/HBASE-5654
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
>Affects Versions: 0.96.0
>Reporter: Jonathan Hsieh
>Assignee: Ashutosh Jindal
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: Hbase 5654_v3.patch, Hbase-5654.patch,
> Hbase_5654_V2.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257871#comment-13257871 ] Jonathan Hsieh commented on HBASE-5654: --- @stack. Got it. Thanks. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257743#comment-13257743 ] stack commented on HBASE-5654: -- @Jon Our hadoopqa has been hanging with a while. Its probably not this patch. Maybe compare to previous runs. I'm working on trying to figure out why the hangs meantime. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257652#comment-13257652 ] Jonathan Hsieh commented on HBASE-5654: --- bq. -1 core tests. The patch failed these unit tests: This usually indicates that there was a hung test somewhere -- there is a script in ./dev-* that should help you find it. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257645#comment-13257645 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523367/Hbase+5654_v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1576//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1576//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1576//console This message is automatically generated. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, > Hbase_5654_V2.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256726#comment-13256726 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523209/Hbase_5654_V2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1567//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1567//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1567//console This message is automatically generated. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch, Hbase_5654_V2.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[
https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255719#comment-13255719
]
Jonathan Hsieh commented on HBASE-5654:
---
There are a few match related entries:
Here's how one could likely be fixed.
{code}
public static long calculateOverhead(long maxSize, long blockSize, int
concurrency){
// FindBugs ICAST_INTEGER_MULTIPLY_CAST_TO_LONG
return CACHE_FIXED_OVERHEAD + ClassSize.CONCURRENT_HASHMAP +
((long)Math.ceil(maxSize*1.2/blockSize)
* ClassSize.CONCURRENT_HASHMAP_ENTRY) +
// (concurrency * ClassSize.CONCURRENT_HASHMAP_SEGMENT);
((long)concurrency * (long)ClassSize.CONCURRENT_HASHMAP_SEGMENT);
}
{code}
For bounds checks, I think there was another where a double gets converted to a
long (what happens is double is larger than max long?)
> [findbugs] Address dodgy bugs
> -
>
> Key: HBASE-5654
> URL: https://issues.apache.org/jira/browse/HBASE-5654
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
>Affects Versions: 0.96.0
>Reporter: Jonathan Hsieh
>Assignee: Ashutosh Jindal
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: Hbase-5654.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255475#comment-13255475 ] Ashutosh Jindal commented on HBASE-5654: @Jon bq.add bounds checks? Result of integer multiplication cast to long in org.apache.hadoop.hbase.io.hfile.LruBlockCache.calculateOverhead(long, long, int) bq.Result of integer multiplication cast to long in org.apache.hadoop.hbase.regionserver.IncreasingToUpperBoundRegionSplitPolicy.getSizeToCheck(int) I am not getting what kind of bound checks can be added here. Can u please take a look. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255294#comment-13255294 ] Ashutosh Jindal commented on HBASE-5654: @Jonathan Hsieh Thanks for reviewing the patch. I am going through the comments and will submit an updated patch. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[
https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254802#comment-13254802
]
Jonathan Hsieh commented on HBASE-5654:
---
I'm being pretty strict with excludes -- for an excludes it should be explained
(because they will be ignored forever more.. )
{code}
+
+
+
+
+
+
+
{code}
I think this one may have been handled in anther patch -- maybe this exclude
isn't needed.
{code}
+
+
+
+
+
+
+
{code}
This one is definitely fixable in code instead of exclude.
{code}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
...
+
+
+
+
+
+
+
+
+
...
+
+
+
+
+
+
+
+
+
...
+
+
+
+
+
+
+
{code}
Definitely fixable in code without exclude -- (add default case that does
nothing or enumrate all cases and have default throws some sort of runtime
exception such as IllegalStateException to catch cases where new enums created).
{code}
+
+
+
+
+
+
+
+
{code}
File a separate jira for this one and I'll take care of it. Please to do not
exclude this warning.
{code}
+
+
+
+
+
+
+
+
{code}
Does this do anything? metrics is a package, SchemaConfigured is a class...
{code}
+
+
+
+
+
+
+
+
+
{code}
Probably wants bitSize and maxKeys to be cased to doubles before div.
> [findbugs] Address dodgy bugs
> -
>
> Key: HBASE-5654
> URL: https://issues.apache.org/jira/browse/HBASE-5654
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
>Affects Versions: 0.96.0
>Reporter: Jonathan Hsieh
>Assignee: Ashutosh Jindal
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: Hbase-5654.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254683#comment-13254683 ] Jonathan Hsieh commented on HBASE-5654: --- Ashutosh: Thanks for taking this on. I'm about half way through the excludes. Just starting the INT category. Questions: * why no fix?: WritableRcpEngine#getProxy * why no fix?: Ambiguous invocations in RounRobinPool/ReusablePool (specify scope of get() by changing to this.get() or ReusablePool.this.get()) * add bounds checks?Result of integer multiplication cast to long in org.apache.hadoop.hbase.io.hfile.LruBlockCache.calculateOverhead(long, long, int) Result of integer multiplication cast to long in org.apache.hadoop.hbase.regionserver.IncreasingToUpperBoundRegionSplitPolicy.getSizeToCheck(int) > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254578#comment-13254578 ] Ashutosh Jindal commented on HBASE-5654: @Uma Thank you for your review. I will look into the remaining bugs and submit the updated patch . > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254512#comment-13254512 ] Uma Maheswara Rao G commented on HBASE-5654: Hey Ashutosh, Looks there are some more(3) dodgy category bugs in report. Also current bugs count in the report is lesser than the count updated in test-patch,properties. For the comment in RSStatusTmplImpl, you may have to change in [RSStatusTmpl.jamon |http://svn.apache.org/repos/asf/hbase/trunk/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon] file. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254055#comment-13254055 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522672/Hbase-5654.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1524//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1524//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1524//console This message is automatically generated. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254055#comment-13254055 ] Hadoop QA commented on HBASE-5654: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522672/Hbase-5654.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1524//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1524//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1524//console This message is automatically generated. > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > Attachments: Hbase-5654.patch > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs
[ https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253552#comment-13253552 ] Jonathan Hsieh commented on HBASE-5654: --- Hi Ashutosh, I don't see an attachement -- could you attach one that we could take a look at? Thanks! > [findbugs] Address dodgy bugs > - > > Key: HBASE-5654 > URL: https://issues.apache.org/jira/browse/HBASE-5654 > Project: HBase > Issue Type: Sub-task > Components: scripts >Affects Versions: 0.96.0 >Reporter: Jonathan Hsieh >Assignee: Ashutosh Jindal > Labels: patch > Fix For: 0.96.0 > > > See > https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE > This may be broken down further. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
