[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247445#comment-13247445
]
Jean-Daniel Cryans commented on HBASE-5716:
---
bq. Was there a great correlation between size on disk and size of blog?
I'm not sure I understand the question.
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247496#comment-13247496
]
Li Pi commented on HBASE-5716:
--
Gah. Autocorrect - and me being sleepy.
What I meant is, it seems like there exist cases where log replay time and Hlog
size on disk didn't correlate well before, and there will still be some now -
has it really ever been much of an issue?
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247831#comment-13247831
]
Jean-Daniel Cryans commented on HBASE-5716:
---
I'm asking the same question, I don't know.
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246601#comment-13246601
]
Todd Lipcon commented on HBASE-5716:
My guess is that, if we trust the feature, we should turn it on by default. Is
there any situation in which using it isn't a good idea?
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246605#comment-13246605
]
Jean-Daniel Cryans commented on HBASE-5716:
---
bq. Is there any situation in which using it isn't a good idea?
The one I described.
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246699#comment-13246699
]
Jean-Daniel Cryans commented on HBASE-5716:
---
On thing I just thought about, enabling this feature doesn't change that we
currently still roll on the total size of the file... meaning that you can pack
a lot more data per HLog, this should have some impact on the log replay time.
Not sure if it's for better or worse as you have to read/write more data, but
it's compressed on the wire...
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246730#comment-13246730
]
Li Pi commented on HBASE-5716:
--
Interesting, should we roll on number of edits or size of the file?
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246733#comment-13246733
]
Todd Lipcon commented on HBASE-5716:
bq. The one I described.
What is the measurable impact of having compression on for non-compressible
data? My guess is it's close to 0 (slight hit for trying to match non-repeating
columns into a hash, slight improvement by getting some compression on region
ids and row keys)
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5716) Make HBASE-4608 easier to use
[
https://issues.apache.org/jira/browse/HBASE-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246736#comment-13246736
]
Jean-Daniel Cryans commented on HBASE-5716:
---
bq. should we roll on number of edits or size of the file?
Number of edits is rarely good, you always end up with someone with a
degenerate case that has values MBs big so we should stick to the file size.
Rolling on the uncompressed size would be good because then we keep the same
behavior but this is going to be at the expense more code to keep track of it.
Rolling on the actual size with compression turned on could make system behave
differently for good or worse, I'm not sure which.
Make HBASE-4608 easier to use
-
Key: HBASE-5716
URL: https://issues.apache.org/jira/browse/HBASE-5716
Project: HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Fix For: 0.96.0, 0.94.1
HBASE-4608 is a nice feature but after playing with it for a while I think
the following should be fixed to make it easier to use by someone who's not a
dev:
- Add some signal that says that the feature is turned on. Right now you can
{{jstack | grep KeyValueCompression}} a couple of times and if you get a hit
you definitely know it's on, but otherwise the random user wouldn't know
without going through the jira.
- Add documentation in the reference guide. At the minimum add
{{hbase.regionserver.wal.enablecompression}} in there with a small
description. Better would be to add a section in {{Appendix B}} or something
like that and describe the functionality a bit and who it's useful for. For
example, flush from your brain the knowledge of the patch and read the name
of the configuration... now let's say you have a use case that involves
writing easily compressible values. Any normal user would believe that this
is a good tuning parameter for them, but it's just going to waste CPU cycles.
- Add some metrics like we have for HFiles where you get a clue about the
compression ratio.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
