[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2016-11-16 Thread binlijin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672316#comment-15672316
 ] 

binlijin commented on HBASE-6338:
-

OH yeh, this is not needed any more.

> Cache Method in RPC handler
> ---
>
> Key: HBASE-6338
> URL: https://issues.apache.org/jira/browse/HBASE-6338
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.94.3
>Reporter: binlijin
> Attachments: HBASE-6338-90-2.patch, HBASE-6338-90.patch, 
> HBASE-6338-92-2.patch, HBASE-6338-92.patch, HBASE-6338-94-2.patch, 
> HBASE-6338-94.patch, HBASE-6338-trunk-2.patch, HBASE-6338-trunk.patch
>
>
> Every call in rpc handler a Method will be created, if we cache the method 
> will improve a little.
> I test with 0.90, Average Class.getMethod(String name, Class... 
> parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-11-07 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492710#comment-13492710
 ] 

stack commented on HBASE-6338:
--

Might not be enough of a perf gain to gamble putting it into 0.94?

 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.94.3
Reporter: binlijin
 Attachments: HBASE-6338-90-2.patch, HBASE-6338-90.patch, 
 HBASE-6338-92-2.patch, HBASE-6338-92.patch, HBASE-6338-94-2.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk-2.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-11-06 Thread Devaraj Das (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491851#comment-13491851
 ] 

Devaraj Das commented on HBASE-6338:


On trunk (0.96), the ProtobufRpcEngine already does keep a similar mapping of 
methodname to Method objects.. 

 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-90-2.patch, HBASE-6338-90.patch, 
 HBASE-6338-92-2.patch, HBASE-6338-92.patch, HBASE-6338-94-2.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk-2.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-11-06 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492049#comment-13492049
 ] 

Sergey Shelukhin commented on HBASE-6338:
-

then this seems straightforward to just apply to 0.94

 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Affects Versions: 0.94.3
Reporter: binlijin
 Attachments: HBASE-6338-90-2.patch, HBASE-6338-90.patch, 
 HBASE-6338-92-2.patch, HBASE-6338-92.patch, HBASE-6338-94-2.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk-2.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-10-30 Thread Sergey Shelukhin (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487354#comment-13487354
 ] 

Sergey Shelukhin commented on HBASE-6338:
-

Hi. Is there plan to commit this to .94?


 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-90-2.patch, HBASE-6338-90.patch, 
 HBASE-6338-92-2.patch, HBASE-6338-92.patch, HBASE-6338-94-2.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk-2.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-09-06 Thread Michael Drzal (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449634#comment-13449634
 ] 

Michael Drzal commented on HBASE-6338:
--

[~aoxiang] this seems to have stalled.

 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-90-2.patch, HBASE-6338-90.patch, 
 HBASE-6338-92-2.patch, HBASE-6338-92.patch, HBASE-6338-94-2.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk-2.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-07-12 Thread Anoop Sam John (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413470#comment-13413470
 ] 

Anoop Sam John commented on HBASE-6338:
---

+  sb.append(-);

Better to call StringBuilder#append(char c) for appending the character.
sb.append('-')

 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-90.patch, HBASE-6338-92.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in RPC handler

2012-07-11 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13412061#comment-13412061
 ] 

stack commented on HBASE-6338:
--

Why javadoc a private method (especially a method named getMethod that returns 
a Method)?

 Cache Method in RPC handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-90.patch, HBASE-6338-92.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in rpc handler

2012-07-06 Thread Zhihong Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408059#comment-13408059
 ] 

Zhihong Ted Yu commented on HBASE-6338:
---

The patch is more suitable for 0.94 and lower versions.
WritableRpcEngine is going away in trunk.

 Cache Method in rpc handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6338) Cache Method in rpc handler

2012-07-06 Thread Zhihong Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13408521#comment-13408521
 ] 

Zhihong Ted Yu commented on HBASE-6338:
---

{code}
+private Method getMethod(Class? extends VersionedProtocol protocol,
+String methodName, Class[] parameterClasses) throws Exception {
{code}
javadoc for the above method would be desirable.

Please run test suite for the branches and publish result here.

Thanks

 Cache Method in rpc handler
 ---

 Key: HBASE-6338
 URL: https://issues.apache.org/jira/browse/HBASE-6338
 Project: HBase
  Issue Type: Improvement
Reporter: binlijin
 Attachments: HBASE-6338-90.patch, HBASE-6338-92.patch, 
 HBASE-6338-94.patch, HBASE-6338-trunk.patch


 Every call in rpc handler a Method will be created, if we cache the method 
 will improve a little.
 I test with 0.90, Average Class.getMethod(String name, Class... 
 parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira